| Message ID | 20210118111426.5147-1-johan@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | USB: serial: drop short control-transfer checks | expand |
Hi Himadri, On Mon, Jan 18, 2021 at 12:14:20PM +0100, Johan Hovold wrote: > There's no need to check for short control transfers when sending data > so remove the redundant sanity checks from the drivers that had them. > > Included is also a related fix of a copy-paste error in a debug message. > > Johan > > > Johan Hovold (6): > USB: serial: mxuport: drop short control-transfer check > USB: serial: upd78f0730: drop short control-transfer check > USB: serial: io_ti: drop short control-transfer check > USB: serial: io_ti: fix a debug-message copy-paste error > USB: serial: f81232: drop short control-transfer checks > USB: serial: f81534: drop short control-transfer check > > drivers/usb/serial/f81232.c | 12 ++---------- > drivers/usb/serial/f81534.c | 4 +--- > drivers/usb/serial/io_ti.c | 8 ++------ > drivers/usb/serial/mxuport.c | 7 ------- > drivers/usb/serial/upd78f0730.c | 5 +---- > 5 files changed, 6 insertions(+), 30 deletions(-) I intended to CC you on this series, but forgot to do so before hitting send. The series can be found here: https://lore.kernel.org/r/20210118111426.5147-1-johan@kernel.org I checked to make sure it doesn't interfere too much with your revised series. Johan
On Mon, Jan 18, 2021 at 12:14:20PM +0100, Johan Hovold wrote: > There's no need to check for short control transfers when sending data > so remove the redundant sanity checks from the drivers that had them. It seems impossible to do a "short write", so I wonder why we even check it... Anyway, nice cleanups: Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
On Mon, Jan 18, 2021 at 01:46:28PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 18, 2021 at 12:14:20PM +0100, Johan Hovold wrote: > > There's no need to check for short control transfers when sending data > > so remove the redundant sanity checks from the drivers that had them. > > It seems impossible to do a "short write", so I wonder why we even check > it... Right, and this series removes precisely those redundant checks. Or what did you mean? :) > Anyway, nice cleanups: > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Thanks for reviewing, now applied. Johan