| Message ID | 20210117085346.25095-1-dinghao.liu@zju.edu.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] block: Fix an error handling in add_partition | expand |
On Sun 17-01-21 16:53:42, Dinghao Liu wrote: > Once we have called device_initialize(), we should use put_device() to > give up the reference on error, just like what we have done on failure > of device_add(). > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Looks good to me. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > > Changelog: > > v2: - Refine commit message. > > v3: - Add '[v3]' to the title. > --- > block/partitions/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/partitions/core.c b/block/partitions/core.c > index e7d776db803b..23460cee9de5 100644 > --- a/block/partitions/core.c > +++ b/block/partitions/core.c > @@ -384,7 +384,7 @@ static struct block_device *add_partition(struct gendisk *disk, int partno, > > err = blk_alloc_devt(bdev, &devt); > if (err) > - goto out_bdput; > + goto out_put; > pdev->devt = devt; > > /* delay uevent until 'holders' subdir is created */ > -- > 2.17.1 >
On 1/17/21 1:00 AM, Dinghao Liu wrote: > Once we have called device_initialize(), we should use put_device() to > give up the reference on error, just like what we have done on failure > of device_add(). > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
diff --git a/block/partitions/core.c b/block/partitions/core.c index e7d776db803b..23460cee9de5 100644 --- a/block/partitions/core.c +++ b/block/partitions/core.c @@ -384,7 +384,7 @@ static struct block_device *add_partition(struct gendisk *disk, int partno, err = blk_alloc_devt(bdev, &devt); if (err) - goto out_bdput; + goto out_put; pdev->devt = devt; /* delay uevent until 'holders' subdir is created */
Once we have called device_initialize(), we should use put_device() to give up the reference on error, just like what we have done on failure of device_add(). Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- Changelog: v2: - Refine commit message. v3: - Add '[v3]' to the title. --- block/partitions/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)