diff mbox series

scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit

Message ID 20210118184922.23793-1-ematsumiya@suse.de (mailing list archive)
State Accepted
Headers show
Series scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit | expand

Commit Message

Enzo Matsumiya Jan. 18, 2021, 6:49 p.m. UTC
Parameter ql2xenforce_iocb_limit is enabled by default.

Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
---
 drivers/scsi/qla2xxx/qla_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Wagner Jan. 19, 2021, 8:55 a.m. UTC | #1
On Mon, Jan 18, 2021 at 03:49:22PM -0300, Enzo Matsumiya wrote:
> Parameter ql2xenforce_iocb_limit is enabled by default.
> 
> Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
> Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>

Reviewed-by: Daniel Wagner <dwagner@suse.de>
Himanshu Madhani Jan. 19, 2021, 3:16 p.m. UTC | #2
> On Jan 18, 2021, at 12:49 PM, Enzo Matsumiya <ematsumiya@suse.de> wrote:
> 
> Parameter ql2xenforce_iocb_limit is enabled by default.
> 
> Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
> Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index f80abe28f35a..0e0fe5b09496 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -42,7 +42,7 @@ MODULE_PARM_DESC(ql2xfulldump_on_mpifail,
> int ql2xenforce_iocb_limit = 1;
> module_param(ql2xenforce_iocb_limit, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(ql2xenforce_iocb_limit,
> -		 "Enforce IOCB throttling, to avoid FW congestion. (default: 0)");
> +		 "Enforce IOCB throttling, to avoid FW congestion. (default: 1)");
> 
> /*
>  * CT6 CTX allocation cache
> -- 
> 2.29.2
> 

Good Catch. 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering
Martin K. Petersen Jan. 21, 2021, 3:35 a.m. UTC | #3
On Mon, 18 Jan 2021 15:49:22 -0300, Enzo Matsumiya wrote:

> Parameter ql2xenforce_iocb_limit is enabled by default.

Applied to 5.11/scsi-fixes, thanks!

[1/1] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit
      https://git.kernel.org/mkp/scsi/c/aa2c24e7f415
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index f80abe28f35a..0e0fe5b09496 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -42,7 +42,7 @@  MODULE_PARM_DESC(ql2xfulldump_on_mpifail,
 int ql2xenforce_iocb_limit = 1;
 module_param(ql2xenforce_iocb_limit, int, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(ql2xenforce_iocb_limit,
-		 "Enforce IOCB throttling, to avoid FW congestion. (default: 0)");
+		 "Enforce IOCB throttling, to avoid FW congestion. (default: 1)");
 
 /*
  * CT6 CTX allocation cache