mbox series

[0/2] thermal: Replace thermal_notify_framework with thermal_zone_device_update

Message ID 20210119140541.2453490-1-thara.gopinath@linaro.org (mailing list archive)
Headers show
Series thermal: Replace thermal_notify_framework with thermal_zone_device_update | expand

Message

Thara Gopinath Jan. 19, 2021, 2:05 p.m. UTC
thermal_notify_framework just updates for a single trip point where as
thermal_zone_device_update does other bookkeeping like updating the
temperature of the thermal zone, running through the list of trip points
and setting the next trip point etc. Since  the later is a more thorough
version of former, replace thermal_notify_framework with
thermal_zone_device_update. 

Thara Gopinath (2):
  net: wireless: intel: iwlwifi: mvm: tt: Replace
    thermal_notify_framework
  drivers: thermal: Remove thermal_notify_framework

 drivers/net/wireless/intel/iwlwifi/mvm/tt.c |  4 ++--
 drivers/thermal/thermal_core.c              | 18 ------------------
 include/linux/thermal.h                     |  4 ----
 3 files changed, 2 insertions(+), 24 deletions(-)

Comments

Zhang Rui Jan. 20, 2021, 2:56 a.m. UTC | #1
Hi, Thara,

Thanks for the cleanup. I've proposed similar patches previously.
https://patchwork.kernel.org/project/linux-pm/patch/20200430063229.6182-2-rui.zhang@intel.com/
https://patchwork.kernel.org/project/linux-pm/patch/20200430063229.6182-3-rui.zhang@intel.com/
can you please also address the comments in the previous discussion, like doc cleanup?

Thanks,
rui

> -----Original Message-----
> From: Thara Gopinath <thara.gopinath@linaro.org>
> Sent: Tuesday, January 19, 2021 10:06 PM
> To: Zhang, Rui <rui.zhang@intel.com>; daniel.lezcano@linaro.org;
> kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org; Coelho,
> Luciano <luciano.coelho@intel.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; linux-pm@vger.kernel.org; amitk@kernel.org;
> Errera, Nathan <nathan.errera@intel.com>
> Subject: [PATCH 0/2] thermal: Replace thermal_notify_framework with
> thermal_zone_device_update
> Importance: High
> 
> thermal_notify_framework just updates for a single trip point where as
> thermal_zone_device_update does other bookkeeping like updating the
> temperature of the thermal zone, running through the list of trip points and
> setting the next trip point etc. Since  the later is a more thorough version of
> former, replace thermal_notify_framework with
> thermal_zone_device_update.
> 
> Thara Gopinath (2):
>   net: wireless: intel: iwlwifi: mvm: tt: Replace
>     thermal_notify_framework
>   drivers: thermal: Remove thermal_notify_framework
> 
>  drivers/net/wireless/intel/iwlwifi/mvm/tt.c |  4 ++--
>  drivers/thermal/thermal_core.c              | 18 ------------------
>  include/linux/thermal.h                     |  4 ----
>  3 files changed, 2 insertions(+), 24 deletions(-)
> 
> --
> 2.25.1
Thara Gopinath Jan. 20, 2021, 10:53 a.m. UTC | #2
On 1/19/21 9:56 PM, Zhang, Rui wrote:
> Hi, Thara,
> 
> Thanks for the cleanup. I've proposed similar patches previously.
> https://patchwork.kernel.org/project/linux-pm/patch/20200430063229.6182-2-rui.zhang@intel.com/
> https://patchwork.kernel.org/project/linux-pm/patch/20200430063229.6182-3-rui.zhang@intel.com/
> can you please also address the comments in the previous discussion, like doc cleanup?

Hi Rui,

Thanks for the quick feedback. I am sorry, I was not aware of your 
earlier series. I will add a patch cleaning up the Documentation and
send the v2. I have not tested this patch much. But I see from the
comments on your patches that this has been tested out. So that is good.

> 
> Thanks,
> rui
> 
>> -----Original Message-----
>> From: Thara Gopinath <thara.gopinath@linaro.org>
>> Sent: Tuesday, January 19, 2021 10:06 PM
>> To: Zhang, Rui <rui.zhang@intel.com>; daniel.lezcano@linaro.org;
>> kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org; Coelho,
>> Luciano <luciano.coelho@intel.com>
>> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
>> netdev@vger.kernel.org; linux-pm@vger.kernel.org; amitk@kernel.org;
>> Errera, Nathan <nathan.errera@intel.com>
>> Subject: [PATCH 0/2] thermal: Replace thermal_notify_framework with
>> thermal_zone_device_update
>> Importance: High
>>
>> thermal_notify_framework just updates for a single trip point where as
>> thermal_zone_device_update does other bookkeeping like updating the
>> temperature of the thermal zone, running through the list of trip points and
>> setting the next trip point etc. Since  the later is a more thorough version of
>> former, replace thermal_notify_framework with
>> thermal_zone_device_update.
>>
>> Thara Gopinath (2):
>>    net: wireless: intel: iwlwifi: mvm: tt: Replace
>>      thermal_notify_framework
>>    drivers: thermal: Remove thermal_notify_framework
>>
>>   drivers/net/wireless/intel/iwlwifi/mvm/tt.c |  4 ++--
>>   drivers/thermal/thermal_core.c              | 18 ------------------
>>   include/linux/thermal.h                     |  4 ----
>>   3 files changed, 2 insertions(+), 24 deletions(-)
>>
>> --
>> 2.25.1
>