| Message ID | 20210120072711.209099-1-ying.huang@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | swap: Check nrexceptional of swap cache before being freed | expand |
On Wed 20-01-21 15:27:11, Huang Ying wrote: > To catch the error in updating the swap cache shadow entries or their count. What is the error? Can it happens in the real life? Why do we need this patch? Is crashing the kernel the right way to handle the situation? > Signed-off-by: "Huang, Ying" <ying.huang@intel.com> > Cc: Minchan Kim <minchan@kernel.org> > Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>, > Cc: Johannes Weiner <hannes@cmpxchg.org>, > Cc: Vlastimil Babka <vbabka@suse.cz>, Hugh Dickins <hughd@google.com>, > Cc: Mel Gorman <mgorman@techsingularity.net>, > Cc: Michal Hocko <mhocko@kernel.org>, > Cc: Dan Williams <dan.j.williams@intel.com>, > Cc: Christoph Hellwig <hch@lst.de>, Ilya Dryomov <idryomov@gmail.com>, > --- > mm/swap_state.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/swap_state.c b/mm/swap_state.c > index d0d417efeecc..240a4f97594a 100644 > --- a/mm/swap_state.c > +++ b/mm/swap_state.c > @@ -703,7 +703,12 @@ int init_swap_address_space(unsigned int type, unsigned long nr_pages) > > void exit_swap_address_space(unsigned int type) > { > - kvfree(swapper_spaces[type]); > + int i; > + struct address_space *spaces = swapper_spaces[type]; > + > + for (i = 0; i < nr_swapper_spaces[type]; i++) > + VM_BUG_ON(spaces[i].nrexceptional); > + kvfree(spaces); > nr_swapper_spaces[type] = 0; > swapper_spaces[type] = NULL; > } > -- > 2.29.2
Michal Hocko <mhocko@suse.com> writes: > On Wed 20-01-21 15:27:11, Huang Ying wrote: >> To catch the error in updating the swap cache shadow entries or their count. > > What is the error? There's no error in the current code. But we will change the related code in the future. So this checking will help us to prevent error in the future. I will change the patch description to make it more clear. > Can it happens in the real life? Why do we need this > patch? Is crashing the kernel the right way to handle the situation? Emm... The mistake to update swap shadow entries will hurt performance, but will not trigger functionality bug. So it may be better to use VM_WARN_ON_ONCE(). Best Regards, Huang, Ying >> Signed-off-by: "Huang, Ying" <ying.huang@intel.com> >> Cc: Minchan Kim <minchan@kernel.org> >> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>, >> Cc: Johannes Weiner <hannes@cmpxchg.org>, >> Cc: Vlastimil Babka <vbabka@suse.cz>, Hugh Dickins <hughd@google.com>, >> Cc: Mel Gorman <mgorman@techsingularity.net>, >> Cc: Michal Hocko <mhocko@kernel.org>, >> Cc: Dan Williams <dan.j.williams@intel.com>, >> Cc: Christoph Hellwig <hch@lst.de>, Ilya Dryomov <idryomov@gmail.com>, >> --- >> mm/swap_state.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/mm/swap_state.c b/mm/swap_state.c >> index d0d417efeecc..240a4f97594a 100644 >> --- a/mm/swap_state.c >> +++ b/mm/swap_state.c >> @@ -703,7 +703,12 @@ int init_swap_address_space(unsigned int type, unsigned long nr_pages) >> >> void exit_swap_address_space(unsigned int type) >> { >> - kvfree(swapper_spaces[type]); >> + int i; >> + struct address_space *spaces = swapper_spaces[type]; >> + >> + for (i = 0; i < nr_swapper_spaces[type]; i++) >> + VM_BUG_ON(spaces[i].nrexceptional); >> + kvfree(spaces); >> nr_swapper_spaces[type] = 0; >> swapper_spaces[type] = NULL; >> } >> -- >> 2.29.2
On Wed 20-01-21 15:54:04, Huang, Ying wrote: > Michal Hocko <mhocko@suse.com> writes: > > > On Wed 20-01-21 15:27:11, Huang Ying wrote: > >> To catch the error in updating the swap cache shadow entries or their count. > > > > What is the error? > > There's no error in the current code. But we will change the related > code in the future. So this checking will help us to prevent error in > the future. I will change the patch description to make it more clear. > > > Can it happens in the real life? Why do we need this > > patch? Is crashing the kernel the right way to handle the situation? > > Emm... The mistake to update swap shadow entries will hurt performance, > but will not trigger functionality bug. So it may be better to use > VM_WARN_ON_ONCE(). Yes a warning is much more appropriate approach. The question is whether a test like this is really necessary. But I will leave that to others to decide. It was really the bug on that hit my eyes.
On Wed, Jan 20, 2021 at 03:27:11PM +0800, Huang Ying wrote: > To catch the error in updating the swap cache shadow entries or their count. I just resent a patch that removes nrexceptional tracking. Can you use !mapping_empty() instead? > void exit_swap_address_space(unsigned int type) > { > - kvfree(swapper_spaces[type]); > + int i; > + struct address_space *spaces = swapper_spaces[type]; > + > + for (i = 0; i < nr_swapper_spaces[type]; i++) > + VM_BUG_ON(spaces[i].nrexceptional); > + kvfree(spaces); > nr_swapper_spaces[type] = 0; > swapper_spaces[type] = NULL; > } > -- > 2.29.2 > >
Matthew Wilcox <willy@infradead.org> writes: > On Wed, Jan 20, 2021 at 03:27:11PM +0800, Huang Ying wrote: >> To catch the error in updating the swap cache shadow entries or their count. > > I just resent a patch that removes nrexceptional tracking. > > Can you use !mapping_empty() instead? Sure. Will use that in the next version. Best Regards, Huang, Ying >> void exit_swap_address_space(unsigned int type) >> { >> - kvfree(swapper_spaces[type]); >> + int i; >> + struct address_space *spaces = swapper_spaces[type]; >> + >> + for (i = 0; i < nr_swapper_spaces[type]; i++) >> + VM_BUG_ON(spaces[i].nrexceptional); >> + kvfree(spaces); >> nr_swapper_spaces[type] = 0; >> swapper_spaces[type] = NULL; >> } >> -- >> 2.29.2 >> >>
diff --git a/mm/swap_state.c b/mm/swap_state.c index d0d417efeecc..240a4f97594a 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c @@ -703,7 +703,12 @@ int init_swap_address_space(unsigned int type, unsigned long nr_pages) void exit_swap_address_space(unsigned int type) { - kvfree(swapper_spaces[type]); + int i; + struct address_space *spaces = swapper_spaces[type]; + + for (i = 0; i < nr_swapper_spaces[type]; i++) + VM_BUG_ON(spaces[i].nrexceptional); + kvfree(spaces); nr_swapper_spaces[type] = 0; swapper_spaces[type] = NULL; }
To catch the error in updating the swap cache shadow entries or their count. Signed-off-by: "Huang, Ying" <ying.huang@intel.com> Cc: Minchan Kim <minchan@kernel.org> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>, Cc: Johannes Weiner <hannes@cmpxchg.org>, Cc: Vlastimil Babka <vbabka@suse.cz>, Hugh Dickins <hughd@google.com>, Cc: Mel Gorman <mgorman@techsingularity.net>, Cc: Michal Hocko <mhocko@kernel.org>, Cc: Dan Williams <dan.j.williams@intel.com>, Cc: Christoph Hellwig <hch@lst.de>, Ilya Dryomov <idryomov@gmail.com>, --- mm/swap_state.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)