| Message ID | 20210120122818.GA34342@ubuntu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm/memblock: Fix the typo on comments. | expand |
On 20.01.21 13:28, Levi Yun wrote: > memblock_phys_alloc_try_nid function's comments has typo NUMA as MUMA. > Correct this typo. subject would be clearer as something like "mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid()" Reviewed-by: David Hildenbrand <david@redhat.com> > > Signed-off-by: Levi Yun <ppbuk5246@gmail.com> > --- > mm/memblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index d24bcfa88d2f..1eaaec1e7687 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1427,7 +1427,7 @@ phys_addr_t __init memblock_phys_alloc_range(phys_addr_t size, > } > > /** > - * memblock_phys_alloc_try_nid - allocate a memory block from specified MUMA node > + * memblock_phys_alloc_try_nid - allocate a memory block from specified NUMA node > * @size: size of memory block to be allocated in bytes > * @align: alignment of the region and block's size > * @nid: nid of the free area to find, %NUMA_NO_NODE for any node >
> subject would be clearer as something like > > "mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid()" > > Reviewed-by: David Hildenbrand <david@redhat.com> Thanks. Then, should I resend this patch with suggested subject with Reviewed-by tag?
On Thu, Jan 21, 2021 at 08:43:20AM +0900, Yun Levi wrote: > > subject would be clearer as something like > > > > "mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid()" > > > > Reviewed-by: David Hildenbrand <david@redhat.com> > > Thanks. Then, should I resend this patch with suggested subject with > Reviewed-by tag? In general, yes. When there are minor review comments and Reviewed-by tag, you should send v2 version of a patch that addresses the comments and has the Reviewed-by tag. Since this is a small patch and a small update, I've applied the patch with the subject David suggested to memblock/fixes branch.
> In general, yes. When there are minor review comments and Reviewed-by tag, > you should send v2 version of a patch that addresses the comments and has > the Reviewed-by tag. > > Since this is a small patch and a small update, I've applied the patch with > the subject David suggested to memblock/fixes branch. I got it. Thanks.
diff --git a/mm/memblock.c b/mm/memblock.c index d24bcfa88d2f..1eaaec1e7687 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1427,7 +1427,7 @@ phys_addr_t __init memblock_phys_alloc_range(phys_addr_t size, } /** - * memblock_phys_alloc_try_nid - allocate a memory block from specified MUMA node + * memblock_phys_alloc_try_nid - allocate a memory block from specified NUMA node * @size: size of memory block to be allocated in bytes * @align: alignment of the region and block's size * @nid: nid of the free area to find, %NUMA_NO_NODE for any node
memblock_phys_alloc_try_nid function's comments has typo NUMA as MUMA. Correct this typo. Signed-off-by: Levi Yun <ppbuk5246@gmail.com> --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)