ARM: dts: sun7i: a20: bananapro: Fix ethernet node

Commit Message

[e-mail] Jan. 20, 2021, 11:40 a.m. UTC

BananaPro 1GB works only reliable with the patch for M2 Ultra applied to
it's devicetree, too. Without this patch you will get high packet loss rates.

Tested-by: Hermann Lauer <[e-mail]>

From b3eec3212e66ece33f69be0de98d54e67834e798 Mon Sep 17 00:00:00 2001
From: Jernej Skrabec <[e-mail]>
Date: Sun, 25 Oct 2020 09:19:49 +0100
Subject: ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix ethernet node

Ethernet PHY on BananaPi M2 Ultra provides RX and TX delays. Fix
ethernet node to reflect that fact.

Fixes: c36fd5a48bd2 ("ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable GMAC ethernet controller")
---
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jernej Škrabec Jan. 20, 2021, 11:48 p.m. UTC | #1

Hi!

Change itself it's fine, just few comments on your commit message and e-mail 
recipients.

Dne sreda, 20. januar 2021 ob 12:40:26 CET je [e-mail] 
napisal(a):
> BananaPro 1GB works only reliable with the patch for M2 Ultra applied to
> it's devicetree, too. Without this patch you will get high packet loss 
rates.

M2 Ultra has nothing to do with BananaPro, it's better to explain real reason 
why this change fixes ethernet.

> 
> Tested-by: Hermann Lauer <[e-mail]>

Tested-by tag from the patch author is not very useful, it's already expected 
that you (or person you know) tested it, when sending fixes.

> 
> From b3eec3212e66ece33f69be0de98d54e67834e798 Mon Sep 17 00:00:00 2001
> From: Jernej Skrabec <[e-mail]>
> Date: Sun, 25 Oct 2020 09:19:49 +0100
> Subject: ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix ethernet node

As I said, referencing fix for another, unrelated board is not really 
meaningful.

> 
> Ethernet PHY on BananaPi M2 Ultra provides RX and TX delays. Fix
> ethernet node to reflect that fact.
> 
> Fixes: c36fd5a48bd2 ("ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable GMAC 
ethernet controller")

Fixes tag is for M2 Ultra and completely irrelevant here. Please provide 
proper Fixes tag for this file.

You are missing Signed-of-by tag at the end of the message.

You missed few maintainers and mailing lists in "to" and "cc" field. Run 
"scripts/get_maintainer.pl" on this patch to get full list of recipients.

Best regards,
Jernej

Patch

diff --git a/arch/arm/boot/dts/sun7i-a20-bananapro.dts b/arch/arm/boot/dts/sun7i-a20-bananapro.dts
--- a/arch/arm/boot/dts/sun7i-a20-bananapro.dts
+++ b/arch/arm/boot/dts/sun7i-a20-bananapro.dts
@@ -110,7 +110,7 @@ 
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac_rgmii_pins>;
 	phy-handle = <&phy1>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-supply = <&reg_gmac_3v3>;
 	status = "okay";
 };