mbox series

[0/2] arm64: mm: fix kdump broken with ZONE_DMA reintroduced

Message ID 20201226033557.116251-1-chenzhou10@huawei.com (mailing list archive)
Headers show
Series arm64: mm: fix kdump broken with ZONE_DMA reintroduced | expand

Message

chenzhou Dec. 26, 2020, 3:35 a.m. UTC
If the memory reserved for crash dump kernel falled in ZONE_DMA32,
the devices in crash dump kernel need to use ZONE_DMA will alloc fail.
           
Fix this by reserving low memory in ZONE_DMA if CONFIG_ZONE_DMA is
enabled, otherwise, reserving in ZONE_DMA32.

Patch 1 updates the comments about the ZONE_DMA.
Patch 2 fix kdump broken.

Chen Zhou (2):
  arm64: mm: update the comments about ZONE_DMA
  arm64: mm: fix kdump broken with ZONE_DMA reintroduced

 arch/arm64/mm/init.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

Comments

Will Deacon Jan. 20, 2021, 12:40 p.m. UTC | #1
On Sat, Dec 26, 2020 at 11:35:55AM +0800, Chen Zhou wrote:
> If the memory reserved for crash dump kernel falled in ZONE_DMA32,
> the devices in crash dump kernel need to use ZONE_DMA will alloc fail.
>            
> Fix this by reserving low memory in ZONE_DMA if CONFIG_ZONE_DMA is
> enabled, otherwise, reserving in ZONE_DMA32.
> 
> Patch 1 updates the comments about the ZONE_DMA.
> Patch 2 fix kdump broken.
> 
> Chen Zhou (2):
>   arm64: mm: update the comments about ZONE_DMA
>   arm64: mm: fix kdump broken with ZONE_DMA reintroduced

Please can you repost this if it is still needed after the changes that
landed in -rc4?

Will
Catalin Marinas Jan. 20, 2021, 1:07 p.m. UTC | #2
On Wed, Jan 20, 2021 at 12:40:55PM +0000, Will Deacon wrote:
> On Sat, Dec 26, 2020 at 11:35:55AM +0800, Chen Zhou wrote:
> > If the memory reserved for crash dump kernel falled in ZONE_DMA32,
> > the devices in crash dump kernel need to use ZONE_DMA will alloc fail.
> >            
> > Fix this by reserving low memory in ZONE_DMA if CONFIG_ZONE_DMA is
> > enabled, otherwise, reserving in ZONE_DMA32.
> > 
> > Patch 1 updates the comments about the ZONE_DMA.
> > Patch 2 fix kdump broken.
> > 
> > Chen Zhou (2):
> >   arm64: mm: update the comments about ZONE_DMA
> >   arm64: mm: fix kdump broken with ZONE_DMA reintroduced
> 
> Please can you repost this if it is still needed after the changes that
> landed in -rc4?

I don't think this series is needed anymore but I'll let Chen confirm.
chenzhou Jan. 21, 2021, 2:37 a.m. UTC | #3
Hi Will, Catalin,


On 2021/1/20 21:07, Catalin Marinas wrote:
> On Wed, Jan 20, 2021 at 12:40:55PM +0000, Will Deacon wrote:
>> On Sat, Dec 26, 2020 at 11:35:55AM +0800, Chen Zhou wrote:
>>> If the memory reserved for crash dump kernel falled in ZONE_DMA32,
>>> the devices in crash dump kernel need to use ZONE_DMA will alloc fail.
>>>            
>>> Fix this by reserving low memory in ZONE_DMA if CONFIG_ZONE_DMA is
>>> enabled, otherwise, reserving in ZONE_DMA32.
>>>
>>> Patch 1 updates the comments about the ZONE_DMA.
>>> Patch 2 fix kdump broken.
>>>
>>> Chen Zhou (2):
>>>   arm64: mm: update the comments about ZONE_DMA
>>>   arm64: mm: fix kdump broken with ZONE_DMA reintroduced
>> Please can you repost this if it is still needed after the changes that
>> landed in -rc4?
> I don't think this series is needed anymore but I'll let Chen confirm.
Yes, we don't need this series, Catalin has solved the issue i mentioned.

I will repost the series "support reserving crashkernel above 4G on arm64 kdump"
based on the latest code.

Thanks,
Chen Zhou