mbox series

[v2,0/3] Improvements to nfsd stats

Message ID 20210106075236.4184-1-amir73il@gmail.com (mailing list archive)
Headers show
Series Improvements to nfsd stats | expand

Message

Amir Goldstein Jan. 6, 2021, 7:52 a.m. UTC
Hi Bruce,

Per your request, I added a cleanup patch for unused counter.

Replaced the hacky counters array "union" with proper array
and added helpers to update the counters to avoid human mistakes
related to counter indices.

Thanks,
Amir.

Changes since v1:
- Cleanup unused stats counters (Bruce)
- Replace counters array hack with proper array (Chuck)
- Helpers to update both global and per-export stats

Amir Goldstein (3):
  nfsd: remove unused stats counters
  nfsd: protect concurrent access to nfsd stats counters
  nfsd: report per-export stats

 fs/nfsd/export.c   |  68 +++++++++++++++++++++++----
 fs/nfsd/export.h   |  15 ++++++
 fs/nfsd/netns.h    |  23 +++++----
 fs/nfsd/nfs4proc.c |   2 +-
 fs/nfsd/nfscache.c |  52 +++++++++++++++------
 fs/nfsd/nfsctl.c   |   8 +++-
 fs/nfsd/nfsd.h     |   2 +-
 fs/nfsd/nfsfh.c    |   4 +-
 fs/nfsd/stats.c    | 114 +++++++++++++++++++++++++++++++--------------
 fs/nfsd/stats.h    |  96 +++++++++++++++++++++++++++++---------
 fs/nfsd/vfs.c      |   4 +-
 11 files changed, 292 insertions(+), 96 deletions(-)

Comments

Chuck Lever Jan. 21, 2021, 11:39 p.m. UTC | #1
Hello Amir!

> On Jan 6, 2021, at 2:52 AM, Amir Goldstein <amir73il@gmail.com> wrote:
> 
> Hi Bruce,
> 
> Per your request, I added a cleanup patch for unused counter.
> 
> Replaced the hacky counters array "union" with proper array
> and added helpers to update the counters to avoid human mistakes
> related to counter indices.

Thanks for your patches. v2 of your series has been committed
to the for-next branch at

git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git

in preparation for the v5.12 merge window.


> Thanks,
> Amir.
> 
> Changes since v1:
> - Cleanup unused stats counters (Bruce)
> - Replace counters array hack with proper array (Chuck)
> - Helpers to update both global and per-export stats
> 
> Amir Goldstein (3):
>  nfsd: remove unused stats counters
>  nfsd: protect concurrent access to nfsd stats counters
>  nfsd: report per-export stats
> 
> fs/nfsd/export.c   |  68 +++++++++++++++++++++++----
> fs/nfsd/export.h   |  15 ++++++
> fs/nfsd/netns.h    |  23 +++++----
> fs/nfsd/nfs4proc.c |   2 +-
> fs/nfsd/nfscache.c |  52 +++++++++++++++------
> fs/nfsd/nfsctl.c   |   8 +++-
> fs/nfsd/nfsd.h     |   2 +-
> fs/nfsd/nfsfh.c    |   4 +-
> fs/nfsd/stats.c    | 114 +++++++++++++++++++++++++++++++--------------
> fs/nfsd/stats.h    |  96 +++++++++++++++++++++++++++++---------
> fs/nfsd/vfs.c      |   4 +-
> 11 files changed, 292 insertions(+), 96 deletions(-)
> 
> -- 
> 2.17.1
> 

--
Chuck Lever
Amir Goldstein Jan. 22, 2021, 6:54 a.m. UTC | #2
On Fri, Jan 22, 2021 at 1:39 AM Chuck Lever <chuck.lever@oracle.com> wrote:
>
> Hello Amir!
>
> > On Jan 6, 2021, at 2:52 AM, Amir Goldstein <amir73il@gmail.com> wrote:
> >
> > Hi Bruce,
> >
> > Per your request, I added a cleanup patch for unused counter.
> >
> > Replaced the hacky counters array "union" with proper array
> > and added helpers to update the counters to avoid human mistakes
> > related to counter indices.
>
> Thanks for your patches. v2 of your series has been committed
> to the for-next branch at
>
> git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
>
> in preparation for the v5.12 merge window.
>

Great!

Thanks for the notice,
Amir.