| Message ID | 20210111142309.193441-14-maxime@cerno.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/vc4: hdmi: Add CEC support for the BCM2711 | expand |
Hi Maxime On Mon, 11 Jan 2021 at 14:23, Maxime Ripard <maxime@cerno.tech> wrote: > > The CEC and hotplug interrupts were missing when that binding was > introduced, let's add them in now that we've figured out how it works. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Looks reasonable to me, but I'm not a DT bindings expert Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > --- > .../bindings/display/brcm,bcm2711-hdmi.yaml | 20 ++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > index 7ce06f9f9f8e..6e8ac910bdd8 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > @@ -53,6 +53,24 @@ properties: > - const: audio > - const: cec > > + interrupts: > + items: > + - description: CEC TX interrupt > + - description: CEC RX interrupt > + - description: CEC stuck at low interrupt > + - description: Wake-up interrupt > + - description: Hotplug connected interrupt > + - description: Hotplug removed interrupt > + > + interrupt-names: > + items: > + - const: cec-tx > + - const: cec-rx > + - const: cec-low > + - const: wakeup > + - const: hpd-connected > + - const: hpd-removed > + > ddc: > allOf: > - $ref: /schemas/types.yaml#/definitions/phandle > @@ -90,7 +108,7 @@ required: > - resets > - ddc > > -additionalProperties: false > +unevaluatedProperties: false > > examples: > - | > -- > 2.29.2 >
On Mon, Jan 11, 2021 at 8:27 AM Maxime Ripard <maxime@cerno.tech> wrote: > > The CEC and hotplug interrupts were missing when that binding was > introduced, let's add them in now that we've figured out how it works. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- > .../bindings/display/brcm,bcm2711-hdmi.yaml | 20 ++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > index 7ce06f9f9f8e..6e8ac910bdd8 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > @@ -53,6 +53,24 @@ properties: > - const: audio > - const: cec > > + interrupts: > + items: > + - description: CEC TX interrupt > + - description: CEC RX interrupt > + - description: CEC stuck at low interrupt > + - description: Wake-up interrupt > + - description: Hotplug connected interrupt > + - description: Hotplug removed interrupt > + > + interrupt-names: > + items: > + - const: cec-tx > + - const: cec-rx > + - const: cec-low > + - const: wakeup > + - const: hpd-connected > + - const: hpd-removed > + > ddc: > allOf: > - $ref: /schemas/types.yaml#/definitions/phandle > @@ -90,7 +108,7 @@ required: > - resets > - ddc > > -additionalProperties: false > +unevaluatedProperties: false /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml: 'additionalProperties' is a required property And you missed the DT list, so no checks ran. Rob
On Mon, Feb 1, 2021 at 12:56 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Jan 11, 2021 at 8:27 AM Maxime Ripard <maxime@cerno.tech> wrote: > > > > The CEC and hotplug interrupts were missing when that binding was > > introduced, let's add them in now that we've figured out how it works. > > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > --- > > .../bindings/display/brcm,bcm2711-hdmi.yaml | 20 ++++++++++++++++++- > > 1 file changed, 19 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > > index 7ce06f9f9f8e..6e8ac910bdd8 100644 > > --- a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > > @@ -53,6 +53,24 @@ properties: > > - const: audio > > - const: cec > > > > + interrupts: > > + items: > > + - description: CEC TX interrupt > > + - description: CEC RX interrupt > > + - description: CEC stuck at low interrupt > > + - description: Wake-up interrupt > > + - description: Hotplug connected interrupt > > + - description: Hotplug removed interrupt > > + > > + interrupt-names: > > + items: > > + - const: cec-tx > > + - const: cec-rx > > + - const: cec-low > > + - const: wakeup > > + - const: hpd-connected > > + - const: hpd-removed > > + > > ddc: > > allOf: > > - $ref: /schemas/types.yaml#/definitions/phandle > > @@ -90,7 +108,7 @@ required: > > - resets > > - ddc > > > > -additionalProperties: false > > +unevaluatedProperties: false > > /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml: > 'additionalProperties' is a required property > > And you missed the DT list, so no checks ran. This is still failing in linux-next. Rob
diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml index 7ce06f9f9f8e..6e8ac910bdd8 100644 --- a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml @@ -53,6 +53,24 @@ properties: - const: audio - const: cec + interrupts: + items: + - description: CEC TX interrupt + - description: CEC RX interrupt + - description: CEC stuck at low interrupt + - description: Wake-up interrupt + - description: Hotplug connected interrupt + - description: Hotplug removed interrupt + + interrupt-names: + items: + - const: cec-tx + - const: cec-rx + - const: cec-low + - const: wakeup + - const: hpd-connected + - const: hpd-removed + ddc: allOf: - $ref: /schemas/types.yaml#/definitions/phandle @@ -90,7 +108,7 @@ required: - resets - ddc -additionalProperties: false +unevaluatedProperties: false examples: - |
The CEC and hotplug interrupts were missing when that binding was introduced, let's add them in now that we've figured out how it works. Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- .../bindings/display/brcm,bcm2711-hdmi.yaml | 20 ++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-)