| Message ID | 1611274735-303873-3-git-send-email-komlodi@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/microblaze: Add memattrs on transactions | expand |
On 1/21/21 2:18 PM, Joe Komlodi wrote: > Using MMUAccessType makes it more clear what the variable's use is. > No functional change. > > Signed-off-by: Joe Komlodi <komlodi@xilinx.com> > --- > target/microblaze/mmu.c | 2 +- > target/microblaze/mmu.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Thu, Jan 21, 2021 at 04:18:54PM -0800, Joe Komlodi wrote: > Using MMUAccessType makes it more clear what the variable's use is. > No functional change. Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Tested-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > Signed-off-by: Joe Komlodi <komlodi@xilinx.com> > --- > target/microblaze/mmu.c | 2 +- > target/microblaze/mmu.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c > index 1e42696..cc40f27 100644 > --- a/target/microblaze/mmu.c > +++ b/target/microblaze/mmu.c > @@ -74,7 +74,7 @@ static void mmu_change_pid(CPUMBState *env, unsigned int newpid) > > /* rw - 0 = read, 1 = write, 2 = fetch. */ > unsigned int mmu_translate(MicroBlazeCPU *cpu, MicroBlazeMMULookup *lu, > - target_ulong vaddr, int rw, int mmu_idx) > + target_ulong vaddr, MMUAccessType rw, int mmu_idx) > { > MicroBlazeMMU *mmu = &cpu->env.mmu; > unsigned int i, hit = 0; > diff --git a/target/microblaze/mmu.h b/target/microblaze/mmu.h > index 09e4075..b6b4b9a 100644 > --- a/target/microblaze/mmu.h > +++ b/target/microblaze/mmu.h > @@ -84,7 +84,7 @@ typedef struct { > } MicroBlazeMMULookup; > > unsigned int mmu_translate(MicroBlazeCPU *cpu, MicroBlazeMMULookup *lu, > - target_ulong vaddr, int rw, int mmu_idx); > + target_ulong vaddr, MMUAccessType rw, int mmu_idx); > uint32_t mmu_read(CPUMBState *env, bool ea, uint32_t rn); > void mmu_write(CPUMBState *env, bool ea, uint32_t rn, uint32_t v); > void mmu_init(MicroBlazeMMU *mmu); > -- > 2.7.4 >
diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index 1e42696..cc40f27 100644 --- a/target/microblaze/mmu.c +++ b/target/microblaze/mmu.c @@ -74,7 +74,7 @@ static void mmu_change_pid(CPUMBState *env, unsigned int newpid) /* rw - 0 = read, 1 = write, 2 = fetch. */ unsigned int mmu_translate(MicroBlazeCPU *cpu, MicroBlazeMMULookup *lu, - target_ulong vaddr, int rw, int mmu_idx) + target_ulong vaddr, MMUAccessType rw, int mmu_idx) { MicroBlazeMMU *mmu = &cpu->env.mmu; unsigned int i, hit = 0; diff --git a/target/microblaze/mmu.h b/target/microblaze/mmu.h index 09e4075..b6b4b9a 100644 --- a/target/microblaze/mmu.h +++ b/target/microblaze/mmu.h @@ -84,7 +84,7 @@ typedef struct { } MicroBlazeMMULookup; unsigned int mmu_translate(MicroBlazeCPU *cpu, MicroBlazeMMULookup *lu, - target_ulong vaddr, int rw, int mmu_idx); + target_ulong vaddr, MMUAccessType rw, int mmu_idx); uint32_t mmu_read(CPUMBState *env, bool ea, uint32_t rn); void mmu_write(CPUMBState *env, bool ea, uint32_t rn, uint32_t v); void mmu_init(MicroBlazeMMU *mmu);
Using MMUAccessType makes it more clear what the variable's use is. No functional change. Signed-off-by: Joe Komlodi <komlodi@xilinx.com> --- target/microblaze/mmu.c | 2 +- target/microblaze/mmu.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)