| Message ID | 20201220203638.43615-1-bigeasy@linutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | scsi: target: Remove in_interrupt() usage. | expand |
On 2020-12-20 21:36:32 [+0100], To target-devel@vger.kernel.org wrote: > Folks, > > in the discussion about preempt count consistency across kernel > configurations: > > https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/ > > it was concluded that the usage of in_interrupt() and related context > checks should be removed from non-core code. > > In the long run, usage of 'preemptible, in_*irq etc.' should be banned from > driver code completely. > > This series addresses the target subsystem. > Most of in_interrupt() usage is debugging. There is one function which > either invokes wait_for_completion() or schedules a timer based on > in_interrupt(). A gentle ping case it got buried somewhere in the merge window / xmas. My understanding is that nab is out-of-town and target gets routed via scsi. Sebastian
Sebastian,
> A gentle ping case it got buried somewhere in the merge window / xmas.
It didn't get any reviews, presumably thanks to being submitted right
before the holidays. However, it looks OK to me.
Applied to 5.12/scsi-staging, thanks!
On Sun, 20 Dec 2020 21:36:32 +0100, Sebastian Andrzej Siewior wrote: > Folks, > > in the discussion about preempt count consistency across kernel > configurations: > > https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/ > > [...] Applied to 5.12/scsi-queue, thanks! [1/6] scsi: target: iscsi: Avoid in_interrupt() usage in iscsit_close_session(). https://git.kernel.org/mkp/scsi/c/433675486af4 [2/6] scsi: target: iscsi: Avoid in_interrupt() usage in iscsit_check_session_usage_count(). https://git.kernel.org/mkp/scsi/c/efc9d73063c1 [3/6] scsi: target: iscsi: Redo iscsit_check_session_usage_count() return code. https://git.kernel.org/mkp/scsi/c/f88a10f80da9 [4/6] scsi: target: Remove in_interrupt() usage in core_alua_check_nonop_delay() https://git.kernel.org/mkp/scsi/c/a97451ac1e34 [5/6] scsi: target: Replace in_interrupt() usage in target_submit_cmd_map_sgls() https://git.kernel.org/mkp/scsi/c/513e29946ab2 [6/6] scsi: target: Remove in_interrupt() check in transport_handle_cdb_direct() https://git.kernel.org/mkp/scsi/c/bbb087679d5f