| Message ID | 20210125083051.828205-1-kai.vehmanen@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c5b5ff607d6fe5f4284acabd07066f96ecf96ac4 |
| Headers | show |
| Series | ALSA: hda: intel-dsp-config: add PCI id for TGL-H | expand |
On Mon, 25 Jan 2021 09:30:51 +0100, Kai Vehmanen wrote: > > From: Bard Liao <bard.liao@intel.com> > > Adding PCI id for TGL-H. Like for other TGL platforms, SOF is used if > Soundwire codecs or PCH-DMIC is detected. > > Signed-off-by: Bard Liao <bard.liao@intel.com> > Reviewed-by: Xiuli Pan <xiuli.pan@intel.com> > Reviewed-by: Libin Yang <libin.yang@intel.com> > Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> Is this needed for 5.11 or only for 5.12? (Or potentially needed for 5.11.x stable later? -- then we can take it now, too) thanks, Takashi > --- > sound/hda/intel-dsp-config.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c > index 6a0d070c60c9..c45686172517 100644 > --- a/sound/hda/intel-dsp-config.c > +++ b/sound/hda/intel-dsp-config.c > @@ -307,6 +307,10 @@ static const struct config_entry config_table[] = { > .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, > .device = 0xa0c8, > }, > + { > + .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, > + .device = 0x43c8, > + }, > #endif > > /* Elkhart Lake */ > -- > 2.29.2 >
Dne 25. 01. 21 v 9:49 Takashi Iwai napsal(a): > On Mon, 25 Jan 2021 09:30:51 +0100, > Kai Vehmanen wrote: >> >> From: Bard Liao <bard.liao@intel.com> >> >> Adding PCI id for TGL-H. Like for other TGL platforms, SOF is used if >> Soundwire codecs or PCH-DMIC is detected. >> >> Signed-off-by: Bard Liao <bard.liao@intel.com> >> Reviewed-by: Xiuli Pan <xiuli.pan@intel.com> >> Reviewed-by: Libin Yang <libin.yang@intel.com> >> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> > > Is this needed for 5.11 or only for 5.12? > (Or potentially needed for 5.11.x stable later? -- then we can take it > now, too) All patches sent by Kai today are required to add support for the SoundWire device Dell TGL-H SKU 0A5E in 5.11. But I think that this standalone patch may enable the DMIC only platforms. Jaroslav
Hi, On Mon, 25 Jan 2021, Jaroslav Kysela wrote: > Dne 25. 01. 21 v 9:49 Takashi Iwai napsal(a): > > Is this needed for 5.11 or only for 5.12? > > (Or potentially needed for 5.11.x stable later? -- then we can take it > > All patches sent by Kai today are required to add support for the SoundWire > device Dell TGL-H SKU 0A5E in 5.11. But I think that this standalone patch may > enable the DMIC only platforms. ack on that. We are a bit late for 5.11 with these patches, but the more we can get to 5.11, the better. 5.11-rc already has support for snd-hda-intel and baseline SOF support, but this single patch helps system with a PCH-DMIC. The remaining patches sent via today ASoC, enable one Soundwire SKU. Br, Kai
On Mon, 25 Jan 2021 10:28:58 +0100, Kai Vehmanen wrote: > > Hi, > > On Mon, 25 Jan 2021, Jaroslav Kysela wrote: > > > Dne 25. 01. 21 v 9:49 Takashi Iwai napsal(a): > > > Is this needed for 5.11 or only for 5.12? > > > (Or potentially needed for 5.11.x stable later? -- then we can take it > > > > All patches sent by Kai today are required to add support for the SoundWire > > device Dell TGL-H SKU 0A5E in 5.11. But I think that this standalone patch may > > enable the DMIC only platforms. > > ack on that. We are a bit late for 5.11 with these patches, but the more > we can get to 5.11, the better. 5.11-rc already has support for > snd-hda-intel and baseline SOF support, but this single patch helps system > with a PCH-DMIC. OK, now applied. Thanks. Takashi
diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c index 6a0d070c60c9..c45686172517 100644 --- a/sound/hda/intel-dsp-config.c +++ b/sound/hda/intel-dsp-config.c @@ -307,6 +307,10 @@ static const struct config_entry config_table[] = { .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, .device = 0xa0c8, }, + { + .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, + .device = 0x43c8, + }, #endif /* Elkhart Lake */