| Message ID | 1610440409-73330-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtlwifi: rtl8821ae: style: Simplify bool comparison | expand |
On Tue, 2021-01-12 at 16:33 +0800, YANG LI wrote: > Fix the following coccicheck warning: > ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17: > WARNING: Comparison of 0/1 to bool variable > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com> > I think your name of Signed-off-by should be "Yang Li". And, the subject prefix "rtlwifi: " is preferred. --- Ping-Ke
Pkshih <pkshih@realtek.com> writes: > On Tue, 2021-01-12 at 16:33 +0800, YANG LI wrote: >> Fix the following coccicheck warning: >> ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17: >> WARNING: Comparison of 0/1 to bool variable >> >> Reported-by: Abaci Robot <abaci@linux.alibaba.com> >> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com> >> > > I think your name of Signed-off-by should be "Yang Li". > > And, the subject prefix "rtlwifi: " is preferred. I can fix those during commit.
YANG LI <abaci-bugfix@linux.alibaba.com> wrote: > Fix the following coccicheck warning: > ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17: > WARNING: Comparison of 0/1 to bool variable > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com> Patchwork gives me this From field: From: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> I guess you are sharing the same email address with multiple persons? And patchwork stored the first person using that address? I recommend using individual addresses for each person submitting patches. I cannot apply this.
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c index 372d6f8..1fb857c 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c @@ -3848,7 +3848,7 @@ static void _rtl8821ae_iqk_tx(struct ieee80211_hw *hw, enum radio_path path) else rtl_write_dword(rtlpriv, 0xc8c, 0x00163e96); - if (vdf_enable == 1) { + if (vdf_enable) { rtl_dbg(rtlpriv, COMP_IQK, DBG_LOUD, "VDF_enable\n"); for (k = 0; k <= 2; k++) { switch (k) {
Fix the following coccicheck warning: ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17: WARNING: Comparison of 0/1 to bool variable Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)