| Message ID | 20210127212137.3482291-2-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block/nvme: Minor tracing improvements | expand |
On Jan 27 22:21, Philippe Mathieu-Daudé wrote: > Commit 15b2260bef3 ("block/nvme: Trace controller capabilities") > misunderstood the doorbell stride value from the datasheet, use > the correct one. The 'doorbell_scale' variable used few lines > later is correct. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Klaus Jensen <k.jensen@samsung.com> > --- > block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/nvme.c b/block/nvme.c > index 5a6fbacf4a5..80c4318d8fc 100644 > --- a/block/nvme.c > +++ b/block/nvme.c > @@ -745,7 +745,7 @@ static int nvme_init(BlockDriverState *bs, const char *device, int namespace, > trace_nvme_controller_capability("Contiguous Queues Required", > NVME_CAP_CQR(cap)); > trace_nvme_controller_capability("Doorbell Stride", > - 2 << (2 + NVME_CAP_DSTRD(cap))); > + 1 << (2 + NVME_CAP_DSTRD(cap))); > trace_nvme_controller_capability("Subsystem Reset Supported", > NVME_CAP_NSSRS(cap)); > trace_nvme_controller_capability("Memory Page Size Minimum", > -- > 2.26.2 > >
diff --git a/block/nvme.c b/block/nvme.c index 5a6fbacf4a5..80c4318d8fc 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -745,7 +745,7 @@ static int nvme_init(BlockDriverState *bs, const char *device, int namespace, trace_nvme_controller_capability("Contiguous Queues Required", NVME_CAP_CQR(cap)); trace_nvme_controller_capability("Doorbell Stride", - 2 << (2 + NVME_CAP_DSTRD(cap))); + 1 << (2 + NVME_CAP_DSTRD(cap))); trace_nvme_controller_capability("Subsystem Reset Supported", NVME_CAP_NSSRS(cap)); trace_nvme_controller_capability("Memory Page Size Minimum",
Commit 15b2260bef3 ("block/nvme: Trace controller capabilities") misunderstood the doorbell stride value from the datasheet, use the correct one. The 'doorbell_scale' variable used few lines later is correct. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)