Message ID | 20210126081539.13320-2-lengchao@huawei.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | avoid double request completion and IO error | expand |
> +static inline void blk_mq_set_request_complete(struct request *rq) > +{ > + WRITE_ONCE(rq->state, MQ_RQ_COMPLETE); > +} This function needs a detailed comment explaining the use case. Otherwise we'll get lots of driver abuses.
On 2021/1/28 0:40, Christoph Hellwig wrote: >> +static inline void blk_mq_set_request_complete(struct request *rq) >> +{ >> + WRITE_ONCE(rq->state, MQ_RQ_COMPLETE); >> +} > > This function needs a detailed comment explaining the use case. > Otherwise we'll get lots of driver abuses. ok, thanks. > . >
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h index 47b021952ac7..fc096b04bb7a 100644 --- a/include/linux/blk-mq.h +++ b/include/linux/blk-mq.h @@ -494,6 +494,11 @@ static inline int blk_mq_request_completed(struct request *rq) return blk_mq_rq_state(rq) == MQ_RQ_COMPLETE; } +static inline void blk_mq_set_request_complete(struct request *rq) +{ + WRITE_ONCE(rq->state, MQ_RQ_COMPLETE); +} + void blk_mq_start_request(struct request *rq); void blk_mq_end_request(struct request *rq, blk_status_t error); void __blk_mq_end_request(struct request *rq, blk_status_t error);
nvme drivers need to set the state of request to MQ_RQ_COMPLETE when directly complete request in queue_rq. So add blk_mq_set_request_complete. Signed-off-by: Chao Leng <lengchao@huawei.com> --- include/linux/blk-mq.h | 5 +++++ 1 file changed, 5 insertions(+)