| Message ID | 20210126182113.19892-2-david@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm: simplify free_highmem_page() and free_reserved_page() | expand |
On Tue, Jan 26, 2021 at 11:54 PM David Hildenbrand <david@redhat.com> wrote: > This function is never used and it is one of the last remaining user of > __free_reserved_page(). Let's just drop it. > > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org> > Cc: Mike Rapoport <rppt@kernel.org> > Cc: Oscar Salvador <osalvador@suse.de> > Cc: Michal Hocko <mhocko@kernel.org> > Cc: Wei Yang <richard.weiyang@linux.alibaba.com> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: Sam Ravnborg <sam@ravnborg.org> > Signed-off-by: David Hildenbrand <david@redhat.com> Fixes: ffd29195ed720188 ("drivers/video/acornfb.c: remove dead code") Gr{oetje,eeting}s, Geert
On Tue, Jan 26, 2021 at 07:21:12PM +0100, David Hildenbrand wrote: > This function is never used and it is one of the last remaining user of > __free_reserved_page(). Let's just drop it. > > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org> > Cc: Mike Rapoport <rppt@kernel.org> > Cc: Oscar Salvador <osalvador@suse.de> > Cc: Michal Hocko <mhocko@kernel.org> > Cc: Wei Yang <richard.weiyang@linux.alibaba.com> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: Sam Ravnborg <sam@ravnborg.org> > Signed-off-by: David Hildenbrand <david@redhat.com> Reviewed-by: Oscar Salvador <osalvador@suse.de> > --- > drivers/video/fbdev/acornfb.c | 34 ---------------------------------- > 1 file changed, 34 deletions(-) > > diff --git a/drivers/video/fbdev/acornfb.c b/drivers/video/fbdev/acornfb.c > index bcc92aecf666..1b72edc01cfb 100644 > --- a/drivers/video/fbdev/acornfb.c > +++ b/drivers/video/fbdev/acornfb.c > @@ -921,40 +921,6 @@ static int acornfb_detect_monitortype(void) > return 4; > } > > -/* > - * This enables the unused memory to be freed on older Acorn machines. > - * We are freeing memory on behalf of the architecture initialisation > - * code here. > - */ > -static inline void > -free_unused_pages(unsigned int virtual_start, unsigned int virtual_end) > -{ > - int mb_freed = 0; > - > - /* > - * Align addresses > - */ > - virtual_start = PAGE_ALIGN(virtual_start); > - virtual_end = PAGE_ALIGN(virtual_end); > - > - while (virtual_start < virtual_end) { > - struct page *page; > - > - /* > - * Clear page reserved bit, > - * set count to 1, and free > - * the page. > - */ > - page = virt_to_page(virtual_start); > - __free_reserved_page(page); > - > - virtual_start += PAGE_SIZE; > - mb_freed += PAGE_SIZE / 1024; > - } > - > - printk("acornfb: freed %dK memory\n", mb_freed); > -} > - > static int acornfb_probe(struct platform_device *dev) > { > unsigned long size; > -- > 2.29.2 >
On 1/26/21 11:51 PM, David Hildenbrand wrote: > This function is never used and it is one of the last remaining user of > __free_reserved_page(). Let's just drop it. > > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org> > Cc: Mike Rapoport <rppt@kernel.org> > Cc: Oscar Salvador <osalvador@suse.de> > Cc: Michal Hocko <mhocko@kernel.org> > Cc: Wei Yang <richard.weiyang@linux.alibaba.com> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: Sam Ravnborg <sam@ravnborg.org> > Signed-off-by: David Hildenbrand <david@redhat.com> There is no other reference for free_unused_pages() in the tree. Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> > --- > drivers/video/fbdev/acornfb.c | 34 ---------------------------------- > 1 file changed, 34 deletions(-) > > diff --git a/drivers/video/fbdev/acornfb.c b/drivers/video/fbdev/acornfb.c > index bcc92aecf666..1b72edc01cfb 100644 > --- a/drivers/video/fbdev/acornfb.c > +++ b/drivers/video/fbdev/acornfb.c > @@ -921,40 +921,6 @@ static int acornfb_detect_monitortype(void) > return 4; > } > > -/* > - * This enables the unused memory to be freed on older Acorn machines. > - * We are freeing memory on behalf of the architecture initialisation > - * code here. > - */ > -static inline void > -free_unused_pages(unsigned int virtual_start, unsigned int virtual_end) > -{ > - int mb_freed = 0; > - > - /* > - * Align addresses > - */ > - virtual_start = PAGE_ALIGN(virtual_start); > - virtual_end = PAGE_ALIGN(virtual_end); > - > - while (virtual_start < virtual_end) { > - struct page *page; > - > - /* > - * Clear page reserved bit, > - * set count to 1, and free > - * the page. > - */ > - page = virt_to_page(virtual_start); > - __free_reserved_page(page); > - > - virtual_start += PAGE_SIZE; > - mb_freed += PAGE_SIZE / 1024; > - } > - > - printk("acornfb: freed %dK memory\n", mb_freed); > -} > - > static int acornfb_probe(struct platform_device *dev) > { > unsigned long size; >
diff --git a/drivers/video/fbdev/acornfb.c b/drivers/video/fbdev/acornfb.c index bcc92aecf666..1b72edc01cfb 100644 --- a/drivers/video/fbdev/acornfb.c +++ b/drivers/video/fbdev/acornfb.c @@ -921,40 +921,6 @@ static int acornfb_detect_monitortype(void) return 4; } -/* - * This enables the unused memory to be freed on older Acorn machines. - * We are freeing memory on behalf of the architecture initialisation - * code here. - */ -static inline void -free_unused_pages(unsigned int virtual_start, unsigned int virtual_end) -{ - int mb_freed = 0; - - /* - * Align addresses - */ - virtual_start = PAGE_ALIGN(virtual_start); - virtual_end = PAGE_ALIGN(virtual_end); - - while (virtual_start < virtual_end) { - struct page *page; - - /* - * Clear page reserved bit, - * set count to 1, and free - * the page. - */ - page = virt_to_page(virtual_start); - __free_reserved_page(page); - - virtual_start += PAGE_SIZE; - mb_freed += PAGE_SIZE / 1024; - } - - printk("acornfb: freed %dK memory\n", mb_freed); -} - static int acornfb_probe(struct platform_device *dev) { unsigned long size;
This function is never used and it is one of the last remaining user of __free_reserved_page(). Let's just drop it. Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org> Cc: Mike Rapoport <rppt@kernel.org> Cc: Oscar Salvador <osalvador@suse.de> Cc: Michal Hocko <mhocko@kernel.org> Cc: Wei Yang <richard.weiyang@linux.alibaba.com> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> Cc: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: David Hildenbrand <david@redhat.com> --- drivers/video/fbdev/acornfb.c | 34 ---------------------------------- 1 file changed, 34 deletions(-)