| Message ID | 20210128111842.GA11919@lemon.iwr.uni-heidelberg.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode | expand |
On Thu, Jan 28, 2021 at 12:18:42PM +0100, Hermann.Lauer@uni-heidelberg.de wrote: > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > packet loss rates. The realtek phy driver overrides the settings of the > pull ups for the delays, so fix this for BananaPro. > > Fix the phy-mode description to correctly reflect this so that the > implementation doesn't reconfigure the delays incorrectly. This > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > rx/tx delay config"). > > Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro board") > Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de> Applied since it's a fix simple enough, but please provide a changelog between versions. Maxime
On Thu, Jan 28, 2021 at 03:59:37PM +0100, Maxime Ripard wrote: > On Thu, Jan 28, 2021 at 12:18:42PM +0100, Hermann.Lauer@uni-heidelberg.de wrote: > > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > > packet loss rates. The realtek phy driver overrides the settings of the > > pull ups for the delays, so fix this for BananaPro. > > > > Fix the phy-mode description to correctly reflect this so that the > > implementation doesn't reconfigure the delays incorrectly. This > > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > > rx/tx delay config"). > > > > Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro board") > > Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de> > > Applied since it's a fix simple enough, but please provide a changelog > between versions. v3 added the correct fixes tag, where the problem originated (initial commit of banana pro device tree). That worked in the past until a change in the phy device driver for realtek phy on banana pro overrode the phyical configuration of the hardware pull-ups. v4 added the commit which implemented that driver change (shamelessly stolen from the commit of the fix of the identical problem on the banana pi) Thanks, greetings Hermann
On Mon, Feb 01, 2021 at 01:08:03PM +0100, Hermann Lauer wrote: > On Thu, Jan 28, 2021 at 03:59:37PM +0100, Maxime Ripard wrote: > > On Thu, Jan 28, 2021 at 12:18:42PM +0100, Hermann.Lauer@uni-heidelberg.de wrote: > > > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > > > packet loss rates. The realtek phy driver overrides the settings of the > > > pull ups for the delays, so fix this for BananaPro. > > > > > > Fix the phy-mode description to correctly reflect this so that the > > > implementation doesn't reconfigure the delays incorrectly. This > > > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > > > rx/tx delay config"). > > > > > > Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro board") > > > Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de> > > > > Applied since it's a fix simple enough, but please provide a changelog > > between versions. > > v3 added the correct fixes tag, where the problem originated (initial commit > of banana pro device tree). That worked in the past until a change in > the phy device driver for realtek phy on banana pro overrode the > phyical configuration of the hardware pull-ups. > > v4 added the commit which implemented that driver change (shamelessly stolen > from the commit of the fix of the identical problem on the banana pi) Thanks :) For future patches make sure to have that description either in a cover letter or below the --- after your commit log Maxime
diff --git a/arch/arm/boot/dts/sun7i-a20-bananapro.dts b/arch/arm/boot/dts/sun7i-a20-bananapro.dts --- a/arch/arm/boot/dts/sun7i-a20-bananapro.dts +++ b/arch/arm/boot/dts/sun7i-a20-bananapro.dts @@ -110,7 +110,7 @@ pinctrl-names = "default"; pinctrl-0 = <&gmac_rgmii_pins>; phy-handle = <&phy1>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-supply = <®_gmac_3v3>; status = "okay"; };
BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high packet loss rates. The realtek phy driver overrides the settings of the pull ups for the delays, so fix this for BananaPro. Fix the phy-mode description to correctly reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config"). Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro board") Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de> --- arch/arm/boot/dts/sun7i-a20-bananapro.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)