diff mbox series

arm64: dts: meson: fix broken wifi node for Khadas VIM3L

Message ID 20210129085041.1408540-1-art@khadas.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: meson: fix broken wifi node for Khadas VIM3L | expand

Commit Message

Artem Lapkin Jan. 29, 2021, 8:50 a.m. UTC
move &sd_emmc_a ... from /* */ commented area, because cant load wifi fw
without sd-uhs-sdr50 option on VIM3L

[   11.686590] brcmfmac: brcmf_chip_cores_check: CPU core not detected
[   11.696382] brcmfmac: brcmf_sdio_probe_attach: brcmf_chip_attach failed!
[   11.706240] brcmfmac: brcmf_sdio_probe: brcmf_sdio_probe_attach failed
[   11.715890] brcmfmac: brcmf_ops_sdio_probe: F2 error, probe failed -19...
[   13.718424] brcmfmac: brcmf_chip_recognition: chip backplane type 15 is not supported

Signed-off-by: Artem Lapkin <art@khadas.com>
---
 arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Neil Armstrong Jan. 29, 2021, 8:57 a.m. UTC | #1
Hi,

On 29/01/2021 09:50, Artem Lapkin wrote:
> move &sd_emmc_a ... from /* */ commented area, because cant load wifi fw
> without sd-uhs-sdr50 option on VIM3L

Seems it was an apply/merge issue here.

> 
> [   11.686590] brcmfmac: brcmf_chip_cores_check: CPU core not detected
> [   11.696382] brcmfmac: brcmf_sdio_probe_attach: brcmf_chip_attach failed!
> [   11.706240] brcmfmac: brcmf_sdio_probe: brcmf_sdio_probe_attach failed
> [   11.715890] brcmfmac: brcmf_ops_sdio_probe: F2 error, probe failed -19...
> [   13.718424] brcmfmac: brcmf_chip_recognition: chip backplane type 15 is not supported
> 

Fixes: f1bb924e8f5b ("arm64: dts: meson: fix mmc0 tuning error on Khadas VIM3")
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> index 4b517ca72..29c785cf5 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> @@ -89,13 +89,13 @@ &pcie {
>  	status = "okay";
>  };
>  
> -&sd_emmc_a {
> -	sd-uhs-sdr50;
> -};
> -
>  &usb {
>  	phys = <&usb2_phy0>, <&usb2_phy1>;
>  	phy-names = "usb2-phy0", "usb2-phy1";
>  };
>   */
>  
> +&sd_emmc_a {
> +	sd-uhs-sdr50;
> +};
> +
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Kevin Hilman Feb. 3, 2021, 7:27 p.m. UTC | #2
On Fri, 29 Jan 2021 16:50:40 +0800, Artem Lapkin wrote:
> move &sd_emmc_a ... from /* */ commented area, because cant load wifi fw
> without sd-uhs-sdr50 option on VIM3L
> 
> [   11.686590] brcmfmac: brcmf_chip_cores_check: CPU core not detected
> [   11.696382] brcmfmac: brcmf_sdio_probe_attach: brcmf_chip_attach failed!
> [   11.706240] brcmfmac: brcmf_sdio_probe: brcmf_sdio_probe_attach failed
> [   11.715890] brcmfmac: brcmf_ops_sdio_probe: F2 error, probe failed -19...
> [   13.718424] brcmfmac: brcmf_chip_recognition: chip backplane type 15 is not supported

Applied, thanks!

[1/1] arm64: dts: meson: fix broken wifi node for Khadas VIM3L
      commit: 39be8f441f78908e97ff913571e10ec03387a63a

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
index 4b517ca72..29c785cf5 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
@@ -89,13 +89,13 @@  &pcie {
 	status = "okay";
 };
 
-&sd_emmc_a {
-	sd-uhs-sdr50;
-};
-
 &usb {
 	phys = <&usb2_phy0>, <&usb2_phy1>;
 	phy-names = "usb2-phy0", "usb2-phy1";
 };
  */
 
+&sd_emmc_a {
+	sd-uhs-sdr50;
+};
+