| Message ID | cover.1611346706.git.osandov@fb.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | fs: interface for directly reading/writing compressed data | expand |
On 1/22/21 3:46 PM, Omar Sandoval wrote: > From: Omar Sandoval <osandov@fb.com> > > This series adds an API for reading compressed data on a filesystem > without decompressing it as well as support for writing compressed data > directly to the filesystem. As with the previous submissions, I've > included a man page patch describing the API. I have test cases > (including fsstress support) and example programs which I'll send up > [1]. > > The main use-case is Btrfs send/receive: currently, when sending data > from one compressed filesystem to another, the sending side decompresses > the data and the receiving side recompresses it before writing it out. > This is wasteful and can be avoided if we can just send and write > compressed extents. The patches implementing the send/receive support > will be sent shortly. > > Patches 1-3 add the VFS support and UAPI. Patch 4 is a fix that this > series depends on; it can be merged independently. Patches 5-8 are Btrfs > prep patches. Patch 9 adds Btrfs encoded read support and patch 10 adds > Btrfs encoded write support. > > These patches are based on Dave Sterba's Btrfs misc-next branch [2], > which is in turn currently based on v5.11-rc4. > Is everybody OK with this? Al? I would like to go ahead and get this merged for the next merge window as long as everybody is OK with it, as it's blocking a fair bit of BTRFS work. Thanks, Josef
On Fri, Jan 29, 2021 at 11:32:06AM -0500, Josef Bacik wrote: > On 1/22/21 3:46 PM, Omar Sandoval wrote: > > From: Omar Sandoval <osandov@fb.com> > > > > This series adds an API for reading compressed data on a filesystem > > without decompressing it as well as support for writing compressed data > > directly to the filesystem. As with the previous submissions, I've > > included a man page patch describing the API. I have test cases > > (including fsstress support) and example programs which I'll send up > > [1]. > > > > The main use-case is Btrfs send/receive: currently, when sending data > > from one compressed filesystem to another, the sending side decompresses > > the data and the receiving side recompresses it before writing it out. > > This is wasteful and can be avoided if we can just send and write > > compressed extents. The patches implementing the send/receive support > > will be sent shortly. > > > > Patches 1-3 add the VFS support and UAPI. Patch 4 is a fix that this > > series depends on; it can be merged independently. Patches 5-8 are Btrfs > > prep patches. Patch 9 adds Btrfs encoded read support and patch 10 adds > > Btrfs encoded write support. > > > > These patches are based on Dave Sterba's Btrfs misc-next branch [2], > > which is in turn currently based on v5.11-rc4. > > > > Is everybody OK with this? Al? I would like to go ahead and get this > merged for the next merge window as long as everybody is OK with it, as it's > blocking a fair bit of BTRFS work. Thanks, Ping. Al, Christoph, any thoughts?
From: Omar Sandoval <osandov@fb.com> This series adds an API for reading compressed data on a filesystem without decompressing it as well as support for writing compressed data directly to the filesystem. As with the previous submissions, I've included a man page patch describing the API. I have test cases (including fsstress support) and example programs which I'll send up [1]. The main use-case is Btrfs send/receive: currently, when sending data from one compressed filesystem to another, the sending side decompresses the data and the receiving side recompresses it before writing it out. This is wasteful and can be avoided if we can just send and write compressed extents. The patches implementing the send/receive support will be sent shortly. Patches 1-3 add the VFS support and UAPI. Patch 4 is a fix that this series depends on; it can be merged independently. Patches 5-8 are Btrfs prep patches. Patch 9 adds Btrfs encoded read support and patch 10 adds Btrfs encoded write support. These patches are based on Dave Sterba's Btrfs misc-next branch [2], which is in turn currently based on v5.11-rc4. Changes since v6 [3]: - Dropped O_CLOEXEC requirement for O_ALLOW_ENCODED. - Readded lost FMODE_ENCODED_IO check. - Used macros instead of enum for ENCODED_IOV_COMPRESSION_* and ENCODED_IOV_ENCRYPTION_*. - Moved encoded I/O definitions to their own UAPI header file. - Fixed style nits. - Added reviewed-bys. - Addressed man page nits. 1: https://github.com/osandov/xfstests/tree/rwf-encoded 2: https://github.com/kdave/btrfs-devel/tree/misc-next 3: https://lore.kernel.org/linux-btrfs/cover.1605723568.git.osandov@fb.com/ Omar Sandoval (10): iov_iter: add copy_struct_from_iter() fs: add O_ALLOW_ENCODED open flag fs: add RWF_ENCODED for reading/writing compressed data btrfs: fix check_data_csum() error message for direct I/O btrfs: don't advance offset for compressed bios in btrfs_csum_one_bio() btrfs: add ram_bytes and offset to btrfs_ordered_extent btrfs: support different disk extent size for delalloc btrfs: optionally extend i_size in cow_file_range_inline() btrfs: implement RWF_ENCODED reads btrfs: implement RWF_ENCODED writes Documentation/filesystems/encoded_io.rst | 74 ++ Documentation/filesystems/index.rst | 1 + arch/alpha/include/uapi/asm/fcntl.h | 1 + arch/parisc/include/uapi/asm/fcntl.h | 1 + arch/sparc/include/uapi/asm/fcntl.h | 1 + fs/btrfs/compression.c | 12 +- fs/btrfs/compression.h | 6 +- fs/btrfs/ctree.h | 9 +- fs/btrfs/delalloc-space.c | 18 +- fs/btrfs/file-item.c | 35 +- fs/btrfs/file.c | 46 +- fs/btrfs/inode.c | 936 ++++++++++++++++++++--- fs/btrfs/ordered-data.c | 80 +- fs/btrfs/ordered-data.h | 18 +- fs/btrfs/relocation.c | 4 +- fs/fcntl.c | 10 +- fs/namei.c | 4 + fs/read_write.c | 168 +++- include/linux/encoded_io.h | 17 + include/linux/fcntl.h | 2 +- include/linux/fs.h | 13 + include/linux/uio.h | 2 + include/uapi/asm-generic/fcntl.h | 4 + include/uapi/linux/encoded_io.h | 30 + include/uapi/linux/fs.h | 5 +- lib/iov_iter.c | 82 ++ 26 files changed, 1378 insertions(+), 201 deletions(-) create mode 100644 Documentation/filesystems/encoded_io.rst create mode 100644 include/linux/encoded_io.h create mode 100644 include/uapi/linux/encoded_io.h