[v3,0/3] common SVDM version and VDO from dt

Message

Kyle Tso Feb. 1, 2021, 1:34 p.m. UTC

patch v2:
https://lore.kernel.org/linux-devicetree/[e-mail]/

Changes since v2:
=================
usb: typec: Determine common SVDM Versions
- rename the variable and the functions (remove the text "common")
- remove the macro

dt-bindings: connector: Add SVDM VDO properties
- no change

usb: typec: tcpm: Get Sink VDO from fwnode
- use fwnode_property_count_u32 instead to get the count
- revise the error handling

Kyle Tso (3):
  usb: typec: Determine common SVDM Versions
  dt-bindings: connector: Add SVDM VDO properties
  usb: typec: tcpm: Get Sink VDO from fwnode

 .../bindings/connector/usb-connector.yaml     |  11 +
 drivers/usb/typec/altmodes/displayport.c      |   8 +-
 drivers/usb/typec/class.c                     |  21 +-
 drivers/usb/typec/tcpm/tcpm.c                 |  61 +++-
 drivers/usb/typec/ucsi/displayport.c          |  12 +-
 drivers/usb/typec/ucsi/ucsi.c                 |   2 +
 include/dt-bindings/usb/pd.h                  | 311 ++++++++++++++++-
 include/linux/usb/pd_vdo.h                    | 315 ++++++++++++++----
 include/linux/usb/typec.h                     |  10 +
 9 files changed, 661 insertions(+), 90 deletions(-)

Comments

Hans de Goede Feb. 1, 2021, 3:05 p.m. UTC | #1

Hi,

On 2/1/21 2:34 PM, Kyle Tso wrote:
> patch v2:
> https://lore.kernel.org/linux-devicetree/[e-mail]/
> 
> Changes since v2:
> =================
> usb: typec: Determine common SVDM Versions
> - rename the variable and the functions (remove the text "common")
> - remove the macro
> 
> dt-bindings: connector: Add SVDM VDO properties
> - no change
> 
> usb: typec: tcpm: Get Sink VDO from fwnode
> - use fwnode_property_count_u32 instead to get the count
> - revise the error handling
> 
> Kyle Tso (3):
>   usb: typec: Determine common SVDM Versions
>   dt-bindings: connector: Add SVDM VDO properties
>   usb: typec: tcpm: Get Sink VDO from fwnode

I wanted to point out that I have a somewhat related series "pending".

I put quotes around pending because it has been reviewed quite a while
ago and have not managed to make the time to post a new version since then.

My series is somewhat/mostly orthogonal, but I think it is good
to keep it in mind since it also is about specifying VDOs, but then
for alternate-modes, see:

https://lore.kernel.org/linux-usb/[e-mail]/

And I think there might be some overlap with the last patch in this series,
although that does not call typec_port_register_altmode(). 

Regards,

Hans




p.s.

I was actually planning on replying to an earlier version of
this series, *after* I posted a new version of my own series,
but I'm swamped so it looks like I will not get around to posting
a new version of my own series anytime soon.