mbox series

[0/2] Add mediatek MT6359 accdet driver

Message ID 1609935546-11722-1-git-send-email-argus.lin@mediatek.com (mailing list archive)
Headers show
Series Add mediatek MT6359 accdet driver | expand

Message

Argus Lin Jan. 6, 2021, 12:19 p.m. UTC
MT6359 audio codec support accessory detect features, the general features
are jack plug detection and key detection.

All of 3-pole and 4-pole jack are supported.

change since v1:
  - adds mt6359 accdet binding document
  - adds mt6359 accdet driver


Argus Lin (2):
  dt-bindings: mediatek: mt6359: add ASoC mt6359 accdet document
  ASoC: mediatek: mt6359: add MT6359 accdet driver

 .../devicetree/bindings/sound/mt6359-accdet.yaml   |  142 ++
 sound/soc/codecs/Kconfig                           |    7 +
 sound/soc/codecs/Makefile                          |    2 +
 sound/soc/codecs/mt6359-accdet.c                   | 1951 ++++++++++++++++++++
 sound/soc/codecs/mt6359-accdet.h                   |  136 ++
 sound/soc/codecs/mt6359.h                          | 1863 +++++++++++++++++--
 6 files changed, 3995 insertions(+), 106 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/mt6359-accdet.yaml
 create mode 100644 sound/soc/codecs/mt6359-accdet.c
 create mode 100644 sound/soc/codecs/mt6359-accdet.h

--
1.8.1.1.dirty

Comments

Argus Lin Feb. 3, 2021, 6:57 a.m. UTC | #1
Dear maintainers:
Can you reply to me if any opinion?
thanks

B.R.
Argus

On Wed, 2021-01-06 at 20:19 +0800, Argus Lin wrote:
> MT6359 audio codec support accessory detect features, the general features
> are jack plug detection and key detection.
> 
> All of 3-pole and 4-pole jack are supported.
> 
> change since v1:
>   - adds mt6359 accdet binding document
>   - adds mt6359 accdet driver
> 
> 
> Argus Lin (2):
>   dt-bindings: mediatek: mt6359: add ASoC mt6359 accdet document
>   ASoC: mediatek: mt6359: add MT6359 accdet driver
> 
>  .../devicetree/bindings/sound/mt6359-accdet.yaml   |  142 ++
>  sound/soc/codecs/Kconfig                           |    7 +
>  sound/soc/codecs/Makefile                          |    2 +
>  sound/soc/codecs/mt6359-accdet.c                   | 1951 ++++++++++++++++++++
>  sound/soc/codecs/mt6359-accdet.h                   |  136 ++
>  sound/soc/codecs/mt6359.h                          | 1863 +++++++++++++++++--
>  6 files changed, 3995 insertions(+), 106 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/mt6359-accdet.yaml
>  create mode 100644 sound/soc/codecs/mt6359-accdet.c
>  create mode 100644 sound/soc/codecs/mt6359-accdet.h
> 
> --
> 1.8.1.1.dirty
>
Mark Brown Feb. 3, 2021, 1:20 p.m. UTC | #2
On Wed, Feb 03, 2021 at 02:57:42PM +0800, Argus Lin wrote:
> Dear maintainers:
> Can you reply to me if any opinion?
> thanks

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

IIRC I did review this...