[net-next,v2,0/7] GTP

Message

Jonas Bonn Feb. 3, 2021, 7:07 a.m. UTC

There's ongoing work in this driver to provide support for IPv6, GRO,
GSO, and "collect metadata" mode operation.  In order to facilitate this
work going forward, this short series accumulates already ACK:ed patches
that are ready for the next merge window.

All of these patches should be uncontroversial at this point, including
the first one in the series that reverts a recently added change to
introduce "collect metadata" mode.  As that patch produces 'broken'
packets when common GTP headers are in place, it seems better to revert
it and rethink things a bit before inclusion.

Changes in v2:
- fix fallout from "one rebase too many"

/Jonas


Jonas Bonn (7):
  Revert "GTP: add support for flow based tunneling API"
  gtp: set initial MTU
  gtp: include role in link info
  gtp: really check namespaces before xmit
  gtp: drop unnecessary call to skb_dst_drop
  gtp: set device type
  gtp: update rx_length_errors for abnormally short packets

 drivers/net/gtp.c                  | 544 +++++++++--------------------
 include/uapi/linux/gtp.h           |  12 -
 include/uapi/linux/if_link.h       |   1 -
 include/uapi/linux/if_tunnel.h     |   1 -
 tools/include/uapi/linux/if_link.h |   1 -
 5 files changed, 160 insertions(+), 399 deletions(-)

Comments

Jakub Kicinski Feb. 3, 2021, 8:19 p.m. UTC | #1

On Wed,  3 Feb 2021 08:07:58 +0100 Jonas Bonn wrote:
> There's ongoing work in this driver to provide support for IPv6, GRO,
> GSO, and "collect metadata" mode operation.  In order to facilitate this
> work going forward, this short series accumulates already ACK:ed patches
> that are ready for the next merge window.
> 
> All of these patches should be uncontroversial at this point, including
> the first one in the series that reverts a recently added change to
> introduce "collect metadata" mode.  As that patch produces 'broken'
> packets when common GTP headers are in place, it seems better to revert
> it and rethink things a bit before inclusion.

Thanks, build cleanly now! Please make sure to CC the author of the
patch you're reverting or fixing.

Jakub Kicinski Feb. 4, 2021, 8:10 p.m. UTC | #2

On Wed,  3 Feb 2021 08:07:58 +0100 Jonas Bonn wrote:
> There's ongoing work in this driver to provide support for IPv6, GRO,
> GSO, and "collect metadata" mode operation.  In order to facilitate this
> work going forward, this short series accumulates already ACK:ed patches
> that are ready for the next merge window.
> 
> All of these patches should be uncontroversial at this point, including
> the first one in the series that reverts a recently added change to
> introduce "collect metadata" mode.  As that patch produces 'broken'
> packets when common GTP headers are in place, it seems better to revert
> it and rethink things a bit before inclusion.

Applied, thanks.