| Message ID | 20210204084343.207847-3-damien.lemoal@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: Remove skd driver | expand |
Given that #1 in this series is accepted,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On 2021/02/04 18:01, Johannes Thumshirn wrote: > Given that #1 in this series is accepted, > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> > Do you mean "if #1 in this series is accepted" ? I have not received patch #1... I wonder if it hit the list ? Did you get it ?
On 04/02/2021 10:03, Damien Le Moal wrote: > On 2021/02/04 18:01, Johannes Thumshirn wrote: >> Given that #1 in this series is accepted, >> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> >> > > Do you mean "if #1 in this series is accepted" ? > I have not received patch #1... I wonder if it hit the list ? Did you get it ? > Me neither, seems like vger is acting funny again
On 2021/02/04 18:14, Johannes Thumshirn wrote: > On 04/02/2021 10:03, Damien Le Moal wrote: >> On 2021/02/04 18:01, Johannes Thumshirn wrote: >>> Given that #1 in this series is accepted, >>> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> >>> >> >> Do you mean "if #1 in this series is accepted" ? >> I have not received patch #1... I wonder if it hit the list ? Did you get it ? >> > > Me neither, seems like vger is acting funny again Or Exchange is again acting up. It does not show up in lore... Resending. >
On 2021/02/04 18:14, Johannes Thumshirn wrote: > On 04/02/2021 10:03, Damien Le Moal wrote: >> On 2021/02/04 18:01, Johannes Thumshirn wrote: >>> Given that #1 in this series is accepted, >>> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> >>> >> >> Do you mean "if #1 in this series is accepted" ? >> I have not received patch #1... I wonder if it hit the list ? Did you get it ? >> > > Me neither, seems like vger is acting funny again Patch 1 is 111KB... Probably too big and it gets dropped by vger. I generated it with "git rm" and a few other changes (MAITAINERS, Kconfig and Makefile). Is it possible to shorten the "git rm" part so that it does not show every single line removed but just the files being deleted ? That driver is a single file, so very large.
On 04/02/2021 10:20, Damien Le Moal wrote: > On 2021/02/04 18:14, Johannes Thumshirn wrote: >> On 04/02/2021 10:03, Damien Le Moal wrote: >>> On 2021/02/04 18:01, Johannes Thumshirn wrote: >>>> Given that #1 in this series is accepted, >>>> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> >>>> >>> >>> Do you mean "if #1 in this series is accepted" ? >>> I have not received patch #1... I wonder if it hit the list ? Did you get it ? >>> >> >> Me neither, seems like vger is acting funny again > > Patch 1 is 111KB... Probably too big and it gets dropped by vger. > > I generated it with "git rm" and a few other changes (MAITAINERS, Kconfig and > Makefile). Is it possible to shorten the "git rm" part so that it does not show > every single line removed but just the files being deleted ? That driver is a > single file, so very large. > > Well that's bad, but how could you remove the driver then if vger doesn't like it?
On 2021/02/04 18:25, Johannes Thumshirn wrote: > On 04/02/2021 10:20, Damien Le Moal wrote: >> On 2021/02/04 18:14, Johannes Thumshirn wrote: >>> On 04/02/2021 10:03, Damien Le Moal wrote: >>>> On 2021/02/04 18:01, Johannes Thumshirn wrote: >>>>> Given that #1 in this series is accepted, >>>>> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> >>>>> >>>> >>>> Do you mean "if #1 in this series is accepted" ? >>>> I have not received patch #1... I wonder if it hit the list ? Did you get it ? >>>> >>> >>> Me neither, seems like vger is acting funny again >> >> Patch 1 is 111KB... Probably too big and it gets dropped by vger. >> >> I generated it with "git rm" and a few other changes (MAITAINERS, Kconfig and >> Makefile). Is it possible to shorten the "git rm" part so that it does not show >> every single line removed but just the files being deleted ? That driver is a >> single file, so very large. >> >> > > Well that's bad, but how could you remove the driver then if vger doesn't like it? No clue. Just hope Jens got the email. >
diff --git a/block/genhd.c b/block/genhd.c index 9e741a4f351b..419548e92d82 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -45,11 +45,10 @@ static void disk_release_events(struct gendisk *disk); void set_capacity(struct gendisk *disk, sector_t sectors) { struct block_device *bdev = disk->part0; - unsigned long flags; - spin_lock_irqsave(&bdev->bd_size_lock, flags); + spin_lock(&bdev->bd_size_lock); i_size_write(bdev->bd_inode, (loff_t)sectors << SECTOR_SHIFT); - spin_unlock_irqrestore(&bdev->bd_size_lock, flags); + spin_unlock(&bdev->bd_size_lock); } EXPORT_SYMBOL(set_capacity); diff --git a/block/partitions/core.c b/block/partitions/core.c index 081f1df9d10d..d0745555ba16 100644 --- a/block/partitions/core.c +++ b/block/partitions/core.c @@ -88,11 +88,9 @@ static int (*check_part[])(struct parsed_partitions *) = { static void bdev_set_nr_sectors(struct block_device *bdev, sector_t sectors) { - unsigned long flags; - - spin_lock_irqsave(&bdev->bd_size_lock, flags); + spin_lock(&bdev->bd_size_lock); i_size_write(bdev->bd_inode, (loff_t)sectors << SECTOR_SHIFT); - spin_unlock_irqrestore(&bdev->bd_size_lock, flags); + spin_unlock(&bdev->bd_size_lock); } static struct parsed_partitions *allocate_partitions(struct gendisk *hd)
With the removal of the skd driver, using IRQ safe locking of a bdev bd_size_lock spinlock to protect the bdev inode size is not necessary anymore as there is no other known driver using this lock under an IRQ disabled context (e.g. calling set_capacity() with IRQ disabled). Revert commit 0fe37724f8e7 ("block: fix bd_size_lock use") which introduced the IRQ safe change. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> --- block/genhd.c | 5 ++--- block/partitions/core.c | 6 ++---- 2 files changed, 4 insertions(+), 7 deletions(-)