| Message ID | 20210128111549.GA8174@zhaomy-pc (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: anx7625: enable DSI EOTP | expand |
Hi Xin, Thanks for the patch. On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote: > > Enable DSI EOTP feature for fixing some panel screen constance > shift issue. > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. I don't think I quite understand how removing the MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could you extrapolate on this in the commit message? > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 65cc059..e31eeb1b 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) > dsi->format = MIPI_DSI_FMT_RGB888; > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | > MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > - MIPI_DSI_MODE_EOT_PACKET | > MIPI_DSI_MODE_VIDEO_HSE; > > if (mipi_dsi_attach(dsi) < 0) { > -- > 2.7.4 >
On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote: > > Hi Xin, > > Thanks for the patch. > > On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote: > > > > Enable DSI EOTP feature for fixing some panel screen constance > > shift issue. > > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. > > I don't think I quite understand how removing the > MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could > you extrapolate on this in the commit message? That confused me as well, but it turns out that's how the flag is defined: ``` /* disable EoT packets in HS mode */ #define MIPI_DSI_MODE_EOT_PACKET BIT(9) ``` (https://elixir.bootlin.com/linux/latest/source/include/drm/drm_mipi_dsi.h#L129) I'm almost tempted to put together a mass patch to rename all of these flags... > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > --- > > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > index 65cc059..e31eeb1b 100644 > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) > > dsi->format = MIPI_DSI_FMT_RGB888; > > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | > > MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > > - MIPI_DSI_MODE_EOT_PACKET | > > MIPI_DSI_MODE_VIDEO_HSE; > > > > if (mipi_dsi_attach(dsi) < 0) { > > -- > > 2.7.4 > >
W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote: >> Hi Xin, >> >> Thanks for the patch. >> >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote: >>> Enable DSI EOTP feature for fixing some panel screen constance >>> shift issue. >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. >> I don't think I quite understand how removing the >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could >> you extrapolate on this in the commit message? > That confused me as well, but it turns out that's how the flag is defined: > ``` > /* disable EoT packets in HS mode */ > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > ``` > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129) > > I'm almost tempted to put together a mass patch to rename all of these flags... Yes that would be good, many of these flags were just copy pasted from some hw datasheet, without good analysis how to adapt them to the framework. Regards Andrzej > >>> Signed-off-by: Xin Ji <xji@analogixsemi.com> >>> --- >>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c >>> index 65cc059..e31eeb1b 100644 >>> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c >>> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c >>> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) >>> dsi->format = MIPI_DSI_FMT_RGB888; >>> dsi->mode_flags = MIPI_DSI_MODE_VIDEO | >>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE | >>> - MIPI_DSI_MODE_EOT_PACKET | >>> MIPI_DSI_MODE_VIDEO_HSE; >>> >>> if (mipi_dsi_attach(dsi) < 0) { >>> -- >>> 2.7.4 >>> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel >
On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote: > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote: > >> Hi Xin, > >> > >> Thanks for the patch. > >> > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote: > >>> Enable DSI EOTP feature for fixing some panel screen constance > >>> shift issue. > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. > >> I don't think I quite understand how removing the > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could > >> you extrapolate on this in the commit message? > > That confused me as well, but it turns out that's how the flag is defined: > > ``` > > /* disable EoT packets in HS mode */ > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > > ``` > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129) > > > > I'm almost tempted to put together a mass patch to rename all of these flags... > > > Yes that would be good, many of these flags were just copy pasted from > some hw datasheet, without good analysis how to adapt them to the framework. I'll look into it (but that shouldn't block this patch). > > > Regards > > Andrzej > > > > > >>> Signed-off-by: Xin Ji <xji@analogixsemi.com> > >>> --- > >>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> index 65cc059..e31eeb1b 100644 > >>> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) > >>> dsi->format = MIPI_DSI_FMT_RGB888; > >>> dsi->mode_flags = MIPI_DSI_MODE_VIDEO | > >>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > >>> - MIPI_DSI_MODE_EOT_PACKET | > >>> MIPI_DSI_MODE_VIDEO_HSE; > >>> > >>> if (mipi_dsi_attach(dsi) < 0) { > >>> -- > >>> 2.7.4 > >>> > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel > >
On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat <drinkcat@chromium.org> wrote: > > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote: > > > > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote: > > >> Hi Xin, > > >> > > >> Thanks for the patch. > > >> > > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote: > > >>> Enable DSI EOTP feature for fixing some panel screen constance > > >>> shift issue. > > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. Does "constance shift" have a typo? Should it be "constant shift"? With that sorted out feel free to add my r-b. Reviewed-by: Robert Foss <robert.foss@linaro.org> > > >> I don't think I quite understand how removing the > > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could > > >> you extrapolate on this in the commit message? > > > That confused me as well, but it turns out that's how the flag is defined: > > > ``` > > > /* disable EoT packets in HS mode */ > > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > > > ``` > > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129) > > > > > > I'm almost tempted to put together a mass patch to rename all of these flags... > > > > > > Yes that would be good, many of these flags were just copy pasted from > > some hw datasheet, without good analysis how to adapt them to the framework. > > I'll look into it (but that shouldn't block this patch). Thanks for clearing this up Nicolas & Andrzej!
On Fri, Feb 05, 2021 at 10:43:14AM +0100, Robert Foss wrote: > On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat <drinkcat@chromium.org> wrote: > > > > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote: > > > > > > > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote: > > > >> Hi Xin, > > > >> > > > >> Thanks for the patch. > > > >> > > > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote: > > > >>> Enable DSI EOTP feature for fixing some panel screen constance > > > >>> shift issue. > > > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. > > Does "constance shift" have a typo? Should it be "constant shift"? > > With that sorted out feel free to add my r-b. > Reviewed-by: Robert Foss <robert.foss@linaro.org> Hi Robert Foss, thanks, I'll correct it. Thanks, Xin > > > > >> I don't think I quite understand how removing the > > > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could > > > >> you extrapolate on this in the commit message? > > > > That confused me as well, but it turns out that's how the flag is defined: > > > > ``` > > > > /* disable EoT packets in HS mode */ > > > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > > > > ``` > > > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129) > > > > > > > > I'm almost tempted to put together a mass patch to rename all of these flags... > > > > > > > > > Yes that would be good, many of these flags were just copy pasted from > > > some hw datasheet, without good analysis how to adapt them to the framework. > > > > I'll look into it (but that shouldn't block this patch). > > Thanks for clearing this up Nicolas & Andrzej!
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 65cc059..e31eeb1b 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) dsi->format = MIPI_DSI_FMT_RGB888; dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | - MIPI_DSI_MODE_EOT_PACKET | MIPI_DSI_MODE_VIDEO_HSE; if (mipi_dsi_attach(dsi) < 0) {
Enable DSI EOTP feature for fixing some panel screen constance shift issue. Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. Signed-off-by: Xin Ji <xji@analogixsemi.com> --- drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - 1 file changed, 1 deletion(-)