| Message ID | 20210203233539.1990032-2-dje@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/3] slirp: Placeholder for libslirp ipv6 hostfwd support | expand |
On 2/3/21 5:35 PM, dje--- via wrote: > This commit is intended to only contain the slirp submodule change > that adds ipv6 hostfwd support. Missing your signed-off-by, and as written, your authorship would be based on the From: dje--- via <qemu-devel@nongnu.org> header (that looks like our mailing list rewrote things due to SPF policies, but that it botched your name in the process), rather than your Reply-to: Doug Evans <dje@google.com> header. To fix the latter, you can convince git to include a From: line in the first line of the body that will override whatever is in the headers even after mailing list rewrites. > --- > slirp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/slirp b/slirp > index 8f43a99191..358c0827d4 160000 > --- a/slirp > +++ b/slirp > @@ -1 +1 @@ > -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece > +Subproject commit 358c0827d49778f016312bfb4167fe639900681f >
On Thu, Feb 4, 2021 at 8:02 AM Eric Blake <eblake@redhat.com> wrote: > On 2/3/21 5:35 PM, dje--- via wrote: > > This commit is intended to only contain the slirp submodule change > > that adds ipv6 hostfwd support. > > > Missing your signed-off-by, and as written, your authorship would be > based on the From: dje--- via <qemu-devel@nongnu.org> header (that looks > like our mailing list rewrote things due to SPF policies, but that it > botched your name in the process), rather than your Reply-to: Doug Evans > <dje@google.com> header. To fix the latter, you can convince git to > include a From: line in the first line of the body that will override > whatever is in the headers even after mailing list rewrites. > > > --- > > slirp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/slirp b/slirp > > index 8f43a99191..358c0827d4 160000 > > --- a/slirp > > +++ b/slirp > > @@ -1 +1 @@ > > -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece > > +Subproject commit 358c0827d49778f016312bfb4167fe639900681f > > Samuel, how do merges from the libslirp tree into the qemu tree work? I wasn't expecting there was anything more I would do, but please correct me if I'm wrong. Therefore, what this patch (1/3) is is just a placeholder to solve the problem of removing the "subproject comment" out of the other patches. The signed-off-by line is intentionally missing.
Hi, On Thu, Feb 4, 2021 at 3:38 AM dje--- via <qemu-devel@nongnu.org> wrote: > > This commit is intended to only contain the slirp submodule change > that adds ipv6 hostfwd support. > --- > slirp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > It's generally recommended to include the shortlog of some sort in the commit message of what changed between the two commits, ex: https://patchew.org/QEMU/20210125073427.3970606-1-marcandre.lureau@redhat.com/20210125073427.3970606-2-marcandre.lureau@redhat.com/ thanks > diff --git a/slirp b/slirp > index 8f43a99191..358c0827d4 160000 > --- a/slirp > +++ b/slirp > @@ -1 +1 @@ > -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece > +Subproject commit 358c0827d49778f016312bfb4167fe639900681f > -- > 2.30.0.365.g02bc693789-goog > >
diff --git a/slirp b/slirp index 8f43a99191..358c0827d4 160000 --- a/slirp +++ b/slirp @@ -1 +1 @@ -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece +Subproject commit 358c0827d49778f016312bfb4167fe639900681f