| Message ID | cc7cc15f87e209c9963f19129f51398cdc374358.1611106162.git.Thinh.Nguyen@synopsys.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | de4d9ea789530ac0ce3409878422e9389c3a7cd3 |
| Headers | show |
| Series | usb: Support USB 3.2 multi-lanes | expand |
Hi Rob, Thinh Nguyen wrote: > According to the USB 3.2 spec, a SuperSpeed Plus device can operate at > gen2x2, gen2x1, or gen1x2. If the USB controller device supports > multiple lanes at different transfer rates, the user can specify the HW > capability via these new speed strings: > > "super-speed-plus-gen2x2" > "super-speed-plus-gen2x1" > "super-speed-plus-gen1x2" > > If the argument is simply "super-speed-plus", USB controllers should > default to their maximum transfer rate and number of lanes. > > Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> > --- > Changes in v7: > - Rebase on Greg's usb-testing branch > Changes in v6: > - Update the different maximum_speed enums to the usb.yaml > - Remove Reviewed-by: Rob Herring <robh@kernel.org> because the commit is updated > - Rebase on Greg's usb-testing branch > - Update commit message > Changes in v5: > - Add Reviewed-by: Rob Herring <robh@kernel.org> > - Rebase on Felipe's testing/next branch > - Changed Signed-off-by email to match From: email header > Changes in v4: > - None > Changes in v3: > - Use "maximum-speed" to include both the num-lane and transfer rate for SSP > - Remove "num-lanes" and "lane-speed-mantissa-gbps" properties > Changes in v2: > - Make "num-lanes" and "lane-speed-mantissa-gbps" common USB properties > > Documentation/devicetree/bindings/usb/usb.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/usb.yaml b/Documentation/devicetree/bindings/usb/usb.yaml > index ebe7f4275c59..78491e66ed24 100644 > --- a/Documentation/devicetree/bindings/usb/usb.yaml > +++ b/Documentation/devicetree/bindings/usb/usb.yaml > @@ -54,6 +54,9 @@ properties: > - high-speed > - super-speed > - super-speed-plus > + - super-speed-plus-gen2x1 > + - super-speed-plus-gen1x2 > + - super-speed-plus-gen2x2 > > additionalProperties: true > Can I have your Reviewed-by again? Had to drop it previously because the change needed to be rebased and added to the yaml file instead. Thanks, Thinh
On Tue, 19 Jan 2021 17:36:08 -0800, Thinh Nguyen wrote: > According to the USB 3.2 spec, a SuperSpeed Plus device can operate at > gen2x2, gen2x1, or gen1x2. If the USB controller device supports > multiple lanes at different transfer rates, the user can specify the HW > capability via these new speed strings: > > "super-speed-plus-gen2x2" > "super-speed-plus-gen2x1" > "super-speed-plus-gen1x2" > > If the argument is simply "super-speed-plus", USB controllers should > default to their maximum transfer rate and number of lanes. > > Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> > --- > Changes in v7: > - Rebase on Greg's usb-testing branch > Changes in v6: > - Update the different maximum_speed enums to the usb.yaml > - Remove Reviewed-by: Rob Herring <robh@kernel.org> because the commit is updated > - Rebase on Greg's usb-testing branch > - Update commit message > Changes in v5: > - Add Reviewed-by: Rob Herring <robh@kernel.org> > - Rebase on Felipe's testing/next branch > - Changed Signed-off-by email to match From: email header > Changes in v4: > - None > Changes in v3: > - Use "maximum-speed" to include both the num-lane and transfer rate for SSP > - Remove "num-lanes" and "lane-speed-mantissa-gbps" properties > Changes in v2: > - Make "num-lanes" and "lane-speed-mantissa-gbps" common USB properties > > Documentation/devicetree/bindings/usb/usb.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
Rob Herring wrote: > On Tue, 19 Jan 2021 17:36:08 -0800, Thinh Nguyen wrote: >> According to the USB 3.2 spec, a SuperSpeed Plus device can operate at >> gen2x2, gen2x1, or gen1x2. If the USB controller device supports >> multiple lanes at different transfer rates, the user can specify the HW >> capability via these new speed strings: >> >> "super-speed-plus-gen2x2" >> "super-speed-plus-gen2x1" >> "super-speed-plus-gen1x2" >> >> If the argument is simply "super-speed-plus", USB controllers should >> default to their maximum transfer rate and number of lanes. >> >> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> >> --- >> Changes in v7: >> - Rebase on Greg's usb-testing branch >> Changes in v6: >> - Update the different maximum_speed enums to the usb.yaml >> - Remove Reviewed-by: Rob Herring <robh@kernel.org> because the commit is updated >> - Rebase on Greg's usb-testing branch >> - Update commit message >> Changes in v5: >> - Add Reviewed-by: Rob Herring <robh@kernel.org> >> - Rebase on Felipe's testing/next branch >> - Changed Signed-off-by email to match From: email header >> Changes in v4: >> - None >> Changes in v3: >> - Use "maximum-speed" to include both the num-lane and transfer rate for SSP >> - Remove "num-lanes" and "lane-speed-mantissa-gbps" properties >> Changes in v2: >> - Make "num-lanes" and "lane-speed-mantissa-gbps" common USB properties >> >> Documentation/devicetree/bindings/usb/usb.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> > Reviewed-by: Rob Herring <robh@kernel.org> Thanks! Thinh
diff --git a/Documentation/devicetree/bindings/usb/usb.yaml b/Documentation/devicetree/bindings/usb/usb.yaml index ebe7f4275c59..78491e66ed24 100644 --- a/Documentation/devicetree/bindings/usb/usb.yaml +++ b/Documentation/devicetree/bindings/usb/usb.yaml @@ -54,6 +54,9 @@ properties: - high-speed - super-speed - super-speed-plus + - super-speed-plus-gen2x1 + - super-speed-plus-gen1x2 + - super-speed-plus-gen2x2 additionalProperties: true
According to the USB 3.2 spec, a SuperSpeed Plus device can operate at gen2x2, gen2x1, or gen1x2. If the USB controller device supports multiple lanes at different transfer rates, the user can specify the HW capability via these new speed strings: "super-speed-plus-gen2x2" "super-speed-plus-gen2x1" "super-speed-plus-gen1x2" If the argument is simply "super-speed-plus", USB controllers should default to their maximum transfer rate and number of lanes. Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> --- Changes in v7: - Rebase on Greg's usb-testing branch Changes in v6: - Update the different maximum_speed enums to the usb.yaml - Remove Reviewed-by: Rob Herring <robh@kernel.org> because the commit is updated - Rebase on Greg's usb-testing branch - Update commit message Changes in v5: - Add Reviewed-by: Rob Herring <robh@kernel.org> - Rebase on Felipe's testing/next branch - Changed Signed-off-by email to match From: email header Changes in v4: - None Changes in v3: - Use "maximum-speed" to include both the num-lane and transfer rate for SSP - Remove "num-lanes" and "lane-speed-mantissa-gbps" properties Changes in v2: - Make "num-lanes" and "lane-speed-mantissa-gbps" common USB properties Documentation/devicetree/bindings/usb/usb.yaml | 3 +++ 1 file changed, 3 insertions(+)