| Message ID | 20210204010655.15619-1-elder@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1d23a56b0296d29e7047b41fe0a42a001036160d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2] net: ipa: set error code in gsi_channel_setup() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 3 Feb 2021 19:06:55 -0600 you wrote: > In gsi_channel_setup(), we check to see if the configuration data > contains any information about channels that are not supported by > the hardware. If one is found, we abort the setup process, but > the error code (ret) is not set in this case. Fix this bug. > > Fixes: 650d1603825d8 ("soc: qcom: ipa: the generic software interface") > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Alex Elder <elder@linaro.org> > > [...] Here is the summary with links: - [net,v2] net: ipa: set error code in gsi_channel_setup() https://git.kernel.org/netdev/net/c/1d23a56b0296 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 34e5f2155d620..b77f5fef7aeca 100644 --- a/drivers/net/ipa/gsi.c +++ b/drivers/net/ipa/gsi.c @@ -1710,6 +1710,7 @@ static int gsi_channel_setup(struct gsi *gsi) if (!channel->gsi) continue; /* Ignore uninitialized channels */ + ret = -EINVAL; dev_err(gsi->dev, "channel %u not supported by hardware\n", channel_id - 1); channel_id = gsi->channel_count;
In gsi_channel_setup(), we check to see if the configuration data contains any information about channels that are not supported by the hardware. If one is found, we abort the setup process, but the error code (ret) is not set in this case. Fix this bug. Fixes: 650d1603825d8 ("soc: qcom: ipa: the generic software interface") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Alex Elder <elder@linaro.org> --- v2: Added "Fixes" tag. drivers/net/ipa/gsi.c | 1 + 1 file changed, 1 insertion(+)