diff mbox series

scsi: ufs: print the counter of each event history

Message ID 20210203101443.28934-1-dh0421.hwang@samsung.com (mailing list archive)
State Accepted
Headers show
Series scsi: ufs: print the counter of each event history | expand

Commit Message

Since only print the recorded event history list,
add to print the counter value.

Signed-off-by: DooHyun Hwang <dh0421.hwang@samsung.com>
---
 drivers/scsi/ufs/ufshcd.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Avri Altman Feb. 5, 2021, 8:17 a.m. UTC | #1
> 
> 
> Since only print the recorded event history list,
> add to print the counter value.
> 
> Signed-off-by: DooHyun Hwang <dh0421.hwang@samsung.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

Btw, You have the counter now in ufs-debugfs as well.

Thanks,
Avri
>>
>> Since only print the recorded event history list, add to print the
>> counter value.
>>
>> Signed-off-by: DooHyun Hwang <dh0421.hwang@samsung.com>
>Reviewed-by: Avri Altman <avri.altman@wdc.com>
>
>Btw, You have the counter now in ufs-debugfs as well.
>
>Thanks,
>Avri

Thank you for your review and information.

I hope to be able to check the counter value in kernel log as well.

Thank you.
DooHyun Hwang.
Martin K. Petersen Feb. 9, 2021, 3:16 a.m. UTC | #3
DooHyun,

> Since only print the recorded event history list, add to print the
> counter value.

Applied to 5.12/scsi-staging, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 721f55db181f..1ea920aeb701 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -451,6 +451,8 @@  static void ufshcd_print_evt(struct ufs_hba *hba, u32 id,
 
 	if (!found)
 		dev_err(hba->dev, "No record of %s\n", err_name);
+	else
+		dev_err(hba->dev, "%s: total cnt=%llu\n", err_name, e->cnt);
 }
 
 static void ufshcd_print_evt_hist(struct ufs_hba *hba)