| Message ID | 20210207154623.433442-17-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging:iio:cdc:ad7150: cleanup / fixup / graduate | expand |
> -----Original Message----- > From: Jonathan Cameron [mailto:jic23@kernel.org] > Sent: Monday, February 8, 2021 4:46 AM > To: linux-iio@vger.kernel.org > Cc: Lars-Peter Clausen <lars@metafoo.de>; Michael Hennerich > <Michael.Hennerich@analog.com>; Song Bao Hua (Barry Song) > <song.bao.hua@hisilicon.com>; robh+dt@kernel.org; Jonathan Cameron > <jonathan.cameron@huawei.com> > Subject: [PATCH 16/24] staging:iio:cdc:ad7150: Drop unnecessary block > comments. > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > These have a habit of not getting updated with driver reorganizations > and don't add much info so drop them. > > Also fix a minor comment syntax issue. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- Reviewed-by: Barry Song <song.bao.hua@hisilicon.com> > drivers/staging/iio/cdc/ad7150.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/staging/iio/cdc/ad7150.c > b/drivers/staging/iio/cdc/ad7150.c > index d530b467d1b2..4c83e6e37c5a 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -17,9 +17,6 @@ > #include <linux/iio/iio.h> > #include <linux/iio/sysfs.h> > #include <linux/iio/events.h> > -/* > - * AD7150 registers definition > - */ > > #define AD7150_STATUS_REG 0 > #define AD7150_STATUS_OUT1 BIT(3) > @@ -89,10 +86,6 @@ struct ad7150_chip_info { > enum iio_event_direction dir; > }; > > -/* > - * sysfs nodes > - */ > - > static const u8 ad7150_addresses[][6] = { > { AD7150_CH1_DATA_HIGH_REG, AD7150_CH1_AVG_HIGH_REG, > AD7150_CH1_SETUP_REG, AD7150_CH1_THR_HOLD_H_REG, > @@ -172,8 +165,7 @@ static int ad7150_read_event_config(struct iio_dev > *indio_dev, > return -EINVAL; > } > > -/* state_lock should be held to ensure consistent state*/ > - > +/* state_lock should be held to ensure consistent state */ > static int ad7150_write_event_params(struct iio_dev *indio_dev, > unsigned int chan, > enum iio_event_type type, > -- > 2.30.0
diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c index d530b467d1b2..4c83e6e37c5a 100644 --- a/drivers/staging/iio/cdc/ad7150.c +++ b/drivers/staging/iio/cdc/ad7150.c @@ -17,9 +17,6 @@ #include <linux/iio/iio.h> #include <linux/iio/sysfs.h> #include <linux/iio/events.h> -/* - * AD7150 registers definition - */ #define AD7150_STATUS_REG 0 #define AD7150_STATUS_OUT1 BIT(3) @@ -89,10 +86,6 @@ struct ad7150_chip_info { enum iio_event_direction dir; }; -/* - * sysfs nodes - */ - static const u8 ad7150_addresses[][6] = { { AD7150_CH1_DATA_HIGH_REG, AD7150_CH1_AVG_HIGH_REG, AD7150_CH1_SETUP_REG, AD7150_CH1_THR_HOLD_H_REG, @@ -172,8 +165,7 @@ static int ad7150_read_event_config(struct iio_dev *indio_dev, return -EINVAL; } -/* state_lock should be held to ensure consistent state*/ - +/* state_lock should be held to ensure consistent state */ static int ad7150_write_event_params(struct iio_dev *indio_dev, unsigned int chan, enum iio_event_type type,