| Message ID | 20210209173254.17712-1-shubhunic@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Modernizing the t7001 test script | expand |
On Tue, Feb 9, 2021 at 12:35 PM shubham verma <shubhunic@gmail.com> wrote: > In this patch series modernize the t7001 test script by changing the > style of its tests from an old one to the modern one and by cleaning > up the test script. > > Changes since v1: > > - Change commit messages and added brief explanation about commit. > - Modernize subshell formatting > - Use ': >' rather than '>' For readers new to this series, v1 is here: https://lore.kernel.org/git/20200925170256.11490-1-shubhunic@gmail.com/T/
shubham verma <shubhunic@gmail.com> writes: > In this patch series modernize the t7001 test script by changing the > style of its tests from an old one to the modern one and by cleaning > up the test script. > > Changes since v1: > > - Change commit messages and added brief explanation about commit. > - Modernize subshell formatting > - Use ': >' rather than '>' > > Thanks everyone for your feedback and suggestions. > > shubham verma (10): > t7001: modernize test formatting > t7001: indent with TABs instead of spaces > t7001: remove unnecessary blank lines > t7001: modernize subshell formatting > t7001: remove whitespace after redirect operators > t7001: avoid using `cd` outside of subshells > t7001: use '>' rather than 'touch' > t7001: put each command on a separate line > t7001: use here-docs instead of echo > t7001: use `test` rather than `[` > > t/t7001-mv.sh | 432 ++++++++++++++++++++++++-------------------------- > 1 file changed, 204 insertions(+), 228 deletions(-) I would have used test_write_lines instead of here-doc in 9/10, but that is such a minor preference thing that it is not worth going back and replace. Nothing else stood out during my cursory scan. Will queue; thanks.
On Tue, Feb 9, 2021 at 6:13 PM Junio C Hamano <gitster@pobox.com> wrote: > shubham verma <shubhunic@gmail.com> writes: > > In this patch series modernize the t7001 test script by changing the > > style of its tests from an old one to the modern one and by cleaning > > up the test script. > > > I would have used test_write_lines instead of here-doc in 9/10, but > that is such a minor preference thing that it is not worth going > back and replace. Nothing else stood out during my cursory scan. I read over the entire series and likewise didn't find anything to comment on, thus consider it in good shape. For what it's worth, consider this series: Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Eric Sunshine <sunshine@sunshineco.com> writes: > On Tue, Feb 9, 2021 at 6:13 PM Junio C Hamano <gitster@pobox.com> wrote: >> shubham verma <shubhunic@gmail.com> writes: >> > In this patch series modernize the t7001 test script by changing the >> > style of its tests from an old one to the modern one and by cleaning >> > up the test script. >> > >> I would have used test_write_lines instead of here-doc in 9/10, but >> that is such a minor preference thing that it is not worth going >> back and replace. Nothing else stood out during my cursory scan. > > I read over the entire series and likewise didn't find anything to > comment on, thus consider it in good shape. For what it's worth, > consider this series: > > Reviewed-by: Eric Sunshine <sunshine@sunshineco.com> Yup, this one looked good to me. Thanks. Except that the author's name were spelled in all lowercase, unlike v1, which made me wonder if it was intentional, that is.
Thank You Eric and Junio. Sorry I forget about spelling. Okay I will correct it and send a new patch series today. Thank You! On Thu, Feb 11, 2021 at 1:07 PM Junio C Hamano <gitster@pobox.com> wrote: > > Eric Sunshine <sunshine@sunshineco.com> writes: > > > On Tue, Feb 9, 2021 at 6:13 PM Junio C Hamano <gitster@pobox.com> wrote: > >> shubham verma <shubhunic@gmail.com> writes: > >> > In this patch series modernize the t7001 test script by changing the > >> > style of its tests from an old one to the modern one and by cleaning > >> > up the test script. > >> > > >> I would have used test_write_lines instead of here-doc in 9/10, but > >> that is such a minor preference thing that it is not worth going > >> back and replace. Nothing else stood out during my cursory scan. > > > > I read over the entire series and likewise didn't find anything to > > comment on, thus consider it in good shape. For what it's worth, > > consider this series: > > > > Reviewed-by: Eric Sunshine <sunshine@sunshineco.com> > > Yup, this one looked good to me. Thanks. > > Except that the author's name were spelled in all lowercase, unlike > v1, which made me wonder if it was intentional, that is.
On Thu, Feb 11, 2021 at 2:56 AM Shubham Verma <shubhunic@gmail.com> wrote: > Sorry I forget about spelling. > Okay I will correct it and send a new patch series today. Please remember that the spelling of the author (From:) and Signed-off-by: should be the same.