| Message ID | 1612868899-9185-3-git-send-email-yangyicong@hisilicon.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Use subdir-ccflags-* to inherit debug flag | expand |
On Tue, Feb 09, 2021 at 07:08:17PM +0800, Yicong Yang wrote: > From: Junhao He <hejunhao2@hisilicon.com> > > We use ccflags-$(CONFIG_HWMON_DEBUG_CHIP) for the debug > message in drivers/hwmon, but the DEBUG flag will not pass to > the subdirectory. > > Considering CONFIG_HWMON_DEBUG_CHIP intends to have DEBUG > recursively in driver/hwmon. It will be clearer > to use subdir-ccflags-* instead of ccflags-* to inherit > the debug settings from Kconfig when traversing subdirectories, > and it will avoid omittance of DEBUG define when debug messages > added in the subdirectories. > The above paragraph doesn't add clarity and may as well be dropped. On the other side, the commit message still doesn't mention that pr_debug depends on DEBUG, which I am sure many people don't know or remember. This is the prime reason why this patch is acceptable, so it most definitely needs to be mentioned here. Guenter > Suggested-by: Bjorn Helgaas <bhelgaas@google.com> > Signed-off-by: Junhao He <hejunhao2@hisilicon.com> > Signed-off-by: Yicong Yang <yangyicong@hisilicon.com> > --- > drivers/hwmon/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile > index 09a86c5..1c0c089 100644 > --- a/drivers/hwmon/Makefile > +++ b/drivers/hwmon/Makefile > @@ -201,5 +201,5 @@ obj-$(CONFIG_SENSORS_XGENE) += xgene-hwmon.o > obj-$(CONFIG_SENSORS_OCC) += occ/ > obj-$(CONFIG_PMBUS) += pmbus/ > > -ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG > +subdir-ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG > > -- > 2.8.1 >
On 2021/2/9 23:06, Guenter Roeck wrote: > On Tue, Feb 09, 2021 at 07:08:17PM +0800, Yicong Yang wrote: >> From: Junhao He <hejunhao2@hisilicon.com> >> >> We use ccflags-$(CONFIG_HWMON_DEBUG_CHIP) for the debug >> message in drivers/hwmon, but the DEBUG flag will not pass to >> the subdirectory. >> >> Considering CONFIG_HWMON_DEBUG_CHIP intends to have DEBUG >> recursively in driver/hwmon. It will be clearer >> to use subdir-ccflags-* instead of ccflags-* to inherit >> the debug settings from Kconfig when traversing subdirectories, >> and it will avoid omittance of DEBUG define when debug messages >> added in the subdirectories. >> > > The above paragraph doesn't add clarity and may as well be dropped. > On the other side, the commit message still doesn't mention that > pr_debug depends on DEBUG, which I am sure many people don't know > or remember. This is the prime reason why this patch is acceptable, > so it most definitely needs to be mentioned here. sorry, i didn't realize that you mean this. will impove this in the next version after the lunar new year holiday over. Thanks, Yicong > > Guenter > >> Suggested-by: Bjorn Helgaas <bhelgaas@google.com> >> Signed-off-by: Junhao He <hejunhao2@hisilicon.com> >> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com> >> --- >> drivers/hwmon/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile >> index 09a86c5..1c0c089 100644 >> --- a/drivers/hwmon/Makefile >> +++ b/drivers/hwmon/Makefile >> @@ -201,5 +201,5 @@ obj-$(CONFIG_SENSORS_XGENE) += xgene-hwmon.o >> obj-$(CONFIG_SENSORS_OCC) += occ/ >> obj-$(CONFIG_PMBUS) += pmbus/ >> >> -ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG >> +subdir-ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG >> >> -- >> 2.8.1 >> > > . >
diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile index 09a86c5..1c0c089 100644 --- a/drivers/hwmon/Makefile +++ b/drivers/hwmon/Makefile @@ -201,5 +201,5 @@ obj-$(CONFIG_SENSORS_XGENE) += xgene-hwmon.o obj-$(CONFIG_SENSORS_OCC) += occ/ obj-$(CONFIG_PMBUS) += pmbus/ -ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG +subdir-ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG