| Message ID | 20210210135657.35284-1-colyli@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] bcache: correct return value in register_nvdimm_meta() | expand |
On 2/10/21 06:00, Coly Li wrote: > 'ret' should be used a return value, thi patch fixes this error. How about following commit log ? The local variable should be used to return right error code from the register_nvdimm_meta() instead of size variable. > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Coly Li <colyli@suse.de> > --- Looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index c273eeef0d38..47a1225b3496 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -2554,7 +2554,7 @@ static ssize_t register_nvdimm_meta(struct kobject *k, struct kobj_attribute *at ret = -EINVAL; } - return size; + return ret; } #endif
'ret' should be used a return value, thi patch fixes this error. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Coly Li <colyli@suse.de> --- drivers/md/bcache/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)