Message ID | 20210210152859.25920-1-cfontana@suse.de (mailing list archive) |
---|---|
Headers | show |
Series | i386 cleanup PART 2 | expand |
Patchew URL: https://patchew.org/QEMU/20210210152859.25920-1-cfontana@suse.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210210152859.25920-1-cfontana@suse.de Subject: [RFC v17 00/14] i386 cleanup PART 2 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210209145759.141231-1-pbonzini@redhat.com -> patchew/20210209145759.141231-1-pbonzini@redhat.com * [new tag] patchew/20210209152759.209074-1-eblake@redhat.com -> patchew/20210209152759.209074-1-eblake@redhat.com Switched to a new branch 'test' c91731f i386: split seg_helper into user-only and softmmu parts a2644bc i386: slit svm_helper into softmmu and stub-only user 8f91c0e i386: separate fpu_helper into user and softmmu parts 39b0a04 i386: split misc helper into user and softmmu parts 5d7577d i386: split tcg btp_helper into softmmu and user parts f29d08d i386: split tcg excp_helper into softmmu and user parts f14e683 i386: split smm helper (softmmu) bb48373 i386: split user and softmmu functionality in tcg-cpu 377bd18 meson: add target_user_arch 20df6eb accel-cpu: make cpu_realizefn return a bool 86debc1 target/i386: fix host_cpu_adjust_phys_bits error handling 9c87298 accel: introduce new accessor functions 51e15cd cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn 82f1b7a i386: split cpu accelerators from cpu.c, using AccelCPUClass === OUTPUT BEGIN === 1/14 Checking commit 82f1b7a7a581 (i386: split cpu accelerators from cpu.c, using AccelCPUClass) WARNING: line over 80 characters #1335: FILE: target/i386/tcg/tcg-cpu.c:125: + memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 0); total: 0 errors, 1 warnings, 1256 lines checked Patch 1/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/14 Checking commit 51e15cdce754 (cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn) 3/14 Checking commit 9c87298a0ddb (accel: introduce new accessor functions) 4/14 Checking commit 86debc1ee9d8 (target/i386: fix host_cpu_adjust_phys_bits error handling) 5/14 Checking commit 20df6ebafe51 (accel-cpu: make cpu_realizefn return a bool) 6/14 Checking commit 377bd18d4811 (meson: add target_user_arch) 7/14 Checking commit bb4837361770 (i386: split user and softmmu functionality in tcg-cpu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #49: new file mode 100644 WARNING: line over 80 characters #134: FILE: target/i386/tcg/softmmu/tcg-cpu-softmmu.c:72: + memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 0); total: 0 errors, 2 warnings, 242 lines checked Patch 7/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/14 Checking commit f14e68300687 (i386: split smm helper (softmmu)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: target/i386/tcg/{ => softmmu}/smm_helper.c | 18 ++--------------- total: 0 errors, 1 warnings, 79 lines checked Patch 8/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/14 Checking commit f29d08d992aa (i386: split tcg excp_helper into softmmu and user parts) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #598: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #740: FILE: target/i386/tcg/softmmu/excp_helper_softmmu.c:138: + /* Bits 20-13 provide bits 39-32 of the address, bit 21 is reserved. WARNING: Block comments use a leading /* on a separate line #814: FILE: target/i386/tcg/softmmu/excp_helper_softmmu.c:212: +/* return value: WARNING: line over 80 characters #915: FILE: target/i386/tcg/softmmu/excp_helper_softmmu.c:313: + pdpe_addr = ((pml4e & PG_ADDRESS_MASK) + (((addr >> 30) & 0x1ff) << 3)) & WARNING: Block comments use a leading /* on a separate line #1009: FILE: target/i386/tcg/softmmu/excp_helper_softmmu.c:407: + /* Bits 20-13 provide bits 39-32 of the address, bit 21 is reserved. WARNING: Block comments use a leading /* on a separate line #1104: FILE: target/i386/tcg/softmmu/excp_helper_softmmu.c:502: + /* only set write access if already dirty... otherwise wait WARNING: Block comments use * on subsequent lines #1105: FILE: target/i386/tcg/softmmu/excp_helper_softmmu.c:503: + /* only set write access if already dirty... otherwise wait + for dirty access */ WARNING: Block comments use a trailing */ on a separate line #1105: FILE: target/i386/tcg/softmmu/excp_helper_softmmu.c:503: + for dirty access */ WARNING: Block comments use a leading /* on a separate line #1118: FILE: target/i386/tcg/softmmu/excp_helper_softmmu.c:516: + /* Even if 4MB pages, we map only one 4KB page in the cache to WARNING: Block comments use * on subsequent lines #1119: FILE: target/i386/tcg/softmmu/excp_helper_softmmu.c:517: + /* Even if 4MB pages, we map only one 4KB page in the cache to + avoid filling it too fast */ WARNING: Block comments use a trailing */ on a separate line #1119: FILE: target/i386/tcg/softmmu/excp_helper_softmmu.c:517: + avoid filling it too fast */ ERROR: braces {} are necessary for all arms of this statement #1133: FILE: target/i386/tcg/softmmu/excp_helper_softmmu.c:531: + if (is_user) [...] total: 1 errors, 11 warnings, 621 lines checked Patch 9/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/14 Checking commit 5d7577d4d1bb (i386: split tcg btp_helper into softmmu and user parts) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #328: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #464: FILE: target/i386/tcg/softmmu/bpt_helper_softmmu.c:132: + /* If nothing is changing except the global/local enable bits, WARNING: Block comments use * on subsequent lines #465: FILE: target/i386/tcg/softmmu/bpt_helper_softmmu.c:133: + /* If nothing is changing except the global/local enable bits, + then we can make the change more efficient. */ WARNING: Block comments use a trailing */ on a separate line #465: FILE: target/i386/tcg/softmmu/bpt_helper_softmmu.c:133: + then we can make the change more efficient. */ WARNING: Block comments use a leading /* on a separate line #467: FILE: target/i386/tcg/softmmu/bpt_helper_softmmu.c:135: + /* Fold the global and local enable bits together into the WARNING: Block comments use * on subsequent lines #468: FILE: target/i386/tcg/softmmu/bpt_helper_softmmu.c:136: + /* Fold the global and local enable bits together into the + global fields, then xor to show which registers have WARNING: Block comments use a trailing */ on a separate line #469: FILE: target/i386/tcg/softmmu/bpt_helper_softmmu.c:137: + changed collective enable state. */ total: 0 errors, 7 warnings, 606 lines checked Patch 10/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/14 Checking commit 39b0a0493fbe (i386: split misc helper into user and softmmu parts) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #513: new file mode 100644 ERROR: switch and case should be at the same indent #807: FILE: target/i386/tcg/softmmu/misc_helper_softmmu.c:290: + switch ((uint32_t)env->regs[R_ECX]) { [...] + case MSR_IA32_UCODE_REV: total: 1 errors, 1 warnings, 1004 lines checked Patch 11/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/14 Checking commit 8f91c0e7f8e2 (i386: separate fpu_helper into user and softmmu parts) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #124: new file mode 100644 total: 0 errors, 1 warnings, 218 lines checked Patch 12/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/14 Checking commit a2644bc6abc9 (i386: slit svm_helper into softmmu and stub-only user) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #12: target/i386/tcg/{ => softmmu}/svm_helper.c | 62 +----------------------- total: 0 errors, 1 warnings, 169 lines checked Patch 13/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/14 Checking commit c91731f9e2d4 (i386: split seg_helper into user-only and softmmu parts) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #320: new file mode 100644 ERROR: do not use C99 // comments #347: FILE: target/i386/tcg/seg_helper.h:23: +//#define DEBUG_PCALL WARNING: Block comments use a leading /* on a separate line #626: FILE: target/i386/tcg/user/seg_helper_user.c:75: + /* Since we emulate only user space, we cannot do more than WARNING: Block comments use * on subsequent lines #627: FILE: target/i386/tcg/user/seg_helper_user.c:76: + /* Since we emulate only user space, we cannot do more than + exiting the emulation with the suitable exception and error WARNING: Block comments use a trailing */ on a separate line #628: FILE: target/i386/tcg/user/seg_helper_user.c:77: + code. So update EIP for INT 0x80 and EXCP_SYSCALL. */ WARNING: Block comments use a leading /* on a separate line #639: FILE: target/i386/tcg/user/seg_helper_user.c:88: + /* if user mode only, we simulate a fake exception WARNING: Block comments use * on subsequent lines #640: FILE: target/i386/tcg/user/seg_helper_user.c:89: + /* if user mode only, we simulate a fake exception + which will be handled outside the cpu execution WARNING: Block comments use a trailing */ on a separate line #641: FILE: target/i386/tcg/user/seg_helper_user.c:90: + loop */ total: 1 errors, 7 warnings, 601 lines checked Patch 14/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210210152859.25920-1-cfontana@suse.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com