| Message ID | 20210207160901.110643-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: add labels with accel-location to bmc150 and kxcjk-1013 drivers | expand |
On Sun, 7 Feb 2021 17:08:58 +0100 Hans de Goede <hdegoede@redhat.com> wrote: > Hi All, > > Here is a patch-set implementing the standardized "accel-display" > and "accel-base" label sysfs-attributes defined in my earlier > "[PATCH 1/2] iio: documentation: Document proximity sensor label use" > "[PATCH 2/2] iio: documentation: Document accelerometer label use" > series. > > This patch sets adds these labels to the bmc150 and kxcjk-1013 accel > drivers. Series applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it. Note we are almost certainly too late for coming merge window so this will be next time around. Thanks, Jonathan > > Regards, > > Hans > > > Hans de Goede (3): > iio: core: Allow drivers to specify a label without it coming from of > iio: accel: bmc150: Set label based on accel-location on 2-accel > yoga-style 2-in-1s > iio: accel: kxcjk-1013: Set label based on accel-location on 2-accel > yoga-style 2-in-1s > > drivers/iio/accel/bmc150-accel-core.c | 18 ++++++++++++------ > drivers/iio/accel/kxcjk-1013.c | 14 ++++++++++---- > drivers/iio/industrialio-core.c | 6 ++++-- > 3 files changed, 26 insertions(+), 12 deletions(-) >
Hi, On 2/12/21 7:33 PM, Jonathan Cameron wrote: > On Sun, 7 Feb 2021 17:08:58 +0100 > Hans de Goede <hdegoede@redhat.com> wrote: > >> Hi All, >> >> Here is a patch-set implementing the standardized "accel-display" >> and "accel-base" label sysfs-attributes defined in my earlier >> "[PATCH 1/2] iio: documentation: Document proximity sensor label use" >> "[PATCH 2/2] iio: documentation: Document accelerometer label use" >> series. >> >> This patch sets adds these labels to the bmc150 and kxcjk-1013 accel >> drivers. > Series applied to the togreg branch of iio.git and pushed out as testing > for the autobuilders to poke at it. Thanks, much appreciated. But this was sorta a follow-up to: [PATCH 1/2] iio: documentation: Document proximity sensor label use [PATCH 2/2] iio: documentation: Document accelerometer label use Where 2/2 defines the standardized label values which this series uses and AFAIK those have not been merged yet? I guess we can always fix the labels if discussion surrounding those leads to standardizing on different label contents for this. But if the discussion surrounding those results in the conclusion to not use labels for this at all, while we already have this merged, then we probably need to revert 2/3 and 3/3 of this series... But maybe I just missed the 2 documentation patches getting merged ? > Note we are almost certainly too late for coming merge window so this > will be next time around. That is fine. Regards, Hans
On Fri, 12 Feb 2021 19:39:11 +0100 Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > On 2/12/21 7:33 PM, Jonathan Cameron wrote: > > On Sun, 7 Feb 2021 17:08:58 +0100 > > Hans de Goede <hdegoede@redhat.com> wrote: > > > >> Hi All, > >> > >> Here is a patch-set implementing the standardized "accel-display" > >> and "accel-base" label sysfs-attributes defined in my earlier > >> "[PATCH 1/2] iio: documentation: Document proximity sensor label use" > >> "[PATCH 2/2] iio: documentation: Document accelerometer label use" > >> series. > >> > >> This patch sets adds these labels to the bmc150 and kxcjk-1013 accel > >> drivers. > > Series applied to the togreg branch of iio.git and pushed out as testing > > for the autobuilders to poke at it. > > Thanks, much appreciated. > > But this was sorta a follow-up to: > > [PATCH 1/2] iio: documentation: Document proximity sensor label use > [PATCH 2/2] iio: documentation: Document accelerometer label use > > Where 2/2 defines the standardized label values which this series uses > and AFAIK those have not been merged yet? > > I guess we can always fix the labels if discussion surrounding those > leads to standardizing on different label contents for this. But if > the discussion surrounding those results in the conclusion to not > use labels for this at all, while we already have this merged, then > we probably need to revert 2/3 and 3/3 of this series... > > But maybe I just missed the 2 documentation patches getting merged ? Understood. The changes for the docs patch that I was looking for are just editorial, so I wasn't that fussed if it goes in slightly out of order. Jonathan > > > Note we are almost certainly too late for coming merge window so this > > will be next time around. > > That is fine. > > Regards, > > Hans >
Hi All, Here is a patch-set implementing the standardized "accel-display" and "accel-base" label sysfs-attributes defined in my earlier "[PATCH 1/2] iio: documentation: Document proximity sensor label use" "[PATCH 2/2] iio: documentation: Document accelerometer label use" series. This patch sets adds these labels to the bmc150 and kxcjk-1013 accel drivers. Regards, Hans Hans de Goede (3): iio: core: Allow drivers to specify a label without it coming from of iio: accel: bmc150: Set label based on accel-location on 2-accel yoga-style 2-in-1s iio: accel: kxcjk-1013: Set label based on accel-location on 2-accel yoga-style 2-in-1s drivers/iio/accel/bmc150-accel-core.c | 18 ++++++++++++------ drivers/iio/accel/kxcjk-1013.c | 14 ++++++++++---- drivers/iio/industrialio-core.c | 6 ++++-- 3 files changed, 26 insertions(+), 12 deletions(-)