| Message ID | 20210211220146.2525771-7-crosa@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Python / Acceptance Tests: improve logging | expand |
On 2/11/21 11:01 PM, Cleber Rosa wrote: "Preserve log" ... > At location already prepared for keeping the test's log files. > > While at it, log info about its location (in the main test log > file), instead of printing it out. > > Reference: https://avocado-framework.readthedocs.io/en/85.0/api/test/avocado.html#avocado.Test.logdir > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/virtio-gpu.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Using full sentence: Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On 2/11/21 7:01 PM, Cleber Rosa wrote: > At location already prepared for keeping the test's log files. > > While at it, log info about its location (in the main test log > file), instead of printing it out. > > Reference: https://avocado-framework.readthedocs.io/en/85.0/api/test/avocado.html#avocado.Test.logdir > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/virtio-gpu.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > > diff --git a/tests/acceptance/virtio-gpu.py b/tests/acceptance/virtio-gpu.py > index 8d689eb820..ab1a4c1a71 100644 > --- a/tests/acceptance/virtio-gpu.py > +++ b/tests/acceptance/virtio-gpu.py > @@ -119,10 +119,11 @@ class VirtioGPUx86(Test): > os.set_inheritable(vug_sock.fileno(), True) > > self._vug_log_path = os.path.join( > - self.vm.temp_dir, "vhost-user-gpu.log" > + self.logdir, "vhost-user-gpu.log" > ) > self._vug_log_file = open(self._vug_log_path, "wb") > - print(self._vug_log_path) > + self.log.info('Complete vhost-user-gpu.log file can be ' > + 'found at %s', self._vug_log_path) > > vugp = subprocess.Popen( > [vug, "--virgl", "--fd=%d" % vug_sock.fileno()],
diff --git a/tests/acceptance/virtio-gpu.py b/tests/acceptance/virtio-gpu.py index 8d689eb820..ab1a4c1a71 100644 --- a/tests/acceptance/virtio-gpu.py +++ b/tests/acceptance/virtio-gpu.py @@ -119,10 +119,11 @@ class VirtioGPUx86(Test): os.set_inheritable(vug_sock.fileno(), True) self._vug_log_path = os.path.join( - self.vm.temp_dir, "vhost-user-gpu.log" + self.logdir, "vhost-user-gpu.log" ) self._vug_log_file = open(self._vug_log_path, "wb") - print(self._vug_log_path) + self.log.info('Complete vhost-user-gpu.log file can be ' + 'found at %s', self._vug_log_path) vugp = subprocess.Popen( [vug, "--virgl", "--fd=%d" % vug_sock.fileno()],
At location already prepared for keeping the test's log files. While at it, log info about its location (in the main test log file), instead of printing it out. Reference: https://avocado-framework.readthedocs.io/en/85.0/api/test/avocado.html#avocado.Test.logdir Signed-off-by: Cleber Rosa <crosa@redhat.com> --- tests/acceptance/virtio-gpu.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)