| Message ID | 20210215161923.83682-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7f76963b692dd499e697d86e26eda8ca24b45c05 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | i40e: Fix incorrect use of ip6src due to copy-paste coding error | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 15 Feb 2021 16:19:23 +0000 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > It appears that the call of ipv6_add_any for the destination address > is using ip6src instead of ip6dst, this looks like a copy-paste > coding error. Fix this by replacing ip6src with ip6dst. > > Addresses-Coverity: ("Copy-paste error") > Fixes: efca91e89b67 ("i40e: Add flow director support for IPv6") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > [...] Here is the summary with links: - i40e: Fix incorrect use of ip6src due to copy-paste coding error https://git.kernel.org/netdev/net-next/c/7f76963b692d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index 8a4dd77a12da..a8a2b5f683a2 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -4250,7 +4250,7 @@ static int i40e_check_fdir_input_set(struct i40e_vsi *vsi, (struct in6_addr *)&ipv6_full_mask)) new_mask |= I40E_L3_V6_DST_MASK; else if (ipv6_addr_any((struct in6_addr *) - &tcp_ip6_spec->ip6src)) + &tcp_ip6_spec->ip6dst)) new_mask &= ~I40E_L3_V6_DST_MASK; else return -EOPNOTSUPP;