| Message ID | 20210218222326.15788-1-nicola.mazzucato@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | CPUFreq: Add support for opp-sharing cpus | expand |
On 18-02-21, 22:23, Nicola Mazzucato wrote: > Hi Viresh, > > In this V8 I have addressed your comments: > - correct the goto in patch 1/3 > - improve comment in patch 2/3 for dev_pm_opp_get_opp_count() LGTM. I will apply them after the merge window is over. Thanks.
Hi Viresh, On Fri, Feb 19, 2021 at 09:49:44AM +0530, Viresh Kumar wrote: > On 18-02-21, 22:23, Nicola Mazzucato wrote: > > Hi Viresh, > > > > In this V8 I have addressed your comments: > > - correct the goto in patch 1/3 > > - improve comment in patch 2/3 for dev_pm_opp_get_opp_count() > > LGTM. I will apply them after the merge window is over. Thanks. I am planning to merge the series on scmi[1] which changes scmi-cpufreq.c and will conflict with these changes I think. If possible either, 1. Share a branch with these changes that I can merge or 2. I can take patch 1/3 and 2/3 with other scmi changes with your Ack. I am fine either way, let me know by v5.12-rc1 -- Regards, Sudeep [1] https://lore.kernel.org/linux-arm-kernel/20210202221555.41167-1-cristian.marussi@arm.com/
On 19-02-21, 19:16, Sudeep Holla wrote: > Hi Viresh, > > On Fri, Feb 19, 2021 at 09:49:44AM +0530, Viresh Kumar wrote: > > On 18-02-21, 22:23, Nicola Mazzucato wrote: > > > Hi Viresh, > > > > > > In this V8 I have addressed your comments: > > > - correct the goto in patch 1/3 > > > - improve comment in patch 2/3 for dev_pm_opp_get_opp_count() > > > > LGTM. I will apply them after the merge window is over. Thanks. > > I am planning to merge the series on scmi[1] which changes scmi-cpufreq.c > and will conflict with these changes I think. If possible either, > > 1. Share a branch with these changes that I can merge or > 2. I can take patch 1/3 and 2/3 with other scmi changes with your Ack. > > I am fine either way, let me know by v5.12-rc1 I have applied 3/3, you can take first two and add my Ack. Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Mon, Feb 22, 2021 at 10:09:04AM +0530, Viresh Kumar wrote: > On 19-02-21, 19:16, Sudeep Holla wrote: > > Hi Viresh, > > > > On Fri, Feb 19, 2021 at 09:49:44AM +0530, Viresh Kumar wrote: > > > On 18-02-21, 22:23, Nicola Mazzucato wrote: > > > > Hi Viresh, > > > > > > > > In this V8 I have addressed your comments: > > > > - correct the goto in patch 1/3 > > > > - improve comment in patch 2/3 for dev_pm_opp_get_opp_count() > > > > > > LGTM. I will apply them after the merge window is over. Thanks. > > > > I am planning to merge the series on scmi[1] which changes scmi-cpufreq.c > > and will conflict with these changes I think. If possible either, > > > > 1. Share a branch with these changes that I can merge or > > 2. I can take patch 1/3 and 2/3 with other scmi changes with your Ack. > > > > I am fine either way, let me know by v5.12-rc1 > > I have applied 3/3, you can take first two and add my Ack. > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Thanks Viresh, I will pick after v5.12-rc1
On Thu, 18 Feb 2021 22:23:23 +0000, Nicola Mazzucato wrote: > In this V8 I have addressed your comments: > - correct the goto in patch 1/3 > - improve comment in patch 2/3 for dev_pm_opp_get_opp_count() > > Many thanks, > Nicola > > [...] Applied the first 2 patches to sudeep.holla/linux (for-next/scmi), thanks! [1/3] scmi-cpufreq: Remove deferred probe https://git.kernel.org/sudeep.holla/c/2a3390d53b [2/3] scmi-cpufreq: Get opp_shared_cpus from opp-v2 for EM https://git.kernel.org/sudeep.holla/c/dac7a57d2a -- Regards, Sudeep
On Thu, 18 Feb 2021 22:23:23 +0000, Nicola Mazzucato wrote: > In this V8 I have addressed your comments: > - correct the goto in patch 1/3 > - improve comment in patch 2/3 for dev_pm_opp_get_opp_count() > > Many thanks, > Nicola > > [...] (New commit info after rebase to v5.12-rc2 for obvious reasons) Applied to sudeep.holla/linux (for-next/scmi), thanks! [1/3] scmi-cpufreq: Remove deferred probe https://git.kernel.org/sudeep.holla/c/71a37cd6a5 [2/3] scmi-cpufreq: Get opp_shared_cpus from opp-v2 for EM https://git.kernel.org/sudeep.holla/c/80a064dbd5 -- Regards, Sudeep
Hi Viresh, In this V8 I have addressed your comments: - correct the goto in patch 1/3 - improve comment in patch 2/3 for dev_pm_opp_get_opp_count() Many thanks, Nicola [v8] * Correct "goto" in patch 1/3 * Improve comment in patch 2/3 for dev_pm_opp_get_opp_count() This v8 is rebased on v5.11 [v7] * Bring back common stuff for CPUs from _init stage to _probe * Remove patch "scmi-cpufreq: Move CPU initialisation to probe" This v7 is based on Linux 5.11-rc6 [v6] * Remove deferred probe, not occurring * Move common stuff for CPUs from _init stage to _probe This V6 is rebased on next-20210111 [v5] * Rework documentation of opp-shared within OPP node * Register EM only for the first CPU within cpumask in driver * Add check for nr_opp in driver before registering EM * Add comments on both dev_pm_opp_get_opp_count in driver * Remove redundant ret=0 in driver This v5 is rebased on top of: next-20201208 + Lukasz Luba's patches [1] [v4] * Remove unconditional set of opp_table->shared_opp to exclusive * Add implementation for scmi-cpufreq * Change subject These patches are on top of: next-20201201 + Lukasz Luba's patches (waiting for Rafael) [1] [v3] * Remove proposal for new 'cpu-performance-dependencies' as we instead can reuse the opp table. * Update documentation for devicetree/bindings/opp * Minor changes within opp to support empty opp table * Rework the RFC by adding a second proposal [v2] * Fix errors when running make dt_binding_check * Improve commit message description for the dt-binding * Add RFC for implementation in cpufreq-core and one of its drivers. Nicola Mazzucato (2): scmi-cpufreq: Remove deferred probe scmi-cpufreq: Get opp_shared_cpus from opp-v2 for EM Sudeep Holla (1): cpufreq: blacklist Arm Vexpress platforms in cpufreq-dt-platdev drivers/cpufreq/cpufreq-dt-platdev.c | 2 + drivers/cpufreq/scmi-cpufreq.c | 72 +++++++++++++++++++++------- 2 files changed, 56 insertions(+), 18 deletions(-)