| Message ID | 20210215185908.257724-2-pasha.tatashin@soleen.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fix machine_kexec_post_load prototype. | expand |
On Mon, Feb 15, 2021 at 01:59:08PM -0500, Pavel Tatashin wrote: > machine_kexec_post_load() is called after kexec load is finished. It must > be declared in public header not in kexec_internal.h Could you provide a log of what goes wrong without this patch, please? > Reported-by: kernel test robot <lkp@intel.com> Do you have a link to the report, or did it not go to the list? Will
On Fri, Feb 19, 2021 at 12:53 PM Will Deacon <will@kernel.org> wrote: > > On Mon, Feb 15, 2021 at 01:59:08PM -0500, Pavel Tatashin wrote: > > machine_kexec_post_load() is called after kexec load is finished. It must > > be declared in public header not in kexec_internal.h > > Could you provide a log of what goes wrong without this patch, please? > > > Reported-by: kernel test robot <lkp@intel.com> > > Do you have a link to the report, or did it not go to the list? Hi Will, https://lore.kernel.org/linux-arm-kernel/202102030727.gqTokACH-lkp@intel.com/ It is also linked in the cover letter. Thank you, Pasha
On Fri, Feb 19, 2021 at 02:06:31PM -0500, Pavel Tatashin wrote: > On Fri, Feb 19, 2021 at 12:53 PM Will Deacon <will@kernel.org> wrote: > > > > On Mon, Feb 15, 2021 at 01:59:08PM -0500, Pavel Tatashin wrote: > > > machine_kexec_post_load() is called after kexec load is finished. It must > > > be declared in public header not in kexec_internal.h > > > > Could you provide a log of what goes wrong without this patch, please? > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > > Do you have a link to the report, or did it not go to the list? > > Hi Will, > > https://lore.kernel.org/linux-arm-kernel/202102030727.gqTokACH-lkp@intel.com/ > > It is also linked in the cover letter. Ah, great. Please add that as a Link: tag in the patch, and in-line the compiler warning. Will
On Fri, Feb 19, 2021 at 2:14 PM Will Deacon <will@kernel.org> wrote: > > On Fri, Feb 19, 2021 at 02:06:31PM -0500, Pavel Tatashin wrote: > > On Fri, Feb 19, 2021 at 12:53 PM Will Deacon <will@kernel.org> wrote: > > > > > > On Mon, Feb 15, 2021 at 01:59:08PM -0500, Pavel Tatashin wrote: > > > > machine_kexec_post_load() is called after kexec load is finished. It must > > > > be declared in public header not in kexec_internal.h > > > > > > Could you provide a log of what goes wrong without this patch, please? > > > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > > > > Do you have a link to the report, or did it not go to the list? > > > > Hi Will, > > > > https://lore.kernel.org/linux-arm-kernel/202102030727.gqTokACH-lkp@intel.com/ > > > > It is also linked in the cover letter. > > Ah, great. Please add that as a Link: tag in the patch, and in-line the > compiler warning. Version 2 of this fix: https://lore.kernel.org/lkml/20210219195142.13571-1-pasha.tatashin@soleen.com/ With the tag link, and warning in-lined. Thank you, Pasha
diff --git a/include/linux/kexec.h b/include/linux/kexec.h index 9e93bef52968..3671b845cf28 100644 --- a/include/linux/kexec.h +++ b/include/linux/kexec.h @@ -309,6 +309,8 @@ extern void machine_kexec_cleanup(struct kimage *image); extern int kernel_kexec(void); extern struct page *kimage_alloc_control_pages(struct kimage *image, unsigned int order); +int machine_kexec_post_load(struct kimage *image); + extern void __crash_kexec(struct pt_regs *); extern void crash_kexec(struct pt_regs *); int kexec_should_crash(struct task_struct *); diff --git a/kernel/kexec_internal.h b/kernel/kexec_internal.h index 39d30ccf8d87..48aaf2ac0d0d 100644 --- a/kernel/kexec_internal.h +++ b/kernel/kexec_internal.h @@ -13,8 +13,6 @@ void kimage_terminate(struct kimage *image); int kimage_is_destination_range(struct kimage *image, unsigned long start, unsigned long end); -int machine_kexec_post_load(struct kimage *image); - extern struct mutex kexec_mutex; #ifdef CONFIG_KEXEC_FILE
machine_kexec_post_load() is called after kexec load is finished. It must be declared in public header not in kexec_internal.h Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com> --- include/linux/kexec.h | 2 ++ kernel/kexec_internal.h | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-)