| Message ID | 20210216174146.106639-11-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: i2c: GMSL reliability improvements | expand |
On Tue, Feb 16, 2021 at 6:41 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > Rename the reverse_channel_mv variable to init_rev_chan_mv as > the next patches will cache the reverse channel amplitude in patch? > a new driver variable. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Gr{oetje,eeting}s, Geert
Hi Jacopo, On 16/02/2021 17:41, Jacopo Mondi wrote: > Rename the reverse_channel_mv variable to init_rev_chan_mv as > the next patches will cache the reverse channel amplitude in > a new driver variable. > I've been trying to figure out if we really do need two variables to store this now, but I can't see an easy way to factor out the initialisation value, and I like the idea of caching the current stored value. So Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > drivers/media/i2c/max9286.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c > index 1d9951215868..1f14cd817fbf 100644 > --- a/drivers/media/i2c/max9286.c > +++ b/drivers/media/i2c/max9286.c > @@ -163,7 +163,7 @@ struct max9286_priv { > unsigned int mux_channel; > bool mux_open; > > - u32 reverse_channel_mv; > + u32 init_rev_chan_mv; > > struct v4l2_ctrl_handler ctrls; > struct v4l2_ctrl *pixelrate; > @@ -563,7 +563,7 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier, > * - Disable auto-ack as communication on the control channel are now > * stable. > */ > - if (priv->reverse_channel_mv < 170) > + if (priv->init_rev_chan_mv < 170) > max9286_reverse_channel_setup(priv, 170); > max9286_check_config_link(priv, priv->source_mask); > > @@ -971,7 +971,7 @@ static int max9286_setup(struct max9286_priv *priv) > * only. This should be disabled after the mux is initialised. > */ > max9286_configure_i2c(priv, true); > - max9286_reverse_channel_setup(priv, priv->reverse_channel_mv); > + max9286_reverse_channel_setup(priv, priv->init_rev_chan_mv); > > /* > * Enable GMSL links, mask unused ones and autodetect link > @@ -1236,9 +1236,9 @@ static int max9286_parse_dt(struct max9286_priv *priv) > if (of_property_read_u32(dev->of_node, > "maxim,reverse-channel-microvolt", > &reverse_channel_microvolt)) > - priv->reverse_channel_mv = 170; > + priv->init_rev_chan_mv = 170; > else > - priv->reverse_channel_mv = reverse_channel_microvolt / 1000U; > + priv->init_rev_chan_mv = reverse_channel_microvolt / 1000U; > > priv->route_mask = priv->source_mask; > >
Hi Jacopo, Thank you for the patch. On Tue, Feb 16, 2021 at 06:41:40PM +0100, Jacopo Mondi wrote: > Rename the reverse_channel_mv variable to init_rev_chan_mv as > the next patches will cache the reverse channel amplitude in > a new driver variable. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > drivers/media/i2c/max9286.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c > index 1d9951215868..1f14cd817fbf 100644 > --- a/drivers/media/i2c/max9286.c > +++ b/drivers/media/i2c/max9286.c > @@ -163,7 +163,7 @@ struct max9286_priv { > unsigned int mux_channel; > bool mux_open; > > - u32 reverse_channel_mv; > + u32 init_rev_chan_mv; Maybe it could be time to add some kerneldoc to this structure, or just a comment for this field, to explain what it stores ? Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > struct v4l2_ctrl_handler ctrls; > struct v4l2_ctrl *pixelrate; > @@ -563,7 +563,7 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier, > * - Disable auto-ack as communication on the control channel are now > * stable. > */ > - if (priv->reverse_channel_mv < 170) > + if (priv->init_rev_chan_mv < 170) > max9286_reverse_channel_setup(priv, 170); > max9286_check_config_link(priv, priv->source_mask); > > @@ -971,7 +971,7 @@ static int max9286_setup(struct max9286_priv *priv) > * only. This should be disabled after the mux is initialised. > */ > max9286_configure_i2c(priv, true); > - max9286_reverse_channel_setup(priv, priv->reverse_channel_mv); > + max9286_reverse_channel_setup(priv, priv->init_rev_chan_mv); > > /* > * Enable GMSL links, mask unused ones and autodetect link > @@ -1236,9 +1236,9 @@ static int max9286_parse_dt(struct max9286_priv *priv) > if (of_property_read_u32(dev->of_node, > "maxim,reverse-channel-microvolt", > &reverse_channel_microvolt)) > - priv->reverse_channel_mv = 170; > + priv->init_rev_chan_mv = 170; > else > - priv->reverse_channel_mv = reverse_channel_microvolt / 1000U; > + priv->init_rev_chan_mv = reverse_channel_microvolt / 1000U; > > priv->route_mask = priv->source_mask; >
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 1d9951215868..1f14cd817fbf 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -163,7 +163,7 @@ struct max9286_priv { unsigned int mux_channel; bool mux_open; - u32 reverse_channel_mv; + u32 init_rev_chan_mv; struct v4l2_ctrl_handler ctrls; struct v4l2_ctrl *pixelrate; @@ -563,7 +563,7 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier, * - Disable auto-ack as communication on the control channel are now * stable. */ - if (priv->reverse_channel_mv < 170) + if (priv->init_rev_chan_mv < 170) max9286_reverse_channel_setup(priv, 170); max9286_check_config_link(priv, priv->source_mask); @@ -971,7 +971,7 @@ static int max9286_setup(struct max9286_priv *priv) * only. This should be disabled after the mux is initialised. */ max9286_configure_i2c(priv, true); - max9286_reverse_channel_setup(priv, priv->reverse_channel_mv); + max9286_reverse_channel_setup(priv, priv->init_rev_chan_mv); /* * Enable GMSL links, mask unused ones and autodetect link @@ -1236,9 +1236,9 @@ static int max9286_parse_dt(struct max9286_priv *priv) if (of_property_read_u32(dev->of_node, "maxim,reverse-channel-microvolt", &reverse_channel_microvolt)) - priv->reverse_channel_mv = 170; + priv->init_rev_chan_mv = 170; else - priv->reverse_channel_mv = reverse_channel_microvolt / 1000U; + priv->init_rev_chan_mv = reverse_channel_microvolt / 1000U; priv->route_mask = priv->source_mask;
Rename the reverse_channel_mv variable to init_rev_chan_mv as the next patches will cache the reverse channel amplitude in a new driver variable. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- drivers/media/i2c/max9286.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)