diff mbox series

net/mlx5: remove unneeded semicolon

Message ID 1613987819-43161-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive)
State Not Applicable
Headers show
Series net/mlx5: remove unneeded semicolon | expand

Commit Message

Jiapeng Chong Feb. 22, 2021, 9:56 a.m. UTC
Fix the following coccicheck warnings:

./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3: Unneeded
semicolon.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Parav Pandit Feb. 22, 2021, 10:01 a.m. UTC | #1
> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Sent: Monday, February 22, 2021 3:27 PM
> 
> Fix the following coccicheck warnings:
> 
> ./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3: Unneeded
> semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> index c2ba41b..60a6328 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> @@ -492,7 +492,7 @@ static int mlx5_sf_esw_event(struct notifier_block
> *nb, unsigned long event, voi
>  		break;
>  	default:
>  		break;
> -	};
> +	}
> 
>  	return 0;
>  }
> --
> 1.8.3.1

Reviewed-by: Parav Pandit <parav@nvidia.com>
Parav Pandit March 3, 2021, 8:52 a.m. UTC | #2
Hi Saeed,

> From: Parav Pandit <parav@nvidia.com>
> Sent: Monday, February 22, 2021 3:32 PM
> 
> 
> > From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > Sent: Monday, February 22, 2021 3:27 PM
> >
> > Fix the following coccicheck warnings:
> >
> > ./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3:
> > Unneeded semicolon.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > ---
> >  drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > index c2ba41b..60a6328 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > @@ -492,7 +492,7 @@ static int mlx5_sf_esw_event(struct notifier_block
> > *nb, unsigned long event, voi
> >  		break;
> >  	default:
> >  		break;
> > -	};
> > +	}
> >
> >  	return 0;
> >  }
> > --
> > 1.8.3.1
> 
> Reviewed-by: Parav Pandit <parav@nvidia.com>

Will you take this patch [1] to your queue?

[1] https://lore.kernel.org/linux-rdma/1613987819-43161-1-git-send-email-jiapeng.chong@linux.alibaba.com/
Saeed Mahameed March 11, 2021, 11:24 p.m. UTC | #3
On Wed, 2021-03-03 at 08:52 +0000, Parav Pandit wrote:
> Hi Saeed,
> 
> > From: Parav Pandit <parav@nvidia.com>
> > Sent: Monday, February 22, 2021 3:32 PM
> > 
> > 
> > > From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > > Sent: Monday, February 22, 2021 3:27 PM
> > > 
> > > Fix the following coccicheck warnings:
> > > 
> > > ./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3:
> > > Unneeded semicolon.
> > > 
> > > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > > ---
> > >  drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > > b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > > index c2ba41b..60a6328 100644
> > > --- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
> > > @@ -492,7 +492,7 @@ static int mlx5_sf_esw_event(struct
> > > notifier_block
> > > *nb, unsigned long event, voi
> > >                 break;
> > >         default:
> > >                 break;
> > > -       };
> > > +       }
> > > 
> > >         return 0;
> > >  }
> > > --
> > > 1.8.3.1
> > 
> > Reviewed-by: Parav Pandit <parav@nvidia.com>
> 
> Will you take this patch [1] to your queue?
> 
> [1]
> https://lore.kernel.org/linux-rdma/1613987819-43161-1-git-send-email-jiapeng.chong@linux.alibaba.com/

Applied to net-next-mlx5.
Thanks,
Saeed.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
index c2ba41b..60a6328 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c
@@ -492,7 +492,7 @@  static int mlx5_sf_esw_event(struct notifier_block *nb, unsigned long event, voi
 		break;
 	default:
 		break;
-	};
+	}
 
 	return 0;
 }