| Message ID | 20210220200107.4833-1-noltari@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [v2] hwrng: iproc: set quality to 1024 | expand |
Looks ok to me. On 2021-02-20 12:01 p.m., Álvaro Fernández Rojas wrote: > This allows khwrngd to make use of iproc-rng200. > > Justification: > cat /dev/hwrng | rngtest -c 1000 > rngtest 6.10 > Copyright (c) 2004 by Henrique de Moraes Holschuh > This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > rngtest: starting FIPS tests... > rngtest: bits received from input: 20000032 > rngtest: FIPS 140-2 successes: 1000 > rngtest: FIPS 140-2 failures: 0 > rngtest: FIPS 140-2(2001-10-10) Monobit: 0 > rngtest: FIPS 140-2(2001-10-10) Poker: 0 > rngtest: FIPS 140-2(2001-10-10) Runs: 0 > rngtest: FIPS 140-2(2001-10-10) Long run: 0 > rngtest: FIPS 140-2(2001-10-10) Continuous run: 0 > rngtest: input channel speed: (min=107.179; avg=200.770; max=9765625.000)Kibits/s > rngtest: FIPS tests speed: (min=34.742; avg=39.905; max=66.458)Mibits/s > rngtest: Program run time: 97829648 microseconds > > 1000 successes and 0 failures -> 100% success rate > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> Acked-by: Scott Branden <scott.branden@broadcom.com> > --- > v2: set quality to 1024 and add justification > > drivers/char/hw_random/iproc-rng200.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c > index 01583faf9893..d22406528ac5 100644 > --- a/drivers/char/hw_random/iproc-rng200.c > +++ b/drivers/char/hw_random/iproc-rng200.c > @@ -199,6 +199,7 @@ static int iproc_rng200_probe(struct platform_device *pdev) > priv->rng.read = iproc_rng200_read; > priv->rng.init = iproc_rng200_init; > priv->rng.cleanup = iproc_rng200_cleanup; > + priv->rng.quality = 1024; > > /* Register driver */ > ret = devm_hwrng_register(dev, &priv->rng); >
Hi, Am 20.02.21 um 21:01 schrieb Álvaro Fernández Rojas: > This allows khwrngd to make use of iproc-rng200. > > Justification: > cat /dev/hwrng | rngtest -c 1000 > rngtest 6.10 > Copyright (c) 2004 by Henrique de Moraes Holschuh > This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > rngtest: starting FIPS tests... > rngtest: bits received from input: 20000032 > rngtest: FIPS 140-2 successes: 1000 > rngtest: FIPS 140-2 failures: 0 > rngtest: FIPS 140-2(2001-10-10) Monobit: 0 > rngtest: FIPS 140-2(2001-10-10) Poker: 0 > rngtest: FIPS 140-2(2001-10-10) Runs: 0 > rngtest: FIPS 140-2(2001-10-10) Long run: 0 > rngtest: FIPS 140-2(2001-10-10) Continuous run: 0 > rngtest: input channel speed: (min=107.179; avg=200.770; max=9765625.000)Kibits/s > rngtest: FIPS tests speed: (min=34.742; avg=39.905; max=66.458)Mibits/s > rngtest: Program run time: 97829648 microseconds > > 1000 successes and 0 failures -> 100% success rate > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> i just want to mention that there were concerns about such changes in the past [1] Regards Stefan [1] - https://lkml.org/lkml/2020/5/14/1292
diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c index 01583faf9893..d22406528ac5 100644 --- a/drivers/char/hw_random/iproc-rng200.c +++ b/drivers/char/hw_random/iproc-rng200.c @@ -199,6 +199,7 @@ static int iproc_rng200_probe(struct platform_device *pdev) priv->rng.read = iproc_rng200_read; priv->rng.init = iproc_rng200_init; priv->rng.cleanup = iproc_rng200_cleanup; + priv->rng.quality = 1024; /* Register driver */ ret = devm_hwrng_register(dev, &priv->rng);
This allows khwrngd to make use of iproc-rng200. Justification: cat /dev/hwrng | rngtest -c 1000 rngtest 6.10 Copyright (c) 2004 by Henrique de Moraes Holschuh This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. rngtest: starting FIPS tests... rngtest: bits received from input: 20000032 rngtest: FIPS 140-2 successes: 1000 rngtest: FIPS 140-2 failures: 0 rngtest: FIPS 140-2(2001-10-10) Monobit: 0 rngtest: FIPS 140-2(2001-10-10) Poker: 0 rngtest: FIPS 140-2(2001-10-10) Runs: 0 rngtest: FIPS 140-2(2001-10-10) Long run: 0 rngtest: FIPS 140-2(2001-10-10) Continuous run: 0 rngtest: input channel speed: (min=107.179; avg=200.770; max=9765625.000)Kibits/s rngtest: FIPS tests speed: (min=34.742; avg=39.905; max=66.458)Mibits/s rngtest: Program run time: 97829648 microseconds 1000 successes and 0 failures -> 100% success rate Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> --- v2: set quality to 1024 and add justification drivers/char/hw_random/iproc-rng200.c | 1 + 1 file changed, 1 insertion(+)