| Message ID | 20210223160131.29053-2-noltari@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hwrng: bcm2835: add reset support | expand |
On 2/23/2021 8:01 AM, Álvaro Fernández Rojas wrote: > Some devices may need to perform a reset before using the RNG, such as the > BCM6368. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> Since the reset is unique to the 6368, you may want to make the property mandatory for the 6368 compatible string and optional otherwise.
On 2021-02-23 8:36 a.m., Florian Fainelli wrote: > > > On 2/23/2021 8:01 AM, Álvaro Fernández Rojas wrote: >> Some devices may need to perform a reset before using the RNG, such as the >> BCM6368. >> >> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > > Since the reset is unique to the 6368, you may want to make the property > mandatory for the 6368 compatible string and optional otherwise. > Perhaps the reset could be done at an earlier boot stage as well and then the reset would even be optional on 6368?
Hello Scott, El 23/02/2021 a las 18:17, Scott Branden escribió: > On 2021-02-23 8:36 a.m., Florian Fainelli wrote: >> >> >> On 2/23/2021 8:01 AM, Álvaro Fernández Rojas wrote: >>> Some devices may need to perform a reset before using the RNG, such as the >>> BCM6368. >>> >>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> >> >> Since the reset is unique to the 6368, you may want to make the property >> mandatory for the 6368 compatible string and optional otherwise. >> > Perhaps the reset could be done at an earlier boot stage as well and then the > reset would even be optional on 6368? > No, this isn't possible on bmips, which is device tree only. However, it's how is done in bcm63xx, which is why it wasn't needed before. Best regards, Álvaro.
diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml index c147900f9041..dba70764b7d0 100644 --- a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml +++ b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml @@ -31,6 +31,9 @@ properties: interrupts: maxItems: 1 + resets: + maxItems: 1 + required: - compatible - reg @@ -58,4 +61,6 @@ examples: clocks = <&periph_clk 18>; clock-names = "ipsec"; + + resets = <&periph_rst 4>; };
Some devices may need to perform a reset before using the RNG, such as the BCM6368. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> --- v2: document reset support. Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml | 5 +++++ 1 file changed, 5 insertions(+)