diff mbox series

[v9,9/9] certs: Add support for using elliptic curve keys for signing modules

Message ID 20210225160802.2478700-10-stefanb@linux.vnet.ibm.com (mailing list archive)
State Changes Requested
Delegated to: Herbert Xu
Headers show
Series Add support for x509 certs with NIST P384/256/192 keys | expand

Commit Message

Stefan Berger Feb. 25, 2021, 4:08 p.m. UTC 
From: Stefan Berger <stefanb@linux.ibm.com>

This patch adds support for using elliptic curve keys for signing
modules. It uses a NIST P384 (secp384r1) key if the user chooses an
elliptic curve key and will have ECDSA support built into the kernel.

Note: A developer choosing an ECDSA key for signing modules has to
manually delete the signing key (rm certs/signing_key.*) when falling
back to building an older version of a kernel that only supports RSA
keys since otherwise ECDSA-signed modules will not be usable when that
older kernel runs and the ECDSA key was still used for signing modules.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>

---

v8->v9:
 - Automatically select CONFIG_ECDSA for built-in ECDSA support
 - Added help documentation

This patch builds on top Nayna's series for 'kernel build support for
loading the kernel module signing key'.
- https://lkml.org/lkml/2021/2/18/856
---
 certs/Kconfig                         | 22 ++++++++++++++++++++++
 certs/Makefile                        | 14 ++++++++++++++
 crypto/asymmetric_keys/pkcs7_parser.c |  4 ++++
 3 files changed, 40 insertions(+)

Comments

Meng Yu Feb. 27, 2021, 3:35 a.m. UTC | #1 
在 2021/2/26 0:08, Stefan Berger 写道:
> From: Stefan Berger <stefanb@linux.ibm.com>
> 

> diff --git a/certs/Makefile b/certs/Makefile
> index 3fe6b73786fa..c487d7021c54 100644
> --- a/certs/Makefile
> +++ b/certs/Makefile
> @@ -69,6 +69,18 @@ else
>   SIGNER = -signkey $(obj)/signing_key.key
>   endif # CONFIG_IMA_APPRAISE_MODSIG
>   

Is there anything wrong in this patch?
I can't apply it when I use 'git am '.
errors like below:

error: certs/Kconfig: does not match index
error: patch failed: certs/Makefile:69
error: certs/Makefile: patch does not apply

Thanks
Mimi Zohar March 1, 2021, 1:11 p.m. UTC | #2 
On Sat, 2021-02-27 at 11:35 +0800, yumeng wrote:
> 在 2021/2/26 0:08, Stefan Berger 写道:
> > From: Stefan Berger <stefanb@linux.ibm.com>
> > 
> 
> > diff --git a/certs/Makefile b/certs/Makefile
> > index 3fe6b73786fa..c487d7021c54 100644
> > --- a/certs/Makefile
> > +++ b/certs/Makefile
> > @@ -69,6 +69,18 @@ else
> >   SIGNER = -signkey $(obj)/signing_key.key
> >   endif # CONFIG_IMA_APPRAISE_MODSIG
> >   
> 
> Is there anything wrong in this patch?
> I can't apply it when I use 'git am '.
> errors like below:
> 
> error: certs/Kconfig: does not match index
> error: patch failed: certs/Makefile:69
> error: certs/Makefile: patch does not apply
> 
> Thanks

Nothing wrong with the patch, just a dependency.  From the Change log:
   - This patch builds on top Nayna's series for 'kernel build support
   for loading the kernel module signing key'.
   - https://lkml.org/lkml/2021/2/18/856

thanks,

Mimi
Stefan Berger March 1, 2021, 9:19 p.m. UTC | #3 
On 2/26/21 10:35 PM, yumeng wrote:
>
> 在 2021/2/26 0:08, Stefan Berger 写道:
>> From: Stefan Berger <stefanb@linux.ibm.com>
>>
>
>> diff --git a/certs/Makefile b/certs/Makefile
>> index 3fe6b73786fa..c487d7021c54 100644
>> --- a/certs/Makefile
>> +++ b/certs/Makefile
>> @@ -69,6 +69,18 @@ else
>>   SIGNER = -signkey $(obj)/signing_key.key
>>   endif # CONFIG_IMA_APPRAISE_MODSIG
>
> Is there anything wrong in this patch?
> I can't apply it when I use 'git am '.
> errors like below:

This patch builds on top Nayna's series for 'kernel build support for
loading the kernel module signing key'.
-https://lkml.org/lkml/2021/2/18/856

      Stefan
Meng Yu March 2, 2021, 1:04 a.m. UTC | #4 
在 2021/3/1 21:11, Mimi Zohar 写道:
> On Sat, 2021-02-27 at 11:35 +0800, yumeng wrote:
>> 在 2021/2/26 0:08, Stefan Berger 写道:
>>> From: Stefan Berger <stefanb@linux.ibm.com>
>>>
>>
>>> diff --git a/certs/Makefile b/certs/Makefile
>>> index 3fe6b73786fa..c487d7021c54 100644
>>> --- a/certs/Makefile
>>> +++ b/certs/Makefile
>>> @@ -69,6 +69,18 @@ else
>>>    SIGNER = -signkey $(obj)/signing_key.key
>>>    endif # CONFIG_IMA_APPRAISE_MODSIG
>>>    
>>
>> Is there anything wrong in this patch?
>> I can't apply it when I use 'git am '.
>> errors like below:
>>
>> error: certs/Kconfig: does not match index
>> error: patch failed: certs/Makefile:69
>> error: certs/Makefile: patch does not apply
>>
>> Thanks
> 
> Nothing wrong with the patch, just a dependency.  From the Change log:
>     - This patch builds on top Nayna's series for 'kernel build support
>     for loading the kernel module signing key'.
>     - https://lkml.org/lkml/2021/2/18/856
> 
> thanks,
> 
> Mimi
> 
> 

OK, thank you. Sorry for the noise.
diff mbox series

Patch

diff --git a/certs/Kconfig b/certs/Kconfig
index 48675ad319db..919db43ce80b 100644
--- a/certs/Kconfig
+++ b/certs/Kconfig
@@ -15,6 +15,28 @@  config MODULE_SIG_KEY
          then the kernel will automatically generate the private key and
          certificate as described in Documentation/admin-guide/module-signing.rst
 
+choice
+	prompt "Type of module signing key to be generated"
+	default MODULE_SIG_KEY_TYPE_RSA
+	help
+	 The type of module signing key type to generated. This option
+	 does not apply if a #PKCS11 URI is used.
+
+config MODULE_SIG_KEY_TYPE_RSA
+	bool "RSA"
+	depends on MODULE_SIG || IMA_APPRAISE_MODSIG
+	help
+	 Use an RSA key for module signing.
+
+config MODULE_SIG_KEY_TYPE_ECDSA
+	bool "ECDSA"
+	select CRYPTO_ECDSA
+	depends on MODULE_SIG || IMA_APPRAISE_MODSIG
+	help
+	 Use an elliptic curve key (NIST P384) for module signing.
+
+endchoice
+
 config SYSTEM_TRUSTED_KEYRING
 	bool "Provide system-wide ring of trusted keys"
 	depends on KEYS
diff --git a/certs/Makefile b/certs/Makefile
index 3fe6b73786fa..c487d7021c54 100644
--- a/certs/Makefile
+++ b/certs/Makefile
@@ -69,6 +69,18 @@  else
 SIGNER = -signkey $(obj)/signing_key.key
 endif # CONFIG_IMA_APPRAISE_MODSIG
 
+X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text)
+
+# Support user changing key type
+ifdef CONFIG_MODULE_SIG_KEY_TYPE_ECDSA
+keytype_openssl = -newkey ec -pkeyopt ec_paramgen_curve:secp384r1
+$(if $(findstring ecdsa-with-,$(X509TEXT)),,$(shell rm -f $(CONFIG_MODULE_SIG_KEY)))
+endif
+
+ifdef CONFIG_MODULE_SIG_KEY_TYPE_RSA
+$(if $(findstring rsaEncryption,$(X509TEXT)),,$(shell rm -f $(CONFIG_MODULE_SIG_KEY)))
+endif
+
 $(obj)/signing_key.pem: $(obj)/x509.genkey
 	@$(kecho) "###"
 	@$(kecho) "### Now generating an X.509 key pair to be used for signing modules."
@@ -86,12 +98,14 @@  ifeq ($(CONFIG_IMA_APPRAISE_MODSIG),y)
 		-batch -x509 -config $(obj)/x509.genkey \
 		-outform PEM -out $(CA_KEY) \
 		-keyout $(CA_KEY) -extensions ca_ext \
+		$(keytype_openssl) \
 		$($(quiet)redirect_openssl)
 endif # CONFIG_IMA_APPRAISE_MODSIG
 	$(Q)openssl req -new -nodes -utf8 \
 		-batch -config $(obj)/x509.genkey \
 		-outform PEM -out $(obj)/signing_key.csr \
 		-keyout $(obj)/signing_key.key -extensions myexts \
+		$(keytype_openssl) \
 		$($(quiet)redirect_openssl)
 	$(Q)openssl x509 -req -days 36500 -in $(obj)/signing_key.csr \
 		-outform PEM -out $(obj)/signing_key.crt $(SIGNER) \
diff --git a/crypto/asymmetric_keys/pkcs7_parser.c b/crypto/asymmetric_keys/pkcs7_parser.c
index 967329e0a07b..2546ec6a0505 100644
--- a/crypto/asymmetric_keys/pkcs7_parser.c
+++ b/crypto/asymmetric_keys/pkcs7_parser.c
@@ -269,6 +269,10 @@  int pkcs7_sig_note_pkey_algo(void *context, size_t hdrlen,
 		ctx->sinfo->sig->pkey_algo = "rsa";
 		ctx->sinfo->sig->encoding = "pkcs1";
 		break;
+	case OID_id_ecdsa_with_sha256:
+		ctx->sinfo->sig->pkey_algo = "ecdsa";
+		ctx->sinfo->sig->encoding = "x962";
+		break;
 	default:
 		printk("Unsupported pkey algo: %u\n", ctx->last_oid);
 		return -ENOPKG;