mbox series

[ipsec,0/2] vti(6): fix ipv4 pmtu check to honor ip header df

Message ID 20210226213506.506799-1-eyal.birger@gmail.com (mailing list archive)
Headers show
Series vti(6): fix ipv4 pmtu check to honor ip header df | expand

Message

Eyal Birger Feb. 26, 2021, 9:35 p.m. UTC 
This series aligns vti(6) handling of non-df IPv4 packets exceeding
the size of the tunnel MTU to avoid sending "Frag needed" and instead
fragment the packets after encapsulation.

Eyal Birger (2):
  vti: fix ipv4 pmtu check to honor ip header df
  vti6: fix ipv4 pmtu check to honor ip header df

 net/ipv4/ip_vti.c  | 6 ++++--
 net/ipv6/ip6_vti.c | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

Comments

Sabrina Dubroca March 2, 2021, 9:32 a.m. UTC | #1 
2021-02-26, 23:35:04 +0200, Eyal Birger wrote:
> This series aligns vti(6) handling of non-df IPv4 packets exceeding
> the size of the tunnel MTU to avoid sending "Frag needed" and instead
> fragment the packets after encapsulation.
> 
> Eyal Birger (2):
>   vti: fix ipv4 pmtu check to honor ip header df
>   vti6: fix ipv4 pmtu check to honor ip header df

Thanks Eyal.
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>

Steffen, that's going to conflict with commit 4372339efc06 ("net:
always use icmp{,v6}_ndo_send from ndo_start_xmit") from net.
Steffen Klassert March 3, 2021, 8:30 a.m. UTC | #2 
On Tue, Mar 02, 2021 at 10:32:13AM +0100, Sabrina Dubroca wrote:
> 2021-02-26, 23:35:04 +0200, Eyal Birger wrote:
> > This series aligns vti(6) handling of non-df IPv4 packets exceeding
> > the size of the tunnel MTU to avoid sending "Frag needed" and instead
> > fragment the packets after encapsulation.
> > 
> > Eyal Birger (2):
> >   vti: fix ipv4 pmtu check to honor ip header df
> >   vti6: fix ipv4 pmtu check to honor ip header df
> 
> Thanks Eyal.
> Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
> 
> Steffen, that's going to conflict with commit 4372339efc06 ("net:
> always use icmp{,v6}_ndo_send from ndo_start_xmit") from net.

Applied, thanks everyone!