| Message ID | YDvNSg9OPv7JqfRS@localhost.localdomain (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [01/11] pragma once: delete include/linux/atm_suni.h | expand |
On Sun, Feb 28, 2021 at 08:05:14PM +0300, Alexey Dobriyan wrote: > From 251ca5673886b5bb0a42004944290b9d2b267a4a Mon Sep 17 00:00:00 2001 > From: Alexey Dobriyan <adobriyan@gmail.com> > Date: Fri, 19 Feb 2021 13:37:24 +0300 > Subject: [PATCH 10/11] pragma once: delete few backslashes > > Some macros contain one backslash too many and end up being the last > macro in a header file. When #pragma once conversion script truncates > the last #endif and whitespace before it, such backslash triggers > a warning about "OMG file ends up in a backslash-newline". > > Needless to say I don't want to handle another case in my script, > so delete useless backslashes instead. > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> For mlxsw: Reviewed-by: Ido Schimmel <idosch@nvidia.com> Tested-by: Ido Schimmel <idosch@nvidia.com> Thanks
On 2/28/21 9:05 AM, Alexey Dobriyan wrote: > From 251ca5673886b5bb0a42004944290b9d2b267a4a Mon Sep 17 00:00:00 2001 > From: Alexey Dobriyan <adobriyan@gmail.com> > Date: Fri, 19 Feb 2021 13:37:24 +0300 > Subject: [PATCH 10/11] pragma once: delete few backslashes > > Some macros contain one backslash too many and end up being the last > macro in a header file. When #pragma once conversion script truncates > the last #endif and whitespace before it, such backslash triggers > a warning about "OMG file ends up in a backslash-newline". > > Needless to say I don't want to handle another case in my script, > so delete useless backslashes instead. > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Acked-by: Vineet Gupta <vgupta@synopsys.com> #arch/arc bits Thx, -Vineet > --- > arch/arc/include/asm/cacheflush.h | 2 +- > drivers/net/ethernet/mellanox/mlxsw/item.h | 2 +- > include/linux/once.h | 2 +- > include/media/drv-intf/exynos-fimc.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arc/include/asm/cacheflush.h b/arch/arc/include/asm/cacheflush.h > index e201b4b1655a..46704c341b17 100644 > --- a/arch/arc/include/asm/cacheflush.h > +++ b/arch/arc/include/asm/cacheflush.h > @@ -112,6 +112,6 @@ do { \ > } while (0) > > #define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len); \ > + memcpy(dst, src, len) > > #endif > diff --git a/drivers/net/ethernet/mellanox/mlxsw/item.h b/drivers/net/ethernet/mellanox/mlxsw/item.h > index e92cadc98128..cc0133401dd1 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/item.h > +++ b/drivers/net/ethernet/mellanox/mlxsw/item.h > @@ -504,6 +504,6 @@ mlxsw_##_type##_##_cname##_##_iname##_set(char *buf, u16 index, u8 val) \ > return __mlxsw_item_bit_array_set(buf, \ > &__ITEM_NAME(_type, _cname, _iname), \ > index, val); \ > -} \ > +} > > #endif > diff --git a/include/linux/once.h b/include/linux/once.h > index 9225ee6d96c7..0af450ff94a5 100644 > --- a/include/linux/once.h > +++ b/include/linux/once.h > @@ -55,6 +55,6 @@ void __do_once_done(bool *done, struct static_key_true *once_key, > #define get_random_once(buf, nbytes) \ > DO_ONCE(get_random_bytes, (buf), (nbytes)) > #define get_random_once_wait(buf, nbytes) \ > - DO_ONCE(get_random_bytes_wait, (buf), (nbytes)) \ > + DO_ONCE(get_random_bytes_wait, (buf), (nbytes)) > > #endif /* _LINUX_ONCE_H */ > diff --git a/include/media/drv-intf/exynos-fimc.h b/include/media/drv-intf/exynos-fimc.h > index 6b9ef631d6bb..6c5fbdacf4b5 100644 > --- a/include/media/drv-intf/exynos-fimc.h > +++ b/include/media/drv-intf/exynos-fimc.h > @@ -152,6 +152,6 @@ static inline struct exynos_video_entity *vdev_to_exynos_video_entity( > #define fimc_pipeline_call(ent, op, args...) \ > ((!(ent) || !(ent)->pipe) ? -ENOENT : \ > (((ent)->pipe->ops && (ent)->pipe->ops->op) ? \ > - (ent)->pipe->ops->op(((ent)->pipe), ##args) : -ENOIOCTLCMD)) \ > + (ent)->pipe->ops->op(((ent)->pipe), ##args) : -ENOIOCTLCMD)) > > #endif /* S5P_FIMC_H_ */ >
On 28/02/2021 17:05, Alexey Dobriyan wrote: > From 251ca5673886b5bb0a42004944290b9d2b267a4a Mon Sep 17 00:00:00 2001 > From: Alexey Dobriyan <adobriyan@gmail.com> > Date: Fri, 19 Feb 2021 13:37:24 +0300 > Subject: [PATCH 10/11] pragma once: delete few backslashes > > Some macros contain one backslash too many and end up being the last > macro in a header file. When #pragma once conversion script truncates > the last #endif and whitespace before it, such backslash triggers > a warning about "OMG file ends up in a backslash-newline". > > Needless to say I don't want to handle another case in my script, > so delete useless backslashes instead. > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> > --- > arch/arc/include/asm/cacheflush.h | 2 +- > drivers/net/ethernet/mellanox/mlxsw/item.h | 2 +- > include/linux/once.h | 2 +- > include/media/drv-intf/exynos-fimc.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arc/include/asm/cacheflush.h b/arch/arc/include/asm/cacheflush.h > index e201b4b1655a..46704c341b17 100644 > --- a/arch/arc/include/asm/cacheflush.h > +++ b/arch/arc/include/asm/cacheflush.h > @@ -112,6 +112,6 @@ do { \ > } while (0) > > #define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len); \ > + memcpy(dst, src, len) > This changebar also removes a semicolon. It looks plausibly correct, but the commit message ought to mention it. -ed
Hi! > > index e201b4b1655a..46704c341b17 100644 > > --- a/arch/arc/include/asm/cacheflush.h > > +++ b/arch/arc/include/asm/cacheflush.h > > @@ -112,6 +112,6 @@ do { \ > > } while (0) > > > > #define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > > - memcpy(dst, src, len); \ > > + memcpy(dst, src, len) > > This changebar also removes a semicolon. > It looks plausibly correct, but the commit message ought to mention it. Probably should use do{}while(0) trick. Pavel
diff --git a/arch/arc/include/asm/cacheflush.h b/arch/arc/include/asm/cacheflush.h index e201b4b1655a..46704c341b17 100644 --- a/arch/arc/include/asm/cacheflush.h +++ b/arch/arc/include/asm/cacheflush.h @@ -112,6 +112,6 @@ do { \ } while (0) #define copy_from_user_page(vma, page, vaddr, dst, src, len) \ - memcpy(dst, src, len); \ + memcpy(dst, src, len) #endif diff --git a/drivers/net/ethernet/mellanox/mlxsw/item.h b/drivers/net/ethernet/mellanox/mlxsw/item.h index e92cadc98128..cc0133401dd1 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/item.h +++ b/drivers/net/ethernet/mellanox/mlxsw/item.h @@ -504,6 +504,6 @@ mlxsw_##_type##_##_cname##_##_iname##_set(char *buf, u16 index, u8 val) \ return __mlxsw_item_bit_array_set(buf, \ &__ITEM_NAME(_type, _cname, _iname), \ index, val); \ -} \ +} #endif diff --git a/include/linux/once.h b/include/linux/once.h index 9225ee6d96c7..0af450ff94a5 100644 --- a/include/linux/once.h +++ b/include/linux/once.h @@ -55,6 +55,6 @@ void __do_once_done(bool *done, struct static_key_true *once_key, #define get_random_once(buf, nbytes) \ DO_ONCE(get_random_bytes, (buf), (nbytes)) #define get_random_once_wait(buf, nbytes) \ - DO_ONCE(get_random_bytes_wait, (buf), (nbytes)) \ + DO_ONCE(get_random_bytes_wait, (buf), (nbytes)) #endif /* _LINUX_ONCE_H */ diff --git a/include/media/drv-intf/exynos-fimc.h b/include/media/drv-intf/exynos-fimc.h index 6b9ef631d6bb..6c5fbdacf4b5 100644 --- a/include/media/drv-intf/exynos-fimc.h +++ b/include/media/drv-intf/exynos-fimc.h @@ -152,6 +152,6 @@ static inline struct exynos_video_entity *vdev_to_exynos_video_entity( #define fimc_pipeline_call(ent, op, args...) \ ((!(ent) || !(ent)->pipe) ? -ENOENT : \ (((ent)->pipe->ops && (ent)->pipe->ops->op) ? \ - (ent)->pipe->ops->op(((ent)->pipe), ##args) : -ENOIOCTLCMD)) \ + (ent)->pipe->ops->op(((ent)->pipe), ##args) : -ENOIOCTLCMD)) #endif /* S5P_FIMC_H_ */