| Message ID | 20210224144222.23762-9-daniel.lezcano@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On 24-02-21, 15:42, Daniel Lezcano wrote: > HZ unit conversion macros are available in units.h, use them and > remove the duplicate definition. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/phy/st/phy-stm32-usbphyc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c > index a54317e96c41..02dd12bb4692 100644 > --- a/drivers/phy/st/phy-stm32-usbphyc.c > +++ b/drivers/phy/st/phy-stm32-usbphyc.c > @@ -14,6 +14,7 @@ > #include <linux/of_platform.h> > #include <linux/phy/phy.h> > #include <linux/reset.h> > +#include <linux/units.h> > > #define STM32_USBPHYC_PLL 0x0 > #define STM32_USBPHYC_MISC 0x8 > @@ -48,7 +49,6 @@ static const char * const supplies_names[] = { > #define PLL_FVCO_MHZ 2880 > #define PLL_INFF_MIN_RATE_HZ 19200000 > #define PLL_INFF_MAX_RATE_HZ 38400000 > -#define HZ_PER_MHZ 1000000L I dont see this in units.h, can you send this once it is merged upstream
On 02/03/2021 17:32, Vinod Koul wrote: > On 24-02-21, 15:42, Daniel Lezcano wrote: >> HZ unit conversion macros are available in units.h, use them and >> remove the duplicate definition. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> --- >> drivers/phy/st/phy-stm32-usbphyc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c >> index a54317e96c41..02dd12bb4692 100644 >> --- a/drivers/phy/st/phy-stm32-usbphyc.c >> +++ b/drivers/phy/st/phy-stm32-usbphyc.c >> @@ -14,6 +14,7 @@ >> #include <linux/of_platform.h> >> #include <linux/phy/phy.h> >> #include <linux/reset.h> >> +#include <linux/units.h> >> >> #define STM32_USBPHYC_PLL 0x0 >> #define STM32_USBPHYC_MISC 0x8 >> @@ -48,7 +49,6 @@ static const char * const supplies_names[] = { >> #define PLL_FVCO_MHZ 2880 >> #define PLL_INFF_MIN_RATE_HZ 19200000 >> #define PLL_INFF_MAX_RATE_HZ 38400000 >> -#define HZ_PER_MHZ 1000000L > > I dont see this in units.h, can you send this once it is merged upstream Actually, it is the first patch of the series. I asked Rafael if he can merge the entire series.
On 02-03-21, 18:03, Daniel Lezcano wrote: > On 02/03/2021 17:32, Vinod Koul wrote: > > On 24-02-21, 15:42, Daniel Lezcano wrote: > >> HZ unit conversion macros are available in units.h, use them and > >> remove the duplicate definition. > >> > >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > >> --- > >> drivers/phy/st/phy-stm32-usbphyc.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c > >> index a54317e96c41..02dd12bb4692 100644 > >> --- a/drivers/phy/st/phy-stm32-usbphyc.c > >> +++ b/drivers/phy/st/phy-stm32-usbphyc.c > >> @@ -14,6 +14,7 @@ > >> #include <linux/of_platform.h> > >> #include <linux/phy/phy.h> > >> #include <linux/reset.h> > >> +#include <linux/units.h> > >> > >> #define STM32_USBPHYC_PLL 0x0 > >> #define STM32_USBPHYC_MISC 0x8 > >> @@ -48,7 +49,6 @@ static const char * const supplies_names[] = { > >> #define PLL_FVCO_MHZ 2880 > >> #define PLL_INFF_MIN_RATE_HZ 19200000 > >> #define PLL_INFF_MAX_RATE_HZ 38400000 > >> -#define HZ_PER_MHZ 1000000L > > > > I dont see this in units.h, can you send this once it is merged upstream > > Actually, it is the first patch of the series. > > I asked Rafael if he can merge the entire series. Pls cc folks on cover at least so that they are aware. Thanks
On 03/03/2021 06:40, Vinod Koul wrote: > On 02-03-21, 18:03, Daniel Lezcano wrote: >> On 02/03/2021 17:32, Vinod Koul wrote: >>> On 24-02-21, 15:42, Daniel Lezcano wrote: >>>> HZ unit conversion macros are available in units.h, use them and >>>> remove the duplicate definition. >>>> >>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >>>> --- >>>> drivers/phy/st/phy-stm32-usbphyc.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c >>>> index a54317e96c41..02dd12bb4692 100644 >>>> --- a/drivers/phy/st/phy-stm32-usbphyc.c >>>> +++ b/drivers/phy/st/phy-stm32-usbphyc.c >>>> @@ -14,6 +14,7 @@ >>>> #include <linux/of_platform.h> >>>> #include <linux/phy/phy.h> >>>> #include <linux/reset.h> >>>> +#include <linux/units.h> >>>> >>>> #define STM32_USBPHYC_PLL 0x0 >>>> #define STM32_USBPHYC_MISC 0x8 >>>> @@ -48,7 +49,6 @@ static const char * const supplies_names[] = { >>>> #define PLL_FVCO_MHZ 2880 >>>> #define PLL_INFF_MIN_RATE_HZ 19200000 >>>> #define PLL_INFF_MAX_RATE_HZ 38400000 >>>> -#define HZ_PER_MHZ 1000000L >>> >>> I dont see this in units.h, can you send this once it is merged upstream >> >> Actually, it is the first patch of the series. >> >> I asked Rafael if he can merge the entire series. > > Pls cc folks on cover at least so that they are aware. Yeah, sorry for that. I tend to rely too much on the default 'cccmd'.
diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c index a54317e96c41..02dd12bb4692 100644 --- a/drivers/phy/st/phy-stm32-usbphyc.c +++ b/drivers/phy/st/phy-stm32-usbphyc.c @@ -14,6 +14,7 @@ #include <linux/of_platform.h> #include <linux/phy/phy.h> #include <linux/reset.h> +#include <linux/units.h> #define STM32_USBPHYC_PLL 0x0 #define STM32_USBPHYC_MISC 0x8 @@ -48,7 +49,6 @@ static const char * const supplies_names[] = { #define PLL_FVCO_MHZ 2880 #define PLL_INFF_MIN_RATE_HZ 19200000 #define PLL_INFF_MAX_RATE_HZ 38400000 -#define HZ_PER_MHZ 1000000L struct pll_params { u8 ndiv;
HZ unit conversion macros are available in units.h, use them and remove the duplicate definition. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/phy/st/phy-stm32-usbphyc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)