| Message ID | 20210302145350.2143095-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: dts: imx7d-mba7: Remove unsupported property | expand |
Den tir. 2. mar. 2021 kl. 15.54 skrev Fabio Estevam <festevam@gmail.com>: > > 'disable-gpio' is not a valid property according to > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt. > > Remove the unsupported property. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Reviewed-by: Bruno Thomsen <bruno.thomsen@gmail.com> > --- > arch/arm/boot/dts/imx7d-mba7.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx7d-mba7.dts b/arch/arm/boot/dts/imx7d-mba7.dts > index 5ef86de53013..ebdf9b8efeb3 100644 > --- a/arch/arm/boot/dts/imx7d-mba7.dts > +++ b/arch/arm/boot/dts/imx7d-mba7.dts > @@ -99,7 +99,6 @@ &pcie { > /* probe deferral not supported */ > /* pcie-bus-supply = <®_mpcie_1v5>; */ > reset-gpio = <&gpio5 12 GPIO_ACTIVE_LOW>; > - disable-gpio = <&gpio2 29 GPIO_ACTIVE_LOW>; > power-on-gpio = <&gpio2 30 GPIO_ACTIVE_LOW>; > status = "okay"; > }; > -- > 2.25.1 >
On Tue, 2021-03-02 at 11:53 -0300, Fabio Estevam wrote: > 'disable-gpio' is not a valid property according to > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt. > > Remove the unsupported property. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Reviewed-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> This is a remnant of linux-imx, which supports the property. On the MBa7x (and likely other boards in linux-imx that use this), the GPIO is connected to mPCIe pin 20 (wireless_disable#). Is there an intended way to control this pin, or should it just be left unconfigured or hogged? power-on-gpio seems to be obsolete too, I can't even find it in current linux-imx, except for one other i.MX7D-based DTS. I can send a patch to remove that as well, but it might take a while until I get to it. > --- > arch/arm/boot/dts/imx7d-mba7.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx7d-mba7.dts b/arch/arm/boot/dts/imx7d-mba7.dts > index 5ef86de53013..ebdf9b8efeb3 100644 > --- a/arch/arm/boot/dts/imx7d-mba7.dts > +++ b/arch/arm/boot/dts/imx7d-mba7.dts > @@ -99,7 +99,6 @@ &pcie { > /* probe deferral not supported */ > /* pcie-bus-supply = <®_mpcie_1v5>; */ > reset-gpio = <&gpio5 12 GPIO_ACTIVE_LOW>; > - disable-gpio = <&gpio2 29 GPIO_ACTIVE_LOW>; > power-on-gpio = <&gpio2 30 GPIO_ACTIVE_LOW>; > status = "okay"; > };
On Wed, Mar 03, 2021 at 10:38:08AM +0100, Matthias Schiffer wrote: > On Tue, 2021-03-02 at 11:53 -0300, Fabio Estevam wrote: > > 'disable-gpio' is not a valid property according to > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt. > > > > Remove the unsupported property. > > > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > > Reviewed-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > > > This is a remnant of linux-imx, which supports the property. On the > MBa7x (and likely other boards in linux-imx that use this), the GPIO is > connected to mPCIe pin 20 (wireless_disable#). Is there an intended way > to control this pin, or should it just be left unconfigured or hogged? > > power-on-gpio seems to be obsolete too, I can't even find it in current > linux-imx, except for one other i.MX7D-based DTS. I can send a patch to > remove that as well, but it might take a while until I get to it. Fabio, While we are at it, could you resend to include 'power-on-gpio' cleanup as well? Shawn
diff --git a/arch/arm/boot/dts/imx7d-mba7.dts b/arch/arm/boot/dts/imx7d-mba7.dts index 5ef86de53013..ebdf9b8efeb3 100644 --- a/arch/arm/boot/dts/imx7d-mba7.dts +++ b/arch/arm/boot/dts/imx7d-mba7.dts @@ -99,7 +99,6 @@ &pcie { /* probe deferral not supported */ /* pcie-bus-supply = <®_mpcie_1v5>; */ reset-gpio = <&gpio5 12 GPIO_ACTIVE_LOW>; - disable-gpio = <&gpio2 29 GPIO_ACTIVE_LOW>; power-on-gpio = <&gpio2 30 GPIO_ACTIVE_LOW>; status = "okay"; };
'disable-gpio' is not a valid property according to Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt. Remove the unsupported property. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- arch/arm/boot/dts/imx7d-mba7.dts | 1 - 1 file changed, 1 deletion(-)