| Message ID | 20210115121342.15093-10-vivek.gautam@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iommu/virtio: Nested stage support with Arm | expand |
On Fri, Jan 15, 2021 at 05:43:36PM +0530, Vivek Gautam wrote: > Add info about asid_bits and additional flags to table format > probing header. > > Signed-off-by: Vivek Gautam <vivek.gautam@arm.com> > Cc: Joerg Roedel <joro@8bytes.org> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Michael S. Tsirkin <mst@redhat.com> > Cc: Robin Murphy <robin.murphy@arm.com> > Cc: Jean-Philippe Brucker <jean-philippe@linaro.org> > Cc: Eric Auger <eric.auger@redhat.com> > Cc: Alex Williamson <alex.williamson@redhat.com> > Cc: Kevin Tian <kevin.tian@intel.com> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> > Cc: Liu Yi L <yi.l.liu@intel.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> > --- > include/uapi/linux/virtio_iommu.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/virtio_iommu.h b/include/uapi/linux/virtio_iommu.h > index 43821e33e7af..8a0624bab4b2 100644 > --- a/include/uapi/linux/virtio_iommu.h > +++ b/include/uapi/linux/virtio_iommu.h > @@ -169,7 +169,10 @@ struct virtio_iommu_probe_pasid_size { > struct virtio_iommu_probe_table_format { > struct virtio_iommu_probe_property head; > __le16 format; > - __u8 reserved[2]; > + __le16 asid_bits; > + > + __le32 flags; This struct should only contain the head and format fields. asid and flags should go in a specialized structure - virtio_iommu_probe_pgt_arm64 in the latest spec draft, where I dropped the asid_bits field in favor of an "ASID16" flag. Thanks, Jean
On 3/3/21 10:51 PM, Jean-Philippe Brucker wrote: > On Fri, Jan 15, 2021 at 05:43:36PM +0530, Vivek Gautam wrote: >> Add info about asid_bits and additional flags to table format >> probing header. >> >> Signed-off-by: Vivek Gautam <vivek.gautam@arm.com> >> Cc: Joerg Roedel <joro@8bytes.org> >> Cc: Will Deacon <will.deacon@arm.com> >> Cc: Michael S. Tsirkin <mst@redhat.com> >> Cc: Robin Murphy <robin.murphy@arm.com> >> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org> >> Cc: Eric Auger <eric.auger@redhat.com> >> Cc: Alex Williamson <alex.williamson@redhat.com> >> Cc: Kevin Tian <kevin.tian@intel.com> >> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> >> Cc: Liu Yi L <yi.l.liu@intel.com> >> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >> Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> >> --- >> include/uapi/linux/virtio_iommu.h | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/include/uapi/linux/virtio_iommu.h b/include/uapi/linux/virtio_iommu.h >> index 43821e33e7af..8a0624bab4b2 100644 >> --- a/include/uapi/linux/virtio_iommu.h >> +++ b/include/uapi/linux/virtio_iommu.h >> @@ -169,7 +169,10 @@ struct virtio_iommu_probe_pasid_size { >> struct virtio_iommu_probe_table_format { >> struct virtio_iommu_probe_property head; >> __le16 format; >> - __u8 reserved[2]; >> + __le16 asid_bits; >> + >> + __le32 flags; > > This struct should only contain the head and format fields. asid and flags > should go in a specialized structure - virtio_iommu_probe_pgt_arm64 in the > latest spec draft, where I dropped the asid_bits field in favor of an > "ASID16" flag. Right, will take care of this looking at the spec draft. Best regards Vivek > > Thanks, > Jean >
diff --git a/include/uapi/linux/virtio_iommu.h b/include/uapi/linux/virtio_iommu.h index 43821e33e7af..8a0624bab4b2 100644 --- a/include/uapi/linux/virtio_iommu.h +++ b/include/uapi/linux/virtio_iommu.h @@ -169,7 +169,10 @@ struct virtio_iommu_probe_pasid_size { struct virtio_iommu_probe_table_format { struct virtio_iommu_probe_property head; __le16 format; - __u8 reserved[2]; + __le16 asid_bits; + + __le32 flags; + __u8 reserved[4]; }; struct virtio_iommu_req_probe {
Add info about asid_bits and additional flags to table format probing header. Signed-off-by: Vivek Gautam <vivek.gautam@arm.com> Cc: Joerg Roedel <joro@8bytes.org> Cc: Will Deacon <will.deacon@arm.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Robin Murphy <robin.murphy@arm.com> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org> Cc: Eric Auger <eric.auger@redhat.com> Cc: Alex Williamson <alex.williamson@redhat.com> Cc: Kevin Tian <kevin.tian@intel.com> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: Liu Yi L <yi.l.liu@intel.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> --- include/uapi/linux/virtio_iommu.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)