mbox series

[v3,0/2] Add ACPI support for SC8180X pinctrl driver

Message ID 20210304060520.24975-1-shawn.guo@linaro.org (mailing list archive)
Headers show
Series Add ACPI support for SC8180X pinctrl driver | expand

Message

Shawn Guo March 4, 2021, 6:05 a.m. UTC 
This is a couple of patches that enable ACPI probe for SC8180X pinctrl
driver.  It takes pinctrl-sdm845 driver as the example to remove the
use of tiles, so that we can align memory resource description between
DT and ACPI, and simpfy the driver code.

Changes for v3:
- Remove the use of tiles.
- Drop unneed include of <linux/acpi.h>.

Changes for v2:
- Pass soc_data pointer via .driver_data.
- Drop use of CONFIG_ACPI and ACPI_PTR().
- Add comment for sc8180x_acpi_reserved_gpios[] terminator.
- Add comments for tiles handling.

Shawn Guo (2):
  pinctrl: qcom: sc8180x: drop the use of tiles
  pinctrl: qcom: sc8180x: add ACPI probe support

 drivers/pinctrl/qcom/Kconfig           |  2 +-
 drivers/pinctrl/qcom/pinctrl-sc8180x.c | 80 ++++++++++++++++----------
 2 files changed, 52 insertions(+), 30 deletions(-)

Comments

Andy Shevchenko March 4, 2021, 12:44 p.m. UTC | #1 
On Thu, Mar 04, 2021 at 02:05:18PM +0800, Shawn Guo wrote:
> This is a couple of patches that enable ACPI probe for SC8180X pinctrl
> driver.  It takes pinctrl-sdm845 driver as the example to remove the
> use of tiles, so that we can align memory resource description between
> DT and ACPI, and simpfy the driver code.

Some minor comments, in any case, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

Thanks!

> Changes for v3:
> - Remove the use of tiles.
> - Drop unneed include of <linux/acpi.h>.
> 
> Changes for v2:
> - Pass soc_data pointer via .driver_data.
> - Drop use of CONFIG_ACPI and ACPI_PTR().
> - Add comment for sc8180x_acpi_reserved_gpios[] terminator.
> - Add comments for tiles handling.
> 
> Shawn Guo (2):
>   pinctrl: qcom: sc8180x: drop the use of tiles
>   pinctrl: qcom: sc8180x: add ACPI probe support
> 
>  drivers/pinctrl/qcom/Kconfig           |  2 +-
>  drivers/pinctrl/qcom/pinctrl-sc8180x.c | 80 ++++++++++++++++----------
>  2 files changed, 52 insertions(+), 30 deletions(-)
> 
> -- 
> 2.17.1
>